From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2 09/13] vtd: add lookup_page method to iommu_ops Date: Wed, 11 Jul 2018 11:51:48 +0100 Message-ID: References: <20180707110526.35822-1-paul.durrant@citrix.com> <20180707110526.35822-10-paul.durrant@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fdCis-0004ys-3R for xen-devel@lists.xenproject.org; Wed, 11 Jul 2018 10:51:50 +0000 Received: by mail-qk0-x244.google.com with SMTP id c126-v6so4459774qkd.7 for ; Wed, 11 Jul 2018 03:51:49 -0700 (PDT) In-Reply-To: <20180707110526.35822-10-paul.durrant@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Paul Durrant Cc: xen-devel , Kevin Tian , Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gU2F0LCBKdWwgNywgMjAxOCBhdCAxMjowNSBQTSwgUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJh bnRAY2l0cml4LmNvbT4gd3JvdGU6Cj4gVGhpcyBwYXRjaCBhZGRzIGEgbmV3IG1ldGhvZCB0byB0 aGUgVlQtZCBJT01NVSBpbXBsZW1lbnRhdGlvbiB0byBmaW5kIHRoZQo+IE1GTiBjdXJyZW50bHkg bWFwcGVkIGJ5IHRoZSBzcGVjaWZpZWQgQkZOIGFsb25nIHdpdGggYSB3cmFwcGVyIGZ1bmN0aW9u IGluCj4gZ2VuZXJpYyBJT01NVSBjb2RlIHRvIGNhbGwgdGhlIGltcGxlbWVudGF0aW9uIGlmIGl0 IGV4aXN0cy4KPgo+IFRoaXMgZnVuY3Rpb25hbGl0eSB3aWxsIGJlIHVzZWQgYnkgYSBzdWJzZXF1 ZW50IHBhdGNoLgo+Cj4gU2lnbmVkLW9mZi1ieTogUGF1bCBEdXJyYW50IDxwYXVsLmR1cnJhbnRA Y2l0cml4LmNvbT4KPiAtLS0KPiBDYzogS2V2aW4gVGlhbiA8a2V2aW4udGlhbkBpbnRlbC5jb20+ Cj4gQ2M6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KPgo+IHYyOgo+ICAtIEFkZHJl c3NlZCBzb21lIGNvbW1lbnRzIGZyb20gSmFuLgo+IC0tLQo+ICB4ZW4vZHJpdmVycy9wYXNzdGhy b3VnaC9pb21tdS5jICAgICB8IDExICsrKysrKysrKysKPiAgeGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvdnRkL2lvbW11LmMgfCA0MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Cj4gIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5oIHwgIDEgKwo+ICB4ZW4vaW5j bHVkZS94ZW4vaW9tbXUuaCAgICAgICAgICAgICB8ICA0ICsrKysKPiAgNCBmaWxlcyBjaGFuZ2Vk LCA1NiBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvaW9tbXUuYyBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMKPiBpbmRleCAzZmJk M2ViYWY2Li5mMjVhYTNmMWQ2IDEwMDY0NAo+IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo L2lvbW11LmMKPiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9pb21tdS5jCj4gQEAgLTMw Niw2ICszMDYsMTcgQEAgaW50IGlvbW11X3VubWFwX3BhZ2Uoc3RydWN0IGRvbWFpbiAqZCwgYmZu X3QgYmZuKQo+ICAgICAgcmV0dXJuIHJjOwo+ICB9Cj4KPiAraW50IGlvbW11X2xvb2t1cF9wYWdl KHN0cnVjdCBkb21haW4gKmQsIGJmbl90IGJmbiwgbWZuX3QgKm1mbiwKPiArICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGludCAqZmxhZ3MpCj4gK3sKPiArICAgIGNvbnN0IHN0cnVjdCBk b21haW5faW9tbXUgKmhkID0gZG9tX2lvbW11KGQpOwo+ICsKPiArICAgIGlmICggIWlvbW11X2Vu YWJsZWQgfHwgIWhkLT5wbGF0Zm9ybV9vcHMgKQo+ICsgICAgICAgIHJldHVybiAtRU9QTk9UU1VQ UDsKPiArCj4gKyAgICByZXR1cm4gaGQtPnBsYXRmb3JtX29wcy0+bG9va3VwX3BhZ2UoZCwgYmZu LCBtZm4sIGZsYWdzKTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgaW9tbXVfZnJlZV9wYWdldGFi bGVzKHVuc2lnbmVkIGxvbmcgdW51c2VkKQo+ICB7Cj4gICAgICBkbyB7Cj4gZGlmZiAtLWdpdCBh L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jIGIveGVuL2RyaXZlcnMvcGFzc3Ro cm91Z2gvdnRkL2lvbW11LmMKPiBpbmRleCA3Y2QzODEzYjlmLi40MzhiZWY2NzBkIDEwMDY0NAo+ IC0tLSBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3Z0ZC9pb21tdS5jCj4gKysrIGIveGVuL2Ry aXZlcnMvcGFzc3Rocm91Z2gvdnRkL2lvbW11LmMKPiBAQCAtMTgzMSw2ICsxODMxLDQ1IEBAIHN0 YXRpYyBpbnQgX19tdXN0X2NoZWNrIGludGVsX2lvbW11X3VubWFwX3BhZ2Uoc3RydWN0IGRvbWFp biAqZCwKPiAgICAgIHJldHVybiBkbWFfcHRlX2NsZWFyX29uZShkLCBiZm5fdG9fYmFkZHIoYmZu KSk7Cj4gIH0KPgo+ICtzdGF0aWMgaW50IGludGVsX2lvbW11X2xvb2t1cF9wYWdlKHN0cnVjdCBk b21haW4gKmQsIGJmbl90IGJmbiwgbWZuX3QgKm1mbiwKPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgKmZsYWdzKQo+ICt7Cj4gKyAgICBzdHJ1Y3QgZG9t YWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsKPiArICAgIHN0cnVjdCBkbWFfcHRlICpwYWdl ID0gTlVMTCwgKnB0ZSA9IE5VTEwsIHZhbDsKPiArICAgIHU2NCBwZ19tYWRkcjsKPiArCj4gKyAg ICBzcGluX2xvY2soJmhkLT5hcmNoLm1hcHBpbmdfbG9jayk7Cj4gKwo+ICsgICAgcGdfbWFkZHIg PSBhZGRyX3RvX2RtYV9wYWdlX21hZGRyKGQsIGJmbl90b19iYWRkcihiZm4pLCAwKTsKPiArICAg IGlmICggcGdfbWFkZHIgPT0gMCApCj4gKyAgICB7Cj4gKyAgICAgICAgc3Bpbl91bmxvY2soJmhk LT5hcmNoLm1hcHBpbmdfbG9jayk7Cj4gKyAgICAgICAgcmV0dXJuIC1FTk9NRU07Cj4gKyAgICB9 Cj4gKwo+ICsgICAgcGFnZSA9IG1hcF92dGRfZG9tYWluX3BhZ2UocGdfbWFkZHIpOwo+ICsgICAg cHRlID0gcGFnZSArIChiZm5feChiZm4pICYgTEVWRUxfTUFTSyk7Cj4gKyAgICB2YWwgPSAqcHRl Owo+ICsgICAgaWYgKCAhZG1hX3B0ZV9wcmVzZW50KHZhbCkgKQo+ICsgICAgewo+ICsgICAgICAg IHVubWFwX3Z0ZF9kb21haW5fcGFnZShwYWdlKTsKPiArICAgICAgICBzcGluX3VubG9jaygmaGQt PmFyY2gubWFwcGluZ19sb2NrKTsKPiArICAgICAgICByZXR1cm4gLUVOT01FTTsKClNob3VsZCB0 aGlzIGJlIC1FRVhJU1Q/ICBPciBtYXliZSByZXR1cm4gTUZOX0lOVkFMSUQ/CgpBbHNvLCBjb3Vs ZCB5b3UgZG8gdGhlIHVubWFwIC8gdW5sb2NrIGZpcnN0IGFuZCB0aGVuIGRvIHRoZSBjaGVjaywK cmF0aGVyIHRoYW4gZHVwbGljYXRpbmcgdGhpbmdzPwoKPiArICAgIH0KPiArCj4gKyAgICB1bm1h cF92dGRfZG9tYWluX3BhZ2UocGFnZSk7Cj4gKyAgICBzcGluX3VubG9jaygmaGQtPmFyY2gubWFw cGluZ19sb2NrKTsKPiArCj4gKyAgICAqbWZuID0gbWFkZHJfdG9fbWZuKGRtYV9wdGVfYWRkcih2 YWwpKTsKPiArICAgICpmbGFncyA9IDA7Cj4gKyAgICBpZiAoIGRtYV9wdGVfcHJvdCh2YWwpICYg RE1BX1BURV9SRUFEICkKPiArICAgICAgICAqZmxhZ3MgfD0gSU9NTVVGX3JlYWRhYmxlOwo+ICsg ICAgaWYgKCBkbWFfcHRlX3Byb3QodmFsKSAmIERNQV9QVEVfV1JJVEUgKQo+ICsgICAgICAgICpm bGFncyB8PSBJT01NVUZfd3JpdGFibGU7CgpUaGlzIGlzIGEgYml0IHN0cmFuZ2UsIHNpbmNlIGFs bCBkbWFfcHRlX3Byb3QoKSBkb2VzIGlzIHJldHVybiB2YWwgJgpETUFfUFRFX1JFQUR8RE1BX1BU RV9XUklURS4gIFdvdWxkIGl0IG1ha2Ugc2Vuc2UgdG8gaW1wbGVtZW50CmRtYV9wdGVfcmVhZCgp IC8gZG1hX3B0ZV93cml0ZSgpIGluc3RlYWQgKGxpa2UgZG1hX3B0ZV9wcmVzZW50KCkpPwoKRXZl cnl0aGluZyBlbHNlIGxvb2tzIGdvb2QgdG8gbWUuCgogLUdlb3JnZQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==