From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v4 08/34] vmap: Make the while loop less fishy. Date: Mon, 21 Mar 2016 14:22:58 +0000 Message-ID: References: <1458064616-23101-1-git-send-email-konrad.wilk@oracle.com> <1458064616-23101-9-git-send-email-konrad.wilk@oracle.com> <22250.54910.735489.888445@mariner.uk.xensource.com> <56F0049902000078000DED6A@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai0jV-0003Uk-LE for xen-devel@lists.xenproject.org; Mon, 21 Mar 2016 14:23:01 +0000 Received: by mail-ob0-f193.google.com with SMTP id wz1so14988333obc.1 for ; Mon, 21 Mar 2016 07:23:00 -0700 (PDT) In-Reply-To: <56F0049902000078000DED6A@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Keir Fraser , Andrew Cooper , Ian Jackson , Tim Deegan , mpohlack@amazon.de, Ross Lagerwall , xen-devel , sasha.levin@oracle.com List-Id: xen-devel@lists.xenproject.org T24gTW9uLCBNYXIgMjEsIDIwMTYgYXQgMToyNiBQTSwgSmFuIEJldWxpY2ggPEpCZXVsaWNoQHN1 c2UuY29tPiB3cm90ZToKPj4+PiBPbiAyMS4wMy4xNiBhdCAxMzowNCwgPEdlb3JnZS5EdW5sYXBA ZXUuY2l0cml4LmNvbT4gd3JvdGU6Cj4+IE9uIFRodSwgTWFyIDE3LCAyMDE2IGF0IDQ6MDggUE0s IElhbiBKYWNrc29uIDxJYW4uSmFja3NvbkBldS5jaXRyaXguY29tPiB3cm90ZToKPj4+IEtvbnJh ZCBSemVzenV0ZWsgV2lsayB3cml0ZXMgKCJbUEFUQ0ggdjQgMDgvMzRdIHZtYXA6IE1ha2UgdGhl IHdoaWxlIGxvb3AgbGVzcyBmaXNoeS4iKToKPj4+PiAgIGVycm9yOgo+Pj4+IC0gICAgd2hpbGUg KCBpLS0gKQo+Pj4+IC0gICAgICAgIGZyZWVfZG9taGVhcF9wYWdlKG1mbl90b19wYWdlKG1mbl94 KG1mbltpXSkpKTsKPj4+PiArICAgIHdoaWxlICggaSApCj4+Pj4gKyAgICAgICAgZnJlZV9kb21o ZWFwX3BhZ2UobWZuX3RvX3BhZ2UobWZuX3gobWZuWy0taV0pKSk7Cj4+Pgo+Pj4gSSBxdWl0ZSBz dHJvbmdseSBkaXNsaWtlIHRoaXMuICBJdCBpcyBnb29kIHByYWN0aWNlIHRvIGtlZXAgdGhlIGxv b3AKPj4+IGNvbnRyb2wgY29kZSB0b2dldGhlciB3aGVyZSB0aGlzIGlzIHJlYXNvbmFibHkgY29u dmVuaWVudC4KPj4+Cj4+PiBJIHdvdWxkbid0IHF1aWJibGUgb24gc3VjaCBhIHN0eWxpc3RpYyBt YXR0ZXIgKHBhcnRpY3VsYXJseSBvdXRzaWRlIG15Cj4+PiBiYWlsaXdpY2spIGJ1dCAoYSkgSSB3 b3VsZCBsaWtlIHRvIHJlaW5mb3JjZSBKYW4ncyBwb3NpdGlvbiBhbmQKPj4+IChiKSBpdCBzZWVt cyB3b3J0aCB3cml0aW5nIGFuIGVtYWlsIGFzIHRoZXJlIHdpbGwgYmUgbWFueSBvY2N1cnJlbmNl cy4KPj4KPj4gU2luY2Ugd2UncmUgdGFraW5nIGFib3V0IGdlbmVyYWwgcHJpbmNpcGxlIChhbmQg SSd2ZSBiZWVuIHJlZmVycmVkIHRvCj4+IGhlcmUgZnJvbSBhIHNpbWlsYXIgZGlzY3Vzc2lvbiBl bHNld2hlcmUgWzFdKSwgbGV0IG1lIHdlaWdoIGluIGFzCj4+IHdlbGwuCj4+Cj4+IEkgY2FuIHNl ZSB0aGUgcG9pbnQgb2Ygbm90IHdhbnRpbmcgdGhlIGRlY3JlbWVudCB0byBiZSBpbiB0aGUgbWlk ZGxlCj4+IG9mIHRoZSBleHByZXNzaW9uIGhlcmUuICBCdXQgSSBhbHNvIGVudGlyZWx5IGFncmVl IHdpdGggS29ucmFkJ3MKPj4gYXNzZXNzbWVudCB0aGF0IHRoaXMgY29kZSBpcyBsaWtlbHkgdG8g YmUgY29uZnVzaW5nOyBhbmQgdGhlIGZhY3QgdGhhdAo+PiBhIGNvbXB1dGVyIHByb2dyYW0gZm9s bG93aW5nIGEgbGlzdCBvZiBydWxlcyAqZGV2ZWxvcGVkIGJ5Cj4+IHByb2Zlc3Npb25hbCBidWct ZmluZGVycyogaXMgY29uZnVzZWQgYnkgdGhpcyBraW5kIG9mIHNlbWFudGljcyBJCj4+IHRoaW5r IHN1cHBvcnRzIHRoaXMgYXNzZXNzbWVudC4gIEF0IHZlcnkgbGVhc3QgaXQgaGFzIHRoZSBwb3Rl bnRpYWwgdG8KPj4gd2FzdGUgYSBsb3Qgb2YgbWVudGFsIGVuZXJneSBmaWd1cmluZyBvdXQgd2h5 IGNvZGUgdGhhdCBsb29rcyB3cm9uZwo+PiBpc24ndCB3cm9uZzsgYW5kIGF0IHdvcnN0IHRoZXJl J3MgYSByaXNrIHRoYXQgYXQgc29tZSBwb2ludCBzb21lb25lCj4+IHdpbGwgImZpeCIgaXQgaW5j b3JyZWN0bHkuCj4+Cj4+IFRoZSBmYWN0IHRoYXQgdGhlcmUgYXJlIGFscmVhZHkgbWFueSBpbnN0 YW5jZXMgb2YgdGhpcyBwYXR0ZXJuIGluIHRoZQo+PiBzb3VyY2UgdHJlZSB3b3VsZCBiZSByZWxl dmFudCBpZiB3ZSBleHBlY3Qgbm9ib2R5IGJ1dCBwZW9wbGUgY3VycmVudGx5Cj4+IGZhbWlsaWFy IHdpdGggdGhlIGNvZGUgdG8gZXZlcnkgdHJ5IHRvIHJlYWQgb3IgbW9kaWZ5IGl0LiAgQnV0IHNp bmNlCj4+IG9uIHRoZSBjb250cmFyeSB3ZSBob3BlIHRoYXQgb3RoZXJzIHdpbGwgY29udHJpYnV0 ZSB0byB0aGUgY29kZWJhc2UsCj4+IGFuZCBldmVuIHRoYXQgdGhleSBtYXkgZXZlbnR1YWxseSBi ZWNvbWUgbWFpbnRhaW5lcnMsIEkgdGhpbmsgdGhlcmUgaXMKPj4gc2Vuc2UgaW4gYWRkcmVzc2lu ZyB0aGVtLCBhdCBsZWFzdCBhcyB0aGV5IGNvbWUgdXAuCj4KPiBXZWxsLCBpZiB0YWxrIHdhcyBh Ym91dCBzb21ldGhpbmcgcmVhbGx5IGNvbXBsZXggaGVyZSwgSSBtaWdodAo+IGFncmVlLiBCdXQg dW5hcnkgcHJlZml4IGFuZCBwb3N0Zml4IG9wZXJhdG9ycyBhcmUgYW4gaW50ZWdyYWwKPiBwYXJ0 IG9mIHRoZSBDIGxhbmd1YWdlLCBhbmQgd2hpbGUgY29kZSByZWFkaW5nIGluZGVlZCBzaG91bGRu J3QKPiByZXF1aXJlIG92ZXJseSBtdWNoIG1lbnRhbCBlbmVyZ3ksIEkgdGhpbmsgd2Ugc2hvdWxk IGJlCj4gcGVybWl0dGVkIHRvIG1ha2UgZnVsbCBrbm93bGVkZ2Ugb2YgdGhlIGJhc2UgcHJvZ3Jh bW1pbmcKPiBsYW5ndWFnZSBhIHByZXJlcSB0byByZWFkaW5nIG91ciBjb2RlLiBPdGhlcndpc2Ug LSB3aGVyZSBkbwo+IHlvdSB3YW50IHRvIGRyYXcgdGhlIGJvdW5kYXJ5IG9mIHdoYXQgaXMgcGVy bWl0dGVkIGFuZCB3aGF0Cj4gaXMgbm90PyAoWWVzLCBJIGtub3cgSSdtIGd1aWx0eSBpbiBvY2Nh c2lvbmFsbHkgd3JpdGluZyByYXRoZXIKPiBjb21wbGV4IGV4cHJlc3Npb25zLCB3aXRoIGF0IHRp bWVzIG5vdCBpbW1lZGlhdGVseSBvYnZpb3VzIHNpZGUKPiBlZmZlY3RzLCBhbmQgSSdtIHRyeWlu ZyB0byBkbyBiZXR0ZXIgaXJyZXNwZWN0aXZlIG9mIGFsbCBzdWNoIGFsc28KPiBmYWxsaW5nIGlu IHRoZSBhYm92ZSAiYmFzaWMgbGFuZ3VhZ2UiIGZlYXR1cmVzIGNhdGVnb3J5LiBUaGF0J3MKPiBi ZWNhdXNlIEkgY2FuIHNlZSBkb2luZyBzbyBiZWluZyBwYXN0IHRoZSBib3VuZGFyeSBvZgo+IHJl YXNvbmFibHkgdW5kZXJzdGFuZGFibGUgY29kZS4pCgpBbmQgSSdtIG5vdCBzYXlpbmcgdGhhdCB3 ZSBjYW4ndCB0YWtlIGFkdmFudGFnZSBvZiBwb3N0Zml4IG9wZXJhdG9ycwppbiB0aGlzIGNhc2U7 IEknbSBqdXN0IHNheWluZyB0aGF0IGlmIHdlIGFyZSBnb2luZyB0bywgaXQgd291bGQgYmUKYmV0 dGVyIHRvIHBvaW50IGl0IG91dCBpbiBhIGNvbW1lbnQuCgpUaGVyZSBhcmUgbG90cyBvZiAiZmVh dHVyZXMiIG9mIEMgdGhhdCBzdGFuZGFyZCBwcmFjdGljZSBzdGlsbCBkZW1hbmRzCnRoYXQgd2Ug YWRkIGEgY29tbWVudCBmb3I7IHRoZSBkZWZhdWx0IGZhbGwtdGhyb3VnaCBmb3Igc3dpdGNoCnN0 YXRlbWVudHMgY29tZXMgdG8gbWluZC4gIE9mIGNvdXJzZSBwcm9ncmFtbWVycyBzaG91bGQgYmUg cmVxdWlyZWQgdG8Ka25vdyB0aGF0IHN3aXRjaCBzdGF0ZW1lbnRzIGRlZmF1bHQgdG8gZmFsbHRo cm91Z2ggaW4gQzsgYnV0IGl0J3MKc3RpbGwgYSBjb21tb24gbWlzdGFrZSB0byBmb3JnZXQgdGhh dCwgYW5kIHNvIHdlIHBvaW50IHRoZW0gaW4gdGhlCnJpZ2h0IGRpcmVjdGlvbiBieSBhZGRpbmcg Y29tbWVudHMuCgpTaW1pbGFybHksIG9mIGNvdXJzZSBwcm9ncmFtbWVycyBzaG91bGQga25vdyB0 aGUgZGlmZmVyZW5jZSBiZXR3ZWVuCnByZWZpeCBhbmQgcG9zdGZpeCBvcGVyYXRvcnMuICBCdXQg dGhpcyBpcyBhIGNhc2Ugd2hlcmUgdGhlcmUncyBhIHJpc2sKb2YgdHJpcHBpbmcgb3ZlciBzb21l dGhpbmcsIHNvIGl0IG1ha2VzIHNlbnNlIHRvIHBvaW50IHRoZW0gaW4gdGhlCnJpZ2h0IGRpcmVj dGlvbiBieSBhZGRpbmcgY29tbWVudHMuCgpPciB0byB0YWtlIGEgZGlmZmVyZW50IHRhY2s6IEkg dW5kZXJzdGFuZCB0aGF0IHlvdSBkb24ndCB0aGluayB0aGVyZSdzCm5vIHBhcnRpY3VsYXIgYmVu ZWZpdCB0byBhZGRpbmcgYSBjb21tZW50IGluIGNhc2VzIGxpa2UgdGhpczsgY291bGQKeW91IGV4 cGxhaW4gdG8gbWUgd2h5IHlvdSB0aGluayBpdCB3b3VsZCBoYXZlIGEgc2lnbmlmaWNhbnQgY29z dD8KCj4+IGRvIHsKPj4gIGktLTsKPj4gIFtjbGVhbnVwXQo+PiB9IHdoaWxlICggaSA+IDAgKTsK Pj4KPgo+IEJ1dCB5b3UgcmVhbGl6ZSB0aGF0IHRoZSBmaXJzdCAoYnV0IG5vdCB0aGUgc2Vjb25k KSBvbmUgaXMgd3JvbmcgZm9yCj4gdGhlIGkgPT0gMCBjYXNlPwoKU28gaXQgaXMuICBJIHRoaW5r IEkgd2FzIHRoaW5raW5nIG9mIGEgY2FzZSB3aGVyZSBpdCB3YXMga25vd24gdGhhdCBhdApsZWFz dCBvbmUgaXRlcmF0aW9uIGhhZCBzdWNjZWVkZWQ7IGJ1dCBvYnZpb3VzbHkgdGhlIHNlY29uZCBp cyBtb3JlCnNhZmUgaW4gZ2VuZXJhbC4KCiAtR2VvcmdlCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZl bEBsaXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=