From: George Dunlap <dunlapg@umich.edu>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/6] x86: move invocations of hvm_flush_guest_tlbs()
Date: Fri, 19 Jan 2018 17:29:42 +0000 [thread overview]
Message-ID: <CAFLBxZbFP=mPWe6ah3njGBYrMeqnPATie5-TJ4V5WAMF2=U_ew@mail.gmail.com> (raw)
In-Reply-To: <5A6224C302000078001A0788@prv-mh.provo.novell.com>
On Fri, Jan 19, 2018 at 4:02 PM, Jan Beulich <JBeulich@suse.com> wrote:
> Their need is not tied to the actual flushing of TLBs, but the ticking
> of the TLB clock. Make this more obvious by folding the two invocations
> into a single one in pre_flush().
So now pre_flush() actually does the flush?
I don't object to the change per se (and from what I can tell it's
technically correct), but I think you're making things any clearer.
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-01-19 19:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 15:57 [PATCH 0/6] misc flush and dirty-mask related adjustments Jan Beulich
2018-01-19 16:02 ` [PATCH 1/6] x86: move invocations of hvm_flush_guest_tlbs() Jan Beulich
2018-01-19 17:00 ` Andrew Cooper
2018-01-19 17:29 ` George Dunlap [this message]
2018-01-22 9:30 ` Jan Beulich
2018-01-19 16:03 ` [PATCH 2/6] x86: make CPU state flush requests explicit Jan Beulich
2018-01-19 17:40 ` Andrew Cooper
2018-01-22 9:31 ` Jan Beulich
2018-01-22 9:32 ` Andrew Cooper
2018-01-19 16:04 ` [PATCH 3/6] add check to cpumask_of() Jan Beulich
2018-01-19 16:59 ` Wei Liu
2018-01-19 17:43 ` Andrew Cooper
2018-01-22 9:35 ` Jan Beulich
2018-01-19 16:06 ` [PATCH 4/6] replace vCPU's dirty CPU mask by numeric ID Jan Beulich
2018-01-19 17:41 ` George Dunlap
2018-01-19 17:48 ` Andrew Cooper
2018-01-22 9:39 ` Jan Beulich
2018-01-22 9:44 ` Andrew Cooper
2018-01-19 16:06 ` [PATCH 5/6] x86: avoid explicit TLB flush when saving exec state Jan Beulich
2018-01-19 17:59 ` George Dunlap
2018-01-19 18:23 ` George Dunlap
2018-01-22 9:56 ` Jan Beulich
2018-01-19 18:12 ` Andrew Cooper
2018-01-22 10:00 ` Jan Beulich
2018-01-19 16:07 ` [PATCH 6/6] drop "domain_" prefix from struct domain's dirty CPU mask Jan Beulich
2018-01-19 16:15 ` Wei Liu
2018-01-19 17:56 ` Andrew Cooper
2018-01-22 10:06 ` Jan Beulich
2018-01-19 18:01 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLBxZbFP=mPWe6ah3njGBYrMeqnPATie5-TJ4V5WAMF2=U_ew@mail.gmail.com' \
--to=dunlapg@umich.edu \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.