From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH 1/5] tools/mkrpm: improve version.release handling Date: Mon, 23 Mar 2015 18:07:10 +0000 Message-ID: References: <1426872279-5001-1-git-send-email-olaf@aepfle.de> <1426872279-5001-2-git-send-email-olaf@aepfle.de> <55103C3E.3000302@eu.citrix.com> <20150323175232.GA13774@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150323175232.GA13774@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Ian Jackson , "xen-devel@lists.xen.org" , Wei Liu , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Mon, Mar 23, 2015 at 5:52 PM, Olaf Hering wrote: > On Mon, Mar 23, George Dunlap wrote: > >> xen-4.6_unstable-20150323160547.x86_64.rpm > > Do you want to continue to get "unstable" as release? > My patch uses everything passed as "$2" as Version string. I think thats > ok. I think "unstable" (or "pre" for the stable branches) should definitely be in there to distinguish it from an actual release. If I were writing the patch I might consider taking out the _ (i.e., s/-//; instead of s/-/_/;) but that's not a big deal. > Release will be either 0 or $PKG_DATE. You mean, "0 or $PKG_RELEASE"? I had in mind that someone might want to either set their own package release manually (PKG_RELEASE="9"), or do PKG_RELEASE="$(git log RELEASE-4.5.0.. | wc -l)" Thanks, -George