From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes. Date: Tue, 19 Mar 2013 15:29:36 +0000 Message-ID: References: <1363609123-20748-1-git-send-email-alex@alex.org.uk> <51471767.8030604@redhat.com> <7AC8953FE45335FB794B6DFE@Ximines.local> <51471F14.7030209@redhat.com> <6D0F4ACDA3B7FCF1A50F8B52@Ximines.local> <5147298C.8080900@redhat.com> <51473E82.1020806@redhat.com> <861AFE1A9C44444FD8BAEE16@Ximines.local> <5147512E.5050501@eu.citrix.com> <5147562E.1090203@redhat.com> <5148414C.7060303@redhat.com> <51484328.4030301@eu.citrix.com> <5148489C.70808@redhat.com> <51484A2B.10202@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Paolo Bonzini Cc: Ian Campbell , Stefano Stabellini , Ian Jackson , "qemu-devel@nongnu.org" , xen-devel , Alex Bligh , Anthony Liguori List-Id: xen-devel@lists.xenproject.org On Tue, Mar 19, 2013 at 3:12 PM, George Dunlap wrote: > > I've just had a chat with Stefano, and it turns out I was a bit > confused -- this change has nothing to do with qemu running as a > device model, but only as qemu running as a PV back-end for PV guests. > So the question of when in the save/restore process the qemu is > started is moot. Alex, the title of the changelog should certainly be more specific, so people aren't confused. Maybe something like the following? "Disable use of O_DIRECT when acting as a Xen PV backend" And emphasizing in the changelog that this has no effect on qemu when acting as a device model for Xen? -George