From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2] remove unnecessary null pointer checks before frees Date: Mon, 7 Oct 2013 11:15:53 +0100 Message-ID: References: <1380423939-15012-1-git-send-email-mattjd@gmail.com> <1380425218-15403-1-git-send-email-mattjd@gmail.com> <1380807783.25618.15.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1380807783.25618.15.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Andrew Cooper , Matthew Daley , "xen-devel@lists.xen.org" , Samuel Thibault , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thu, Oct 3, 2013 at 2:43 PM, Ian Campbell wrote: > On Sun, 2013-09-29 at 16:26 +1300, Matthew Daley wrote: >> Oops, spatch removed an #if 0'd hunk from gtraceview.c. Here's a fixed version: >> >> -- 8< -- >> >> Patch generated by the following semantic patch >> (http://coccinelle.lip6.fr/): >> >> @@ >> expression *P; >> @@ >> >> - if(P) free(P); >> + free(P); >> >> ...and then by filtering through the following command: >> >> filterdiff -p1 -x 'stubdom/*' -x 'tools/firmware/*' -x 'tools/qemu-*' >> >> Signed-off-by: Matthew Daley >> --- > [...] >> tools/blktap/drivers/blktapctrl.c | 6 ++---- >> tools/blktap/drivers/tapaio.c | 18 ++++++---------- >> tools/blktap/drivers/tapdisk.c | 9 +++----- >> tools/blktap/lib/xenbus.c | 21 +++++++------------ >> tools/blktap/lib/xs_api.c | 3 +-- >> tools/blktap2/control/tap-ctl-list.c | 6 ++---- >> tools/blktap2/drivers/block-log.c | 3 +-- > > I'm slightly inclined to not touch these unmaintained bits, especially > blktap1 from a "if it aint' broke" type mentality and a reluctance to > touch it even for such an obviously correct change. > > What do others think? That certainly sounds reasonable. -George