From: George Dunlap <dunlapg@umich.edu>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v2 1/3] x86/PoD: simplify / improve p2m_pod_cache_add()
Date: Thu, 1 Feb 2024 13:48:32 +0000 [thread overview]
Message-ID: <CAFLBxZbUeuyLx998fpxeOCGjbgR4C_aLJcN-To9isfOcQ3iYNA@mail.gmail.com> (raw)
In-Reply-To: <0c61e460-122c-6486-00b7-22a9a24ee1fc@suse.com>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Tue, Jan 4, 2022 at 9:48 AM Jan Beulich <jbeulich@suse.com> wrote:
> Avoid recurring MFN -> page or page -> MFN translations. Drop the pretty
> pointless local variable "p". Make sure the MFN logged in a debugging
> error message is actually the offending one. Return negative errno
> values rather than -1 (presently no caller really cares, but imo this
> should change). Adjust style.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
Sorry, not sure how I managed to miss this:
Reviewed-by: George Dunlap <george.dunlap@cloud.com>
[-- Attachment #2: Type: text/html, Size: 1165 bytes --]
next prev parent reply other threads:[~2024-02-01 13:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 9:47 [PATCH v2 0/3] x86/mm: address observations made while working on XSA-388 Jan Beulich
2022-01-04 9:48 ` [PATCH v2 1/3] x86/PoD: simplify / improve p2m_pod_cache_add() Jan Beulich
2022-01-27 15:04 ` Ping: " Jan Beulich
2022-02-24 13:02 ` Ping²: " Jan Beulich
2024-02-01 13:48 ` George Dunlap [this message]
2022-01-04 9:48 ` [PATCH v2 2/3] x86/altp2m: p2m_altp2m_get_or_propagate() should honor present page order Jan Beulich
2022-01-04 15:00 ` Tamas K Lengyel
2022-01-04 16:14 ` Jan Beulich
2022-01-04 17:30 ` Tamas K Lengyel
2022-01-04 9:49 ` [PATCH RFC v2 3/3] x86/altp2m: p2m_altp2m_propagate_change() " Jan Beulich
2022-01-04 17:48 ` Tamas K Lengyel
2022-01-05 8:59 ` Jan Beulich
2022-01-05 16:25 ` Tamas K Lengyel
2022-01-06 13:50 ` Jan Beulich
2022-01-06 14:48 ` Tamas K Lengyel
2022-01-06 14:54 ` Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLBxZbUeuyLx998fpxeOCGjbgR4C_aLJcN-To9isfOcQ3iYNA@mail.gmail.com \
--to=dunlapg@umich.edu \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.