From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <George.Dunlap@eu.citrix.com>
Subject: Re: [PATCH 2/2] x86/mm: Use mfn_t for make_cr3()
Date: Fri, 1 Sep 2017 18:30:59 +0100
Message-ID: <CAFLBxZbyqJPuz9xeknh3wy=QFJPB_do3dO6kFzNWp+Ef467uwg@mail.gmail.com>
References: <1504095573-14153-1-git-send-email-andrew.cooper3@citrix.com>
 <1504095573-14153-2-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1504095573-14153-2-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Tim Deegan <tim@xen.org>, Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

T24gV2VkLCBBdWcgMzAsIDIwMTcgYXQgMToxOSBQTSwgQW5kcmV3IENvb3Blcgo8YW5kcmV3LmNv
b3BlcjNAY2l0cml4LmNvbT4gd3JvdGU6Cj4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UuCj4KPiBTaWdu
ZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgoKQWNr
ZWQtYnk6IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT4KCj4gLS0tCj4g
Q0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4KPiBDQzogV2VpIExpdSA8d2VpLmxp
dTJAY2l0cml4LmNvbT4KPiBDQzogVGltIERlZWdhbiA8dGltQHhlbi5vcmc+Cj4gQ0M6IEdlb3Jn
ZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAZXUuY2l0cml4LmNvbT4KPiAtLS0KPiAgeGVuL2FyY2gv
eDg2L21tLmMgICAgICAgICAgICAgICB8IDEwICsrKysrLS0tLS0KPiAgeGVuL2FyY2gveDg2L21t
L2hhcC9oYXAuYyAgICAgICB8ICAyICstCj4gIHhlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvY29tbW9u
LmMgfCAgOCArKysrLS0tLQo+ICB4ZW4vYXJjaC94ODYvbW0vc2hhZG93L211bHRpLmMgIHwgIDQg
KystLQo+ICB4ZW4vaW5jbHVkZS9hc20teDg2L21tLmggICAgICAgIHwgIDIgKy0KPiAgNSBmaWxl
cyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1n
aXQgYS94ZW4vYXJjaC94ODYvbW0uYyBiL3hlbi9hcmNoL3g4Ni9tbS5jCj4gaW5kZXggZGMwN2I0
Zi4uZjBjODFlNyAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvbW0uYwo+ICsrKyBiL3hlbi9h
cmNoL3g4Ni9tbS5jCj4gQEAgLTQ5OCw5ICs0OTgsOSBAQCB2b2lkIGZyZWVfc2hhcmVkX2RvbWhl
YXBfcGFnZShzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlKQo+ICAgICAgZnJlZV9kb21oZWFwX3BhZ2Uo
cGFnZSk7Cj4gIH0KPgo+IC12b2lkIG1ha2VfY3IzKHN0cnVjdCB2Y3B1ICp2LCB1bnNpZ25lZCBs
b25nIG1mbikKPiArdm9pZCBtYWtlX2NyMyhzdHJ1Y3QgdmNwdSAqdiwgbWZuX3QgbWZuKQo+ICB7
Cj4gLSAgICB2LT5hcmNoLmNyMyA9IG1mbiA8PCBQQUdFX1NISUZUOwo+ICsgICAgdi0+YXJjaC5j
cjMgPSBtZm5feChtZm4pIDw8IFBBR0VfU0hJRlQ7Cj4gIH0KPgo+ICB2b2lkIHdyaXRlX3B0YmFz
ZShzdHJ1Y3QgdmNwdSAqdikKPiBAQCAtNTE4LDcgKzUxOCw3IEBAIHZvaWQgd3JpdGVfcHRiYXNl
KHN0cnVjdCB2Y3B1ICp2KQo+ICAgKi8KPiAgdm9pZCB1cGRhdGVfY3IzKHN0cnVjdCB2Y3B1ICp2
KQo+ICB7Cj4gLSAgICB1bnNpZ25lZCBsb25nIGNyM19tZm47Cj4gKyAgICBtZm5fdCBjcjNfbWZu
Owo+Cj4gICAgICBpZiAoIHBhZ2luZ19tb2RlX2VuYWJsZWQodi0+ZG9tYWluKSApCj4gICAgICB7
Cj4gQEAgLTUyNyw5ICs1MjcsOSBAQCB2b2lkIHVwZGF0ZV9jcjMoc3RydWN0IHZjcHUgKnYpCj4g
ICAgICB9Cj4KPiAgICAgIGlmICggISh2LT5hcmNoLmZsYWdzICYgVEZfa2VybmVsX21vZGUpICkK
PiAtICAgICAgICBjcjNfbWZuID0gcGFnZXRhYmxlX2dldF9wZm4odi0+YXJjaC5ndWVzdF90YWJs
ZV91c2VyKTsKPiArICAgICAgICBjcjNfbWZuID0gcGFnZXRhYmxlX2dldF9tZm4odi0+YXJjaC5n
dWVzdF90YWJsZV91c2VyKTsKPiAgICAgIGVsc2UKPiAtICAgICAgICBjcjNfbWZuID0gcGFnZXRh
YmxlX2dldF9wZm4odi0+YXJjaC5ndWVzdF90YWJsZSk7Cj4gKyAgICAgICAgY3IzX21mbiA9IHBh
Z2V0YWJsZV9nZXRfbWZuKHYtPmFyY2guZ3Vlc3RfdGFibGUpOwo+Cj4gICAgICBtYWtlX2NyMyh2
LCBjcjNfbWZuKTsKPiAgfQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvbW0vaGFwL2hhcC5j
IGIveGVuL2FyY2gveDg2L21tL2hhcC9oYXAuYwo+IGluZGV4IDE1ZTQ4NzcuLjY5NDZmZGUgMTAw
NjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L21tL2hhcC9oYXAuYwo+ICsrKyBiL3hlbi9hcmNoL3g4
Ni9tbS9oYXAvaGFwLmMKPiBAQCAtNzE5LDcgKzcxOSw3IEBAIHN0YXRpYyB2b2lkIGhhcF91cGRh
dGVfcGFnaW5nX21vZGVzKHN0cnVjdCB2Y3B1ICp2KQo+ICAgICAgewo+ICAgICAgICAgIG1mbl90
IG1tZm4gPSBoYXBfbWFrZV9tb25pdG9yX3RhYmxlKHYpOwo+ICAgICAgICAgIHYtPmFyY2gubW9u
aXRvcl90YWJsZSA9IHBhZ2V0YWJsZV9mcm9tX21mbihtbWZuKTsKPiAtICAgICAgICBtYWtlX2Ny
Myh2LCBtZm5feChtbWZuKSk7Cj4gKyAgICAgICAgbWFrZV9jcjModiwgbW1mbik7Cj4gICAgICAg
ICAgaHZtX3VwZGF0ZV9ob3N0X2NyMyh2KTsKPiAgICAgIH0KPgo+IGRpZmYgLS1naXQgYS94ZW4v
YXJjaC94ODYvbW0vc2hhZG93L2NvbW1vbi5jIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9jb21t
b24uYwo+IGluZGV4IGU4ZWU2ZGIuLjM5MjZlZDYgMTAwNjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2
L21tL3NoYWRvdy9jb21tb24uYwo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvY29tbW9u
LmMKPiBAQCAtMjk2MSw3ICsyOTYxLDcgQEAgc3RhdGljIHZvaWQgc2hfdXBkYXRlX3BhZ2luZ19t
b2RlcyhzdHJ1Y3QgdmNwdSAqdikKPiAgICAgICAgICB7Cj4gICAgICAgICAgICAgIG1mbl90IG1t
Zm4gPSB2LT5hcmNoLnBhZ2luZy5tb2RlLT5zaGFkb3cubWFrZV9tb25pdG9yX3RhYmxlKHYpOwo+
ICAgICAgICAgICAgICB2LT5hcmNoLm1vbml0b3JfdGFibGUgPSBwYWdldGFibGVfZnJvbV9tZm4o
bW1mbik7Cj4gLSAgICAgICAgICAgIG1ha2VfY3IzKHYsIG1mbl94KG1tZm4pKTsKPiArICAgICAg
ICAgICAgbWFrZV9jcjModiwgbW1mbik7Cj4gICAgICAgICAgICAgIGh2bV91cGRhdGVfaG9zdF9j
cjModik7Cj4gICAgICAgICAgfQo+Cj4gQEAgLTMwMDQsNyArMzAwNCw3IEBAIHN0YXRpYyB2b2lk
IHNoX3VwZGF0ZV9wYWdpbmdfbW9kZXMoc3RydWN0IHZjcHUgKnYpCj4gICAgICAgICAgICAgICAg
ICAvKiBEb24ndCBiZSBydW5uaW5nIG9uIHRoZSBvbGQgbW9uaXRvciB0YWJsZSB3aGVuIHdlCj4g
ICAgICAgICAgICAgICAgICAgKiBwdWxsIGl0IGRvd24hICBTd2l0Y2ggQ1IzLCBhbmQgd2FybiB0
aGUgSFZNIGNvZGUgdGhhdAo+ICAgICAgICAgICAgICAgICAgICogaXRzIGhvc3QgY3IzIGhhcyBj
aGFuZ2VkLiAqLwo+IC0gICAgICAgICAgICAgICAgbWFrZV9jcjModiwgbWZuX3gobmV3X21mbikp
Owo+ICsgICAgICAgICAgICAgICAgbWFrZV9jcjModiwgbmV3X21mbik7Cj4gICAgICAgICAgICAg
ICAgICBpZiAoIHYgPT0gY3VycmVudCApCj4gICAgICAgICAgICAgICAgICAgICAgd3JpdGVfcHRi
YXNlKHYpOwo+ICAgICAgICAgICAgICAgICAgaHZtX3VwZGF0ZV9ob3N0X2NyMyh2KTsKPiBAQCAt
MzM4MCw5ICszMzgwLDkgQEAgc3RhdGljIGludCBzaGFkb3dfb25lX2JpdF9kaXNhYmxlKHN0cnVj
dCBkb21haW4gKmQsIHUzMiBtb2RlKQo+ICAgICAgICAgICAgICBpZiAoIHYtPmFyY2gucGFnaW5n
Lm1vZGUgKQo+ICAgICAgICAgICAgICAgICAgdi0+YXJjaC5wYWdpbmcubW9kZS0+c2hhZG93LmRl
dGFjaF9vbGRfdGFibGVzKHYpOwo+ICAgICAgICAgICAgICBpZiAoICEodi0+YXJjaC5mbGFncyAm
IFRGX2tlcm5lbF9tb2RlKSApCj4gLSAgICAgICAgICAgICAgICBtYWtlX2NyMyh2LCBwYWdldGFi
bGVfZ2V0X3Bmbih2LT5hcmNoLmd1ZXN0X3RhYmxlX3VzZXIpKTsKPiArICAgICAgICAgICAgICAg
IG1ha2VfY3IzKHYsIHBhZ2V0YWJsZV9nZXRfbWZuKHYtPmFyY2guZ3Vlc3RfdGFibGVfdXNlcikp
Owo+ICAgICAgICAgICAgICBlbHNlCj4gLSAgICAgICAgICAgICAgICBtYWtlX2NyMyh2LCBwYWdl
dGFibGVfZ2V0X3Bmbih2LT5hcmNoLmd1ZXN0X3RhYmxlKSk7Cj4gKyAgICAgICAgICAgICAgICBt
YWtlX2NyMyh2LCBwYWdldGFibGVfZ2V0X21mbih2LT5hcmNoLmd1ZXN0X3RhYmxlKSk7Cj4KPiAg
I2lmIChTSEFET1dfT1BUSU1JWkFUSU9OUyAmIFNIT1BUX09VVF9PRl9TWU5DKQo+ICAgICAgICAg
ICAgICB7Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cvbXVsdGkuYyBiL3hl
bi9hcmNoL3g4Ni9tbS9zaGFkb3cvbXVsdGkuYwo+IGluZGV4IGM1YzBhZjguLmY3ZWZlNjYgMTAw
NjQ0Cj4gLS0tIGEveGVuL2FyY2gveDg2L21tL3NoYWRvdy9tdWx0aS5jCj4gKysrIGIveGVuL2Fy
Y2gveDg2L21tL3NoYWRvdy9tdWx0aS5jCj4gQEAgLTQyNzMsNyArNDI3Myw3IEBAIHNoX3VwZGF0
ZV9jcjMoc3RydWN0IHZjcHUgKnYsIGludCBkb19sb2NraW5nKQo+ICAgICAgLy8vCj4gICAgICBp
ZiAoIHNoYWRvd19tb2RlX2V4dGVybmFsKGQpICkKPiAgICAgIHsKPiAtICAgICAgICBtYWtlX2Ny
Myh2LCBwYWdldGFibGVfZ2V0X3Bmbih2LT5hcmNoLm1vbml0b3JfdGFibGUpKTsKPiArICAgICAg
ICBtYWtlX2NyMyh2LCBwYWdldGFibGVfZ2V0X21mbih2LT5hcmNoLm1vbml0b3JfdGFibGUpKTsK
PiAgICAgIH0KPiAgICAgIGVsc2UgLy8gbm90IHNoYWRvd19tb2RlX2V4dGVybmFsLi4uCj4gICAg
ICB7Cj4gQEAgLTQyODcsNyArNDI4Nyw3IEBAIHNoX3VwZGF0ZV9jcjMoc3RydWN0IHZjcHUgKnYs
IGludCBkb19sb2NraW5nKQo+ICAgICAgICAgIHYtPmFyY2guY3IzID0gdmlydF90b19tYWRkcigm
di0+YXJjaC5wYWdpbmcuc2hhZG93LmwzdGFibGUpOwo+ICAjZWxzZQo+ICAgICAgICAgIC8qIDQt
b24tNDogSnVzdCB1c2UgdGhlIHNoYWRvdyB0b3AtbGV2ZWwgZGlyZWN0bHkgKi8KPiAtICAgICAg
ICBtYWtlX2NyMyh2LCBwYWdldGFibGVfZ2V0X3Bmbih2LT5hcmNoLnNoYWRvd190YWJsZVswXSkp
Owo+ICsgICAgICAgIG1ha2VfY3IzKHYsIHBhZ2V0YWJsZV9nZXRfbWZuKHYtPmFyY2guc2hhZG93
X3RhYmxlWzBdKSk7Cj4gICNlbmRpZgo+ICAgICAgfQo+Cj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNs
dWRlL2FzbS14ODYvbW0uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvbW0uaAo+IGluZGV4IDRjMDNh
MzMuLmRjZTNmMTYgMTAwNjQ0Cj4gLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9tbS5oCj4gKysr
IGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9tbS5oCj4gQEAgLTU0MCw3ICs1NDAsNyBAQCB2b2lkIGF1
ZGl0X2RvbWFpbnModm9pZCk7Cj4gICNlbmRpZgo+Cj4gIGludCBuZXdfZ3Vlc3RfY3IzKG1mbl90
IG1mbik7Cj4gLXZvaWQgbWFrZV9jcjMoc3RydWN0IHZjcHUgKnYsIHVuc2lnbmVkIGxvbmcgbWZu
KTsKPiArdm9pZCBtYWtlX2NyMyhzdHJ1Y3QgdmNwdSAqdiwgbWZuX3QgbWZuKTsKPiAgdm9pZCB1
cGRhdGVfY3IzKHN0cnVjdCB2Y3B1ICp2KTsKPiAgaW50IHZjcHVfZGVzdHJveV9wYWdldGFibGVz
KHN0cnVjdCB2Y3B1ICopOwo+ICB2b2lkICpkb19wYWdlX3dhbGsoc3RydWN0IHZjcHUgKnYsIHVu
c2lnbmVkIGxvbmcgYWRkcik7Cj4gLS0KPiAyLjEuNAo+Cj4KPiBfX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IFhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKPiBY
ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwo+IGh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK
Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZl
bCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4u
b3JnL3hlbi1kZXZlbAo=