From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751290AbdGQDJd (ORCPT ); Sun, 16 Jul 2017 23:09:33 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:36567 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245AbdGQDJb (ORCPT ); Sun, 16 Jul 2017 23:09:31 -0400 MIME-Version: 1.0 In-Reply-To: <3257165.sao50mFgxX@avalon> References: <1500101920-24039-1-git-send-email-jacob-chen@iotwrt.com> <2238838.k7NpPUxaC0@avalon> <3257165.sao50mFgxX@avalon> From: Jacob Chen Date: Mon, 17 Jul 2017 11:09:30 +0800 Message-ID: Subject: Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices To: Laurent Pinchart Cc: "open list:ARM/Rockchip SoC..." , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Heiko Stuebner , robh+dt@kernel.org, Mauro Carvalho Chehab , Linux Media Mailing List , laurent.pinchart+renesas@ideasonboard.com, Hans Verkuil , s.nawrocki@samsung.com, Tomasz Figa , Nicolas Dufresne Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent, 2017-07-17 10:28 GMT+08:00 Laurent Pinchart : > Hi Jacob, > > On Sunday 16 Jul 2017 12:23:02 Jacob Chen wrote: >> 2017-07-15 17:16 GMT+08:00 Laurent Pinchart: >> > On Saturday 15 Jul 2017 14:58:39 Jacob Chen wrote: >> >> Signed-off-by: Jacob Chen >> >> --- >> >> >> >> arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++ >> >> arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 4 ++++ >> >> arch/arm/boot/dts/rk3288-firefly.dtsi | 4 ++++ >> >> arch/arm/boot/dts/rk3288-miqi.dts | 4 ++++ >> >> arch/arm/boot/dts/rk3288-popmetal.dts | 4 ++++ >> >> arch/arm/boot/dts/rk3288-tinker.dts | 4 ++++ >> > >> > Some boards are missing from this list (Fennec, Phycore, ...) What >> > criteria have you used to decide on which ones to enable the RGA ? That >> > should be explained in the commit message. >> >> Ok. >> >> I just enable the boards i have tested, because i can't make sure it >> won't break the other board because of clocks or power-domains. > > Given the clocks and power domains shouldn't be board-specific, would it make > sense to try and get the change tested on the remaining boards ? You could Not all drivers have handle power domains and clocks appropriately, It may triggers bugs, but since it's a V4l2 driver not DRM driver, i will enable it for all rk3288 boards. (DRM device will try to probe in very eraly stage and update clocks/power-domains...) > then enable the device in the SoC .dtsi file, which would be much simpler. > We have many different version RGA drivers in rockchip downstream kernel. To keep consistent, i didn't enable it in .dtsi. >> >> 6 files changed, 24 insertions(+) > > -- > Regards, > > Laurent Pinchart > From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacobchen110@gmail.com (Jacob Chen) Date: Mon, 17 Jul 2017 11:09:30 +0800 Subject: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices In-Reply-To: <3257165.sao50mFgxX@avalon> References: <1500101920-24039-1-git-send-email-jacob-chen@iotwrt.com> <2238838.k7NpPUxaC0@avalon> <3257165.sao50mFgxX@avalon> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Laurent, 2017-07-17 10:28 GMT+08:00 Laurent Pinchart : > Hi Jacob, > > On Sunday 16 Jul 2017 12:23:02 Jacob Chen wrote: >> 2017-07-15 17:16 GMT+08:00 Laurent Pinchart: >> > On Saturday 15 Jul 2017 14:58:39 Jacob Chen wrote: >> >> Signed-off-by: Jacob Chen >> >> --- >> >> >> >> arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++ >> >> arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 4 ++++ >> >> arch/arm/boot/dts/rk3288-firefly.dtsi | 4 ++++ >> >> arch/arm/boot/dts/rk3288-miqi.dts | 4 ++++ >> >> arch/arm/boot/dts/rk3288-popmetal.dts | 4 ++++ >> >> arch/arm/boot/dts/rk3288-tinker.dts | 4 ++++ >> > >> > Some boards are missing from this list (Fennec, Phycore, ...) What >> > criteria have you used to decide on which ones to enable the RGA ? That >> > should be explained in the commit message. >> >> Ok. >> >> I just enable the boards i have tested, because i can't make sure it >> won't break the other board because of clocks or power-domains. > > Given the clocks and power domains shouldn't be board-specific, would it make > sense to try and get the change tested on the remaining boards ? You could Not all drivers have handle power domains and clocks appropriately, It may triggers bugs, but since it's a V4l2 driver not DRM driver, i will enable it for all rk3288 boards. (DRM device will try to probe in very eraly stage and update clocks/power-domains...) > then enable the device in the SoC .dtsi file, which would be much simpler. > We have many different version RGA drivers in rockchip downstream kernel. To keep consistent, i didn't enable it in .dtsi. >> >> 6 files changed, 24 insertions(+) > > -- > Regards, > > Laurent Pinchart >