From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75FCDC48BCD for ; Wed, 9 Jun 2021 22:39:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B5FD613E3 for ; Wed, 9 Jun 2021 22:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbhFIWlW (ORCPT ); Wed, 9 Jun 2021 18:41:22 -0400 Received: from mail-ot1-f54.google.com ([209.85.210.54]:35633 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbhFIWlV (ORCPT ); Wed, 9 Jun 2021 18:41:21 -0400 Received: by mail-ot1-f54.google.com with SMTP id 69-20020a9d0a4b0000b02902ed42f141e1so25610069otg.2; Wed, 09 Jun 2021 15:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NEWuD8KXuieZNHBEBcl8+ntcsvKKDdZFLRqcg/Uf4wc=; b=LC7r8Vi5ior1sFSrmmZ6W06JrVOPSy1zZ9oo3gOqS5RwBMOo2g9UBRPSVi49zw0NNj 6E6bUVc5r7fY27aRN8vt+5nVcSEcoJvAg+CXS6uwzm4sB7HBcuEt7nr91rERIZmh985v 3ny9L6vOdHrlVa+U2T94zEDUTWX/q7B3NvgSq5CmrijQDvzRXgjkX13/O/oluT6RCeEw IlCQPguE1v71Y5Vb4HJP9fC/MOjcHd2TBU/nys0mfQ/DuPjP1yKOcDyHqcBc7dcjVR2a HARSayC0diheUyWwn6V/Dt+9Idc3dDeeRm2YFLQR4q8JZKH2Rq2CcOMeKJut1bGrx4jX lO1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NEWuD8KXuieZNHBEBcl8+ntcsvKKDdZFLRqcg/Uf4wc=; b=DNb2uNaQYOtpBe/C5C9miZHN/RnujQHGIaU6i5Ld7NUxwP76LXMWat+U8Oi/isnHrI jyqW2Cc6ps+U6dJCt2tbyxIkIly2VNlSql9A9ZH/ZnopiEbTAUUlDaGE7sFk78h/qMkZ VMCzC7UguN4pdwo1GUwl39Jjir8CnjK0Gh4WktrGMyLoDC2kYjUKejC8YqXna4mU1TAD eR6jFg2M0SPRlGCiR78CVSE3tGuRgLTjrMH8thoLR4weV5gN1069wdeFw62DKzD7lS8w 7P42/NYvMAHo0BFAx0BDBYUs2DSKckA8bAJJayOn8dqmb+sxYzWI2R6bsyUeLzISGPdB zzHw== X-Gm-Message-State: AOAM530zBQ7j6vyjGolveVUUPcQohq/DZwejdQTGvcEXnz2KYfaaUfDE udtF4iKLYA+p5u8U+T66nRz9OmjGrpDSpSuPjCQ= X-Google-Smtp-Source: ABdhPJyrYomschLlY7NnQiYeA+IcoOJnYUDbrD9PXecbJXbM9PpdrvFT9tbv7POCa6Xtfnekz8x42ExeQTc74yt7uho= X-Received: by 2002:a05:6830:1d0:: with SMTP id r16mr1476662ota.116.1623278290263; Wed, 09 Jun 2021 15:38:10 -0700 (PDT) MIME-Version: 1.0 References: <20210609173312.298414-1-colin.king@canonical.com> In-Reply-To: <20210609173312.298414-1-colin.king@canonical.com> From: Daniel Scally Date: Wed, 9 Jun 2021 22:38:04 +0100 Message-ID: Subject: Re: [PATCH][next] ACPI: scan: ensure ret is initialized to avoid garbage being returned To: Colin King Cc: "Rafael J . Wysocki" , Len Brown , Maximilian Luz , Andy Shevchenko , ACPI Devel Maling List , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Colin On Wed, Jun 9, 2021 at 6:33 PM Colin King wrote: > > From: Colin Ian King > > In the unlikely event that there are no callback calls made then ret > will be returned as an uninitialized value. Clean up static analysis > warnings by ensuring ret is initialized. Ah, thanks - good spot. > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: a9e10e587304 ("ACPI: scan: Extend acpi_walk_dep_device_list()") > Signed-off-by: Colin Ian King Reviewed-by: Daniel Scally I'm still bad at Git; will the commit hash here be right, since the patch that this fixes isn't upstream yet? (hope the gmail web client doesn't maul this too badly...) > --- > drivers/acpi/scan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index c3067e8bfc47..0945d952f0fc 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -2151,7 +2151,7 @@ int acpi_walk_dep_device_list(acpi_handle handle, > void *data) > { > struct acpi_dep_data *dep, *tmp; > - int ret; > + int ret = 0; > > mutex_lock(&acpi_dep_list_lock); > list_for_each_entry_safe(dep, tmp, &acpi_dep_list, node) { > -- > 2.31.1 >