Thank you for the suggestions and support, both of you. I realize that 75 patches is a lot, but the majority of them are all a part of one change set: fixing the structures in the driver as suggested by Greg KH in response to other patches I sent in. He asked me to do them all separately, so that's why there's so many. Dan, I see you've found some small issues with some of the patches that I missed; I will ammend those when I get the chance and send a v3 series with a cover letter. However, I am about to get on a 8hrs of flights so I'm not sure when that will be. Thank you, Quytelda Kahja On Mon, Apr 2, 2018, 07:57 Joe Perches wrote: > On Mon, 2018-04-02 at 14:45 +0300, Dan Carpenter wrote: > > On Sat, Mar 31, 2018 at 07:12:53AM -0700, Joe Perches wrote: > > > On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote: > > > > On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > > > > > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > > > > > > This macro, provided in 'linux/kernel.h', will calculate the size > > > > > > more succinctly than a division operation. > > > > > > > > > > It's nice that you send patches, but please try to send a > > > > > cover letter with your patch series. > > > > > > > > > > > > > There are obviously times when a cover letter is required but what's > the > > > > point of that for this particular series? > > > > > > practice > > > > > It really pisses me off to see patch submitters get assign busy work > > for no reason. This is not school and these are not your students. > > Please take a chill pill Dan. > I think cover letters are best practice. > >