From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753484AbcCZR6o (ORCPT ); Sat, 26 Mar 2016 13:58:44 -0400 Received: from mail-ob0-f193.google.com ([209.85.214.193]:35156 "EHLO mail-ob0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752594AbcCZR6m (ORCPT ); Sat, 26 Mar 2016 13:58:42 -0400 MIME-Version: 1.0 In-Reply-To: <1452402833-8652-10-git-send-email-peter@hurleysoftware.com> References: <1448677557-16420-1-git-send-email-peter@hurleysoftware.com> <1452402833-8652-1-git-send-email-peter@hurleysoftware.com> <1452402833-8652-10-git-send-email-peter@hurleysoftware.com> Date: Sat, 26 Mar 2016 18:58:41 +0100 Message-ID: Subject: Re: [PATCH v2 09/10] tty: Consolidate noctty checks in tty_open() From: Richard Weinberger To: Peter Hurley Cc: Greg Kroah-Hartman , Jiri Slaby , LKML , "user-mode-linux-devel@lists.sourceforge.net" , Linus Torvalds , One Thousand Gnomes Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 10, 2016 at 6:13 AM, Peter Hurley wrote: > Evaluate the conditions which prevent this tty being the controlling > terminal in one place, just before setting the controlling terminal. > > Signed-off-by: Peter Hurley > --- > drivers/tty/tty_io.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) Peter, This commit breaks existing userspace. I noticed that on UserModeLinux with Debian Squeeze as userspace, getty does not give me a controlling tty upon login. It does not seem to happen on newer distros. But still this needs further investigation. Please me know what debug information you need. -- Thanks, //richard