From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bHded-00062o-AP for linux-mtd@lists.infradead.org; Mon, 27 Jun 2016 21:01:16 +0000 Received: by mail-oi0-x244.google.com with SMTP id w141so32923843oia.0 for ; Mon, 27 Jun 2016 14:00:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1465726706-12630-1-git-send-email-dev@kresin.me> References: <1465726706-12630-1-git-send-email-dev@kresin.me> From: Richard Weinberger Date: Mon, 27 Jun 2016 23:00:53 +0200 Message-ID: Subject: Re: [PATCH] mtd: nandsim: use the existing output macros To: Mathias Kresin Cc: "linux-mtd@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Jun 12, 2016 at 12:18 PM, Mathias Kresin wrote: > Without using the output macros, it isn't possible to suppress these > messages on the console by specifying an appropriate console log level. > > Signed-off-by: Mathias Kresin > --- > drivers/mtd/nand/nandsim.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/mtd/nand/nandsim.c b/drivers/mtd/nand/nandsim.c > index 1eb9344..3cfcc5e 100644 > --- a/drivers/mtd/nand/nandsim.c > +++ b/drivers/mtd/nand/nandsim.c > @@ -769,22 +769,22 @@ static int __init init_nandsim(struct mtd_info *mtd) > if (ns->busw == 16) > NS_WARN("16-bit flashes support wasn't tested\n"); > > - printk("flash size: %llu MiB\n", > + NS_INFO("flash size: %llu MiB\n", > (unsigned long long)ns->geom.totsz >> 20); > - printk("page size: %u bytes\n", ns->geom.pgsz); > - printk("OOB area size: %u bytes\n", ns->geom.oobsz); > - printk("sector size: %u KiB\n", ns->geom.secsz >> 10); > - printk("pages number: %u\n", ns->geom.pgnum); > - printk("pages per sector: %u\n", ns->geom.pgsec); > - printk("bus width: %u\n", ns->busw); > - printk("bits in sector size: %u\n", ns->geom.secshift); > - printk("bits in page size: %u\n", ns->geom.pgshift); > - printk("bits in OOB size: %u\n", ffs(ns->geom.oobsz) - 1); > - printk("flash size with OOB: %llu KiB\n", > + NS_INFO("page size: %u bytes\n", ns->geom.pgsz); > + NS_INFO("OOB area size: %u bytes\n", ns->geom.oobsz); > + NS_INFO("sector size: %u KiB\n", ns->geom.secsz >> 10); > + NS_INFO("pages number: %u\n", ns->geom.pgnum); > + NS_INFO("pages per sector: %u\n", ns->geom.pgsec); > + NS_INFO("bus width: %u\n", ns->busw); > + NS_INFO("bits in sector size: %u\n", ns->geom.secshift); > + NS_INFO("bits in page size: %u\n", ns->geom.pgshift); > + NS_INFO("bits in OOB size: %u\n", ffs(ns->geom.oobsz) - 1); > + NS_INFO("flash size with OOB: %llu KiB\n", > (unsigned long long)ns->geom.totszoob >> 10); > - printk("page address bytes: %u\n", ns->geom.pgaddrbytes); > - printk("sector address bytes: %u\n", ns->geom.secaddrbytes); > - printk("options: %#x\n", ns->options); > + NS_INFO("page address bytes: %u\n", ns->geom.pgaddrbytes); > + NS_INFO("sector address bytes: %u\n", ns->geom.secaddrbytes); > + NS_INFO("options: %#x\n", ns->options); Makes sense. I'll carry this since I'm doing a bigger nandsim facelift. -- Thanks, //richard