From: Richard Weinberger <richard.weinberger@gmail.com>
To: Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
Cc: bbrezillon@kernel.org, Richard Weinberger <richard@nod.at>,
Brandon Maier <brandon.maier@rockwellcollins.com>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 2/2] jffs2: Add sync to underlying mtd device when file system is synced
Date: Mon, 6 May 2019 00:22:38 +0200 [thread overview]
Message-ID: <CAFLxGvxgQb1iCTdHbFWz6VmMU1mjnGOadkHtLvA68Jaa0BS=bg@mail.gmail.com> (raw)
In-Reply-To: <1556914418-40288-2-git-send-email-clayton.shotwell@rockwellcollins.com>
On Fri, May 3, 2019 at 10:14 PM Clayton Shotwell
<clayton.shotwell@rockwellcollins.com> wrote:
>
> Need to ensure the underlying flash does not cache anything even though
> the file system thinks it's synced back.
>
> Signed-off-by: Clayton Shotwell <clayton.shotwell@rockwellcollins.com>
> ---
> fs/jffs2/super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
> index 05d892c..4341565 100644
> --- a/fs/jffs2/super.c
> +++ b/fs/jffs2/super.c
> @@ -111,6 +111,7 @@ static int jffs2_sync_fs(struct super_block *sb, int wait)
> mutex_lock(&c->alloc_sem);
> jffs2_flush_wbuf_pad(c);
> mutex_unlock(&c->alloc_sem);
> + mtd_sync(c->mtd);
This needs a more detailed explanation.
mtd_sync() is not cheap, so you make syncfs() more expensive.
Please explain what failure you are facing without mtd_sync().
jffs2 is supposed to recover from a power failure at any time, just like ubifs.
--
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-05-05 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 20:13 [PATCH 1/2] mtd: gluebi: Add sync logic Clayton Shotwell
2019-05-03 20:13 ` [PATCH 2/2] jffs2: Add sync to underlying mtd device when file system is synced Clayton Shotwell
2019-05-05 22:22 ` Richard Weinberger [this message]
2019-05-16 11:04 ` Richard Weinberger
2019-05-16 15:12 ` Brandon Maier
2019-05-16 15:31 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLxGvxgQb1iCTdHbFWz6VmMU1mjnGOadkHtLvA68Jaa0BS=bg@mail.gmail.com' \
--to=richard.weinberger@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=brandon.maier@rockwellcollins.com \
--cc=clayton.shotwell@rockwellcollins.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.