From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D636C433E0 for ; Sun, 24 May 2020 21:37:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5227F204EF for ; Sun, 24 May 2020 21:37:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="suCVB2Oy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ooosN1a9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5227F204EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e1C9acxXgGp4VJ3ayA7W7+aIUJM610xh2oX4eYqsPEE=; b=suCVB2OyvGkr/f gniyOxYHZklUkDUnZUbEdFC3ub59zH10sCgJ5SFB+oQSRHNmzQwZs2hkQrY648Pt9J44Cc/yGzAmC 4pdkJ6GaIgo867dVZrdAClMKUYy5p/vqCzmvjggHTe96ysjAuLE4QdBkolMfg1Xm0yAyNt4olSfEp ujkdmkeZcMljYW56K+gmbCwXTE5sGh+ipPZRg6q+bIOSQAPkU3/wcmmvbTl8fO9nIqIF4/JZrikEn SCyLy2DWuNInpY3/QzdulQufGISGy1kraI40VnyQin42uo3XiY4X5DgPe73iR+2lm+w7QNNwQncfr gK6uGRVhA3q75umtN+gA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcyJG-0005RE-SP; Sun, 24 May 2020 21:37:30 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcyJE-0005Qh-AZ for linux-mtd@lists.infradead.org; Sun, 24 May 2020 21:37:29 +0000 Received: by mail-qt1-x843.google.com with SMTP id a23so12631366qto.1 for ; Sun, 24 May 2020 14:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cPqEORj2aZiuNCYLTIhgC5NbG10KitnTK1sIy1C9g2c=; b=ooosN1a92ljS60e3xUm07BGZAQKJb2vDWhcgWbUXxcz9NLmgoI538k1XN/Gcg9MQYs q+OY0C+nfcwGzlAocqMhca6Dj354Q+rTrNT0z+qYtZge1Pl918FOGSQirDJmhE2CFBnC nDjo0xfdhw1tvom9kw5FPcEaDObhSMw/dTVZqjCeOvSxI+f4U3Hn6omqPW5WN9G3veUZ UnHHj3VdO72WfQBxabgy4sJ8bv4qOT7ptGKrmGKYt/MKIX4j6dNq8o67tcYJibXqi50M 3I+nRiRrmVDHmPoW84oo2S0SB9q89nsBKQPniVayrSlmnsIZmtwnorCJjcmVuty1XFWK +TPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cPqEORj2aZiuNCYLTIhgC5NbG10KitnTK1sIy1C9g2c=; b=BPVP351Zo+10yrqB/jaSntX6BO3MYh/Ui3ty/opTDLnAbUpERLQIkSgcChBbN6CP7K BBepeRShsX+xhUPwA4w5aNYDZ4yKp50hEtqOqsQMkWcbJTPETb5XA4O9IYUKPYBRiOTh Ohr2wkcyhdC/rz59qgM0hsG6T+5ngMJLoBUMVYI2OpCVsY4/mhFwZMkQpUKsuz5loeaO s4JlDHVpusb6WPz1YE+AElcj5/0For8GmziMK75YVhoCtI1eWxaAoJ9NVQuyecxO58r4 wkrHCWt42kZd+R29fF3brjo/Lu/a3mEIQPVoyC2jhfU/YUWOGrMz7HJfl7Xz+dAUAB1S AdPQ== X-Gm-Message-State: AOAM5314gvdjmB1HY+jstzLifAlSifJMfQTnVpJ9du860xM4TlBXl8cW TV54Rf4F6LatihQqA+c59EMGzcpNtFfTSta3saQ= X-Google-Smtp-Source: ABdhPJxqlP2qq1jPoDsgGTNUm4DAUWSw35Y/t3k4WUAbjcUuoAeAqhL2ui+8oD+4Uup0FgVAbUvfI0es53TyZRXIVyI= X-Received: by 2002:ac8:3f88:: with SMTP id d8mr1643183qtk.164.1590356244593; Sun, 24 May 2020 14:37:24 -0700 (PDT) MIME-Version: 1.0 References: <20200509191431.15862-1-miquel.raynal@bootlin.com> <20200509191431.15862-18-miquel.raynal@bootlin.com> In-Reply-To: <20200509191431.15862-18-miquel.raynal@bootlin.com> From: Richard Weinberger Date: Sun, 24 May 2020 23:37:13 +0200 Message-ID: Subject: Re: [PATCH 17/17] mtd: rawnand: nandsim: Reorganize ns_cleanup_module() To: Miquel Raynal X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200524_143728_381829_93647947 X-CRM114-Status: UNSURE ( 7.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , dedekind@infradead.org, Richard Weinberger , Boris Brezillon , linux-mtd@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Sat, May 9, 2020 at 9:19 PM Miquel Raynal wrote: > ns_debugfs_remove(ns); > - ns_free(ns); /* Free nandsim private resources */ > - nand_release(chip); /* Unregister driver */ > - kfree(ns); /* Free other structures */ > - ns_free_lists(); > + WARN_ON(mtd_device_unregister(nsmtd)); > + ns_free(ns); > + kfree(erase_block_wear); > + nand_cleanup(chip); > + list_for_each_safe(pos, n, &grave_pages) { > + kfree(list_entry(pos, struct grave_page, list)); > + list_del(pos); Are you sure you can use pos after freeing the entry? Smells like use after free. -- Thanks, //richard ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/