From: Richard Weinberger <richard.weinberger@gmail.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: linux-fscrypt@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] fscrypt: remove fscrypt_symlink_data_len()
Date: Thu, 6 Apr 2017 21:22:35 +0200 [thread overview]
Message-ID: <CAFLxGvzWALC5L7hKLVb7s17VuFeO5V509aoPC5gMtb7X64-47w@mail.gmail.com> (raw)
In-Reply-To: <20170404214334.113915-1-ebiggers3@gmail.com>
On Tue, Apr 4, 2017 at 11:43 PM, Eric Biggers <ebiggers3@gmail.com> wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> fscrypt_symlink_data_len() is never called and can be removed.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> include/linux/fscrypt_common.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/include/linux/fscrypt_common.h b/include/linux/fscrypt_common.h
> index 10c1abfbac6c..0a30c106c1e5 100644
> --- a/include/linux/fscrypt_common.h
> +++ b/include/linux/fscrypt_common.h
> @@ -46,17 +46,6 @@ struct fscrypt_symlink_data {
> char encrypted_path[1];
> } __packed;
>
> -/**
> - * This function is used to calculate the disk space required to
> - * store a filename of length l in encrypted symlink format.
> - */
> -static inline u32 fscrypt_symlink_data_len(u32 l)
> -{
> - if (l < FS_CRYPTO_BLOCK_SIZE)
> - l = FS_CRYPTO_BLOCK_SIZE;
> - return (l + sizeof(struct fscrypt_symlink_data) - 1);
> -}
> -
Reviewed-by: Richard Weinberger <richard@nod.at>
--
Thanks,
//richard
next prev parent reply other threads:[~2017-04-06 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 21:43 [PATCH] fscrypt: remove fscrypt_symlink_data_len() Eric Biggers
2017-04-06 19:22 ` Richard Weinberger [this message]
2017-04-30 6:16 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFLxGvzWALC5L7hKLVb7s17VuFeO5V509aoPC5gMtb7X64-47w@mail.gmail.com \
--to=richard.weinberger@gmail.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.