From mboxrd@z Thu Jan  1 00:00:00 1970
From: Asias He <asias.hejun@gmail.com>
Subject: Re: [PATCH v2 1/2] kvm tools: Fix VHOST_SET_MEM_TABLE failure
Date: Thu, 12 Jul 2012 10:46:00 +0800
Message-ID: <CAFO3S42H7VWhpYYct8iNqEwBxcXsCS=p9Dvd6mgjV5cZJU1vag@mail.gmail.com>
References: <1342022894-1034-1-git-send-email-asias.hejun@gmail.com> <4FFDA543.2030304@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: Pekka Enberg <penberg@kernel.org>,
	Sasha Levin <levinsasha928@gmail.com>,
	Ingo Molnar <mingo@elte.hu>,
	Cyrill Gorcunov <gorcunov@gmail.com>, kvm@vger.kernel.org,
	"Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-pb0-f46.google.com ([209.85.160.46]:34502 "EHLO
	mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756560Ab2GLCql (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 11 Jul 2012 22:46:41 -0400
Received: by pbbrp8 with SMTP id rp8so2968502pbb.19
        for <kvm@vger.kernel.org>; Wed, 11 Jul 2012 19:46:41 -0700 (PDT)
In-Reply-To: <4FFDA543.2030304@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Jul 12, 2012 at 12:09 AM, Avi Kivity <avi@redhat.com> wrote:
> On 07/11/2012 07:08 PM, Asias He wrote:
>> VHOST_SET_MEM_TABLE failed: Operation not supported
>>
>> In vhost_set_memory(), We have
>>
>>         if (mem.padding)
>>                 return -EOPNOTSUPP;
>>
>> So, we need to zero struct vhost_memory.
>>
>
> Is this due to a change in vhost?

Seems we have this bit in the very beginning (commit 3a4d5c94).

-- 
Asias He