All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Packham <judge.packham@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] T2080 l2-cache-controller compatible string overwritten by ft_fixup_l2cache
Date: Wed, 23 Nov 2016 22:43:03 +1300	[thread overview]
Message-ID: <CAFOYHZA7rpWO+8iM5Lf+=JVGKHArvghHBp9dHPk1=89ywxZwXw@mail.gmail.com> (raw)

Hi,

I was just looking at what it would take to add the T2080 L2 cache to
the mpc85xx_edac driver in Linux. At a cursory glance all the
registers appear to be there so I figured I'd just add the appropriate
entry to the of match table.

To my surprise I found that the compatible string in my device tree
was overwritten with "cache". I've tracked this down to the
CONFIG_SYS_FSL_QORIQ_CHASSIS2 implementation of ft_fixup_l2cache in
u-boot.

The CONFIG_L2_CACHE version seems to take care to update the device tree node to

  compatible = "fsl,t2080-l2-cache-controller", "cache";

but the CONFIG_SYS_FSL_QORIQ_CHASSIS2 version just sets this to

  compatible = "cache";

Is this an over-site or is it intentional?

Thanks,
Chris

             reply	other threads:[~2016-11-23  9:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23  9:43 Chris Packham [this message]
2016-11-23 17:41 ` [U-Boot] T2080 l2-cache-controller compatible string overwritten by ft_fixup_l2cache york sun
2016-11-28 23:52   ` [U-Boot] [PATCH] arch: powerpc: Retain compatible property for L2 cache Chris Packham
2016-11-29  3:10   ` [U-Boot] [PATCH] " Chris Packham
2016-11-30 17:18     ` york sun
2016-12-01  7:47       ` Chris Packham
2016-12-01 17:34         ` york sun
     [not found]           ` <CAFOYHZA7ycTE3rTQJiAgBBVBUFW9_QemAcCra33VnfGiWn0Arg@mail.gmail.com>
     [not found]             ` <CAFOYHZD5JrrC=d9-kZd6tLiZHynJFjS3AtbkaPS9b9Pfy-s5hQ@mail.gmail.com>
2016-12-02  7:35               ` Chris Packham
2016-12-02  8:22                 ` [U-Boot] [PATCH v2] " Chris Packham
2016-12-20 17:16                   ` york sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFOYHZA7rpWO+8iM5Lf+=JVGKHArvghHBp9dHPk1=89ywxZwXw@mail.gmail.com' \
    --to=judge.packham@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.