All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Packham <judge.packham@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Commit "arm: kirkwood: configs: dreamplug: Convert to DM_SPI" breaks u-boot on Dreamplug
Date: Thu, 28 Feb 2019 20:41:37 +1300	[thread overview]
Message-ID: <CAFOYHZAmLa0OORd+o7BjDpXWYa+r_VDpF7QaymLSKnzoFFvXTA@mail.gmail.com> (raw)
In-Reply-To: <11b9229a75cd152d8bdf42acfb13ed9d@solinno.co.uk>

Hi Leigh,

On Thu, Feb 28, 2019 at 7:24 AM Leigh Brown <leigh@solinno.co.uk> wrote:
>
> Hello,
>
> Vagrant Cascadian asked for people to test the version of u-boot
> packaged
> for Debian Buster.  I tested u-boot on my Dreamplug and found it was not
> working correctly.  I raised a bug for Debian[1] but I have also tested
> with the mainline version of u-boot and found the same issues.

Thanks for testing. We've been needing more people interested in
keeping Kirkwood going.

>
> This is the second issue that I found, and it causes u-boot to not
> detect
> the SPI flash on the system.  I bisected the issue to the following
> commit:
>
> commit 6aaf76beb131c2ff2b7184c2d63c2c63e5ab339c
> Author: Chris Packham <judge.packham@gmail.com>
> Date:   Wed Nov 21 22:22:23 2018 +1300
>
>      arm: kirkwood: configs: dreamplug: Convert to DM_SPI
>
>      Enable CONFIG_DM_SPI=y and CONFIG_DM_SPI_FLASH=y in the defconfig.
>
>      Signed-off-by: Chris Packham <judge.packham@gmail.com>
>      Reviewed-by: Stefan Roese <sr@denx.de>
>      Signed-off-by: Stefan Roese <sr@denx.de>
>
> The error manifests itself as follows:
>
> U-Boot 2019.01+dfsg-1 (Jan 15 2019 - 00:36:19 +0000)
> Marvell-DreamPlug
>
> SoC:   Kirkwood 88F6281_A1
> DRAM:  512 MiB
> Loading Environment from SPI Flash... Invalid bus 0 (err=-19)
> *** Warning - spi_flash_probe_bus_cs() failed, using default environment
>

I think this may be solved with a simple change to the DTS. I'll
include you on the CC list for a patch shortly. Could you please test
it on your hardware.

> A successful boot looks more like this:
>
> U-Boot 2016.11+dfsg1-4 (Mar 27 2017 - 18:39:51 +0000)
> Marvell-DreamPlug
>
> SoC:   Kirkwood 88F6281_A1
> SPI:   ready
> DRAM:  512 MiB
> WARNING: Caches not enabled
> SF: Detected MX25L1605D with page size 256 Bytes, erase size 64 KiB,
> total 2 MiB
>
> Unfortunately, I don't know where to start to diagnose the issue.  Could
> anyone provide any pointers?  Happy to test any suggestions.
>
> Regards,
>
> Leigh.
>
> --
> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=923379

      reply	other threads:[~2019-02-28  7:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-27 18:24 [U-Boot] Commit "arm: kirkwood: configs: dreamplug: Convert to DM_SPI" breaks u-boot on Dreamplug Leigh Brown
2019-02-28  7:41 ` Chris Packham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFOYHZAmLa0OORd+o7BjDpXWYa+r_VDpF7QaymLSKnzoFFvXTA@mail.gmail.com \
    --to=judge.packham@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.