All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Packham <judge.packham@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH v1] Makefile: Add U_BOOT_TZ and include in version
Date: Wed, 6 May 2015 17:38:15 +1200	[thread overview]
Message-ID: <CAFOYHZAqUHEuWLF-M39+zTV8K8fjD3TeyUeka8+VCffuj3ycKw@mail.gmail.com> (raw)
In-Reply-To: <1430354303-30200-2-git-send-email-judge.packham@gmail.com>

Hi,

On Thu, Apr 30, 2015 at 12:38 PM, Chris Packham <judge.packham@gmail.com> wrote:
> Define U_BOOT_TZ alongside U_BOOT_TIME and U_BOOT_DATE and use it to
> include the timezone in the version output.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
>
>  Makefile          | 3 ++-
>  include/version.h | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 1e52008..c6b8d3f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1230,7 +1230,8 @@ endef
>
>  define filechk_timestamp.h
>         (LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"'; \
> -       LC_ALL=C date +'#define U_BOOT_TIME "%T"')
> +       LC_ALL=C date +'#define U_BOOT_TIME "%T"'; \
> +       LC_ALL=C date +'#define U_BOOT_TZ "%Z"')
>  endef
>
>  $(version_h): include/config/uboot.release FORCE
> diff --git a/include/version.h b/include/version.h
> index d6c7cf2..777e9f6 100644
> --- a/include/version.h
> +++ b/include/version.h
> @@ -19,7 +19,7 @@
>  #endif
>
>  #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " \
> -       U_BOOT_TIME ")" CONFIG_IDENT_STRING
> +       U_BOOT_TIME " " U_BOOT_TZ ")" CONFIG_IDENT_STRING
>
>  #ifndef __ASSEMBLY__
>  extern const char version_string[];
> --
> 2.3.5
>

Any feedback? I see I've now missed the merge window (sending the
patch as RFC on the day before it closed didn't help, sorry about
that). But is the general idea OK for when I re-submit when the next
merge window opens?

Thanks,
Chris

  reply	other threads:[~2015-05-06  5:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30  0:38 [U-Boot] [RFC PATCH v1 0/1] Include timezone information in build Chris Packham
2015-04-30  0:38 ` [U-Boot] [RFC PATCH v1] Makefile: Add U_BOOT_TZ and include in version Chris Packham
2015-05-06  5:38   ` Chris Packham [this message]
2015-05-06 15:01     ` Simon Glass
2015-05-10  9:02   ` [U-Boot] [PATCH v2] " Chris Packham
2015-05-28 13:23     ` [U-Boot] [U-Boot, " Tom Rini
2015-05-08 21:05 ` [U-Boot] [RFC PATCH v1 0/1] Include timezone information in build Tom Rini
2015-05-10  9:28   ` Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFOYHZAqUHEuWLF-M39+zTV8K8fjD3TeyUeka8+VCffuj3ycKw@mail.gmail.com \
    --to=judge.packham@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.