[PATCH] arm: iproc: Add higher speed configurations

[PATCH] arm: iproc: Add higher speed configurations

[Chris Packham]

Add support for 1.3GHz, 1.35GHz and 1.4GHz parts. This is based on
equivalent code in Broadcom's LDK 5.0.6.

Signed-off-by: Chris Packham <judge.packham@gmail.com>

---
As Broadcom are currently migrating users to the BCM58525BB1KF14G part
I suspect others may want this. In our case because we wanted to still
run at 1.2GHz we also had to set CONFIG_ARMCLK to 1200.

 arch/arm/cpu/armv7/iproc-common/armpll.c | 29 +++++++++++++-----------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/arch/arm/cpu/armv7/iproc-common/armpll.c b/arch/arm/cpu/armv7/iproc-common/armpll.c
index efa3d9e5a9bd..8c3a323f0654 100644
--- a/arch/arm/cpu/armv7/iproc-common/armpll.c
+++ b/arch/arm/cpu/armv7/iproc-common/armpll.c
@@ -19,19 +19,22 @@ struct armpll_parameters {
 };
 
 struct armpll_parameters armpll_clk_tab[] = {
-	{   25, 64,      1, 1, 0},
-	{  100, 64,      1, 1, 2},
-	{  400, 64,      1, 1, 6},
-	{  448, 71, 713050, 1, 6},
-	{  500, 80,      1, 1, 6},
-	{  560, 89, 629145, 1, 6},
-	{  600, 96,      1, 1, 6},
-	{  800, 64,      1, 1, 7},
-	{  896, 71, 713050, 1, 7},
-	{ 1000, 80,      1, 1, 7},
-	{ 1100, 88,      1, 1, 7},
-	{ 1120, 89, 629145, 1, 7},
-	{ 1200, 96,      1, 1, 7},
+	{   25,  64,      1, 1, 0},
+	{  100,  64,      1, 1, 2},
+	{  400,  64,      1, 1, 6},
+	{  448,  71, 713050, 1, 6},
+	{  500,  80,      1, 1, 6},
+	{  560,  89, 629145, 1, 6},
+	{  600,  96,      1, 1, 6},
+	{  800,  64,      1, 1, 7},
+	{  896,  71, 713050, 1, 7},
+	{ 1000,  80,      1, 1, 7},
+	{ 1100,  88,      1, 1, 7},
+	{ 1120,  89, 629145, 1, 7},
+	{ 1200,  96,      1, 1, 7},
+	{ 1300, 104,      1, 1, 7},
+	{ 1350, 108,      1, 1, 7},
+	{ 1400, 112,      1, 1, 7},
 };
 
 uint32_t armpll_config(uint32_t clkmhz)
-- 
2.31.1

Re: [PATCH] arm: iproc: Add higher speed configurations

[Chris Packham]

On Fri, Jun 4, 2021 at 2:25 PM Chris Packham <judge.packham@gmail.com> wrote:
>
> Add support for 1.3GHz, 1.35GHz and 1.4GHz parts. This is based on
> equivalent code in Broadcom's LDK 5.0.6.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
>

Hi Tom,

This seems to have fallen between the cracks. Are you able to take it
through one of your trees?

> ---
> As Broadcom are currently migrating users to the BCM58525BB1KF14G part
> I suspect others may want this. In our case because we wanted to still
> run at 1.2GHz we also had to set CONFIG_ARMCLK to 1200.
>
>  arch/arm/cpu/armv7/iproc-common/armpll.c | 29 +++++++++++++-----------
>  1 file changed, 16 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/iproc-common/armpll.c b/arch/arm/cpu/armv7/iproc-common/armpll.c
> index efa3d9e5a9bd..8c3a323f0654 100644
> --- a/arch/arm/cpu/armv7/iproc-common/armpll.c
> +++ b/arch/arm/cpu/armv7/iproc-common/armpll.c
> @@ -19,19 +19,22 @@ struct armpll_parameters {
>  };
>
>  struct armpll_parameters armpll_clk_tab[] = {
> -       {   25, 64,      1, 1, 0},
> -       {  100, 64,      1, 1, 2},
> -       {  400, 64,      1, 1, 6},
> -       {  448, 71, 713050, 1, 6},
> -       {  500, 80,      1, 1, 6},
> -       {  560, 89, 629145, 1, 6},
> -       {  600, 96,      1, 1, 6},
> -       {  800, 64,      1, 1, 7},
> -       {  896, 71, 713050, 1, 7},
> -       { 1000, 80,      1, 1, 7},
> -       { 1100, 88,      1, 1, 7},
> -       { 1120, 89, 629145, 1, 7},
> -       { 1200, 96,      1, 1, 7},
> +       {   25,  64,      1, 1, 0},
> +       {  100,  64,      1, 1, 2},
> +       {  400,  64,      1, 1, 6},
> +       {  448,  71, 713050, 1, 6},
> +       {  500,  80,      1, 1, 6},
> +       {  560,  89, 629145, 1, 6},
> +       {  600,  96,      1, 1, 6},
> +       {  800,  64,      1, 1, 7},
> +       {  896,  71, 713050, 1, 7},
> +       { 1000,  80,      1, 1, 7},
> +       { 1100,  88,      1, 1, 7},
> +       { 1120,  89, 629145, 1, 7},
> +       { 1200,  96,      1, 1, 7},
> +       { 1300, 104,      1, 1, 7},
> +       { 1350, 108,      1, 1, 7},
> +       { 1400, 112,      1, 1, 7},
>  };
>
>  uint32_t armpll_config(uint32_t clkmhz)
> --
> 2.31.1
>

Re: [PATCH] arm: iproc: Add higher speed configurations

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

On Thu, Jun 17, 2021 at 02:10:14PM +1200, Chris Packham wrote:

> On Fri, Jun 4, 2021 at 2:25 PM Chris Packham <judge.packham@gmail.com> wrote:
> >
> > Add support for 1.3GHz, 1.35GHz and 1.4GHz parts. This is based on
> > equivalent code in Broadcom's LDK 5.0.6.
> >
> > Signed-off-by: Chris Packham <judge.packham@gmail.com>
> 
> Hi Tom,
> 
> This seems to have fallen between the cracks. Are you able to take it
> through one of your trees?

I can, is this needed for the v2021.07 release?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH] arm: iproc: Add higher speed configurations

[Chris Packham]

On Fri, Jun 18, 2021 at 12:48 AM Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, Jun 17, 2021 at 02:10:14PM +1200, Chris Packham wrote:
>
> > On Fri, Jun 4, 2021 at 2:25 PM Chris Packham <judge.packham@gmail.com> wrote:
> > >
> > > Add support for 1.3GHz, 1.35GHz and 1.4GHz parts. This is based on
> > > equivalent code in Broadcom's LDK 5.0.6.
> > >
> > > Signed-off-by: Chris Packham <judge.packham@gmail.com>
> >
> > Hi Tom,
> >
> > This seems to have fallen between the cracks. Are you able to take it
> > through one of your trees?
>
> I can, is this needed for the v2021.07 release?
>

Personally I'd like to see it in v2021.07 but I understand that we're
well past the merge window and this is not strictly a fix.

Re: [PATCH] arm: iproc: Add higher speed configurations

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

On Fri, Jun 04, 2021 at 02:25:36PM +1200, Chris Packham wrote:

> Add support for 1.3GHz, 1.35GHz and 1.4GHz parts. This is based on
> equivalent code in Broadcom's LDK 5.0.6.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]