From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F3BDC432BE for ; Fri, 27 Aug 2021 02:45:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73A2B61002 for ; Fri, 27 Aug 2021 02:45:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 73A2B61002 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DC1B38321D; Fri, 27 Aug 2021 04:45:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="u/9VpPzi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9A2C98321D; Fri, 27 Aug 2021 04:45:25 +0200 (CEST) Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A3CF283210 for ; Fri, 27 Aug 2021 04:45:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=judge.packham@gmail.com Received: by mail-il1-x135.google.com with SMTP id l10so5554057ilh.8 for ; Thu, 26 Aug 2021 19:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3T6BVNIRELRBLKR8phumaUQxmWxbRB+va+Y/QSQoADM=; b=u/9VpPzikFMIm/wtD2C8JDkY2tUKWLmdb0tGKYAshibFBlGZPaZu8yy7XREvH5PPh4 wdzekg7CISMgi4/KoWvKHeOcmYvKLIYSq9nFJEUBpuuuNl5xLnE78woQMayQKEZNu2dO k3brpzJkP2nIQfXOYkJBqT+R7J2eqBCPynC/NJh5+0B37HgTb/eN0Wh67aJ3KEqlosff gNLlC5JDtpJkq4OVaVl/RpKg6pvWhT7jcv5BfPvQtly8Pd6p6IaLnQGzhEXX5JoWgTe2 5PZgn8lBq8YP2ma0x9N5XqSEh8V7zUflVERy6er5/6rYJnFixxg8yY9xw+zmQwIhi+Ac V0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3T6BVNIRELRBLKR8phumaUQxmWxbRB+va+Y/QSQoADM=; b=EZWp0sl88xWds3lFtir/tCGasPvbgbJeADKnzzeOqiYF4HrwRLEcHQCXmfgbL5OP7K Gs5MgT+weW+1sHTZ9ex9z6UcXPbMQFLOHDMEQhXesC9hpdmUJKHzrDLAFc0o/qq3A01J z2kK/YROlBF9PJCyROLeDL2RDQkjiaCgeXJmUO4wlekh16H2cFOEgphO1iXj0J9F6A6v 32cOYqA44Tl6cM0oPEWfxAmXFlzMnXX762Sn+C62s6ng5oWijfhW4KifIajCI2XjsBtC Pqp8ytM7v7eWqWMuWLiajMVBcqHIeIhRtyZPckg6n1ao7z7ZB0Gez2EFD4rVJgHPBob/ txag== X-Gm-Message-State: AOAM533gHn5d18A7lqg0kxXdMc6/sNPFQ7fuw1DK2r/XVGDYDhAfwDav EdEIrU9lDAtNm87LfCYnF01v/D7++09gJrpVIVA= X-Google-Smtp-Source: ABdhPJze3TPJcHobpkHV9rFhQiqRwd7e1Mu76g4szd/t9k6wHcL122BfQBg9Ng1jMvv1LHvAMzg26Ym/ZXnjRbH/hDc= X-Received: by 2002:a05:6e02:1846:: with SMTP id b6mr5144532ilv.264.1630032319139; Thu, 26 Aug 2021 19:45:19 -0700 (PDT) MIME-Version: 1.0 References: <20210825134634.3959-1-marek.behun@nic.cz> <20210827033912.74fd4d05@thinkpad> In-Reply-To: <20210827033912.74fd4d05@thinkpad> From: Chris Packham Date: Fri, 27 Aug 2021 14:45:07 +1200 Message-ID: Subject: Re: [PATCH u-boot-marvell 00/29] kwboot higher baudrate To: =?UTF-8?B?TWFyZWsgQmVow7pu?= Cc: Stefan Roese , u-boot , =?UTF-8?B?UGF2b2wgUm9ow6Fy?= , Baruch Siach , Dennis Gilmore , Mario Six , Jon Nettleton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Aug 27, 2021 at 1:39 PM Marek Beh=C3=BAn wrote= : > > On Fri, 27 Aug 2021 13:16:25 +1200 > Chris Packham wrote: > > > On Thu, Aug 26, 2021 at 1:46 AM Marek Beh=C3=BAn w= rote: > > > > > > Hello Stefan and others, > > > > > > this series adds support for booting Marvell platforms via UART (thos= e > > > bootable with kwboot) at higher baudrates. > > > > > > Tested on Turris Omnia up to 5.15 MBd, which is 44x faster than > > > 115200 Bd. > > > > > > The user can direct kwboot to use higher baudrate via the -B option. > > > (BTW this option was there before but did not work with the -b option= .) > > > > > > Only the payload part of the KWB image is uploaded at this higher > > > baudrate. The header part is still uploaded at 115200 Bd, since the c= ode > > > that changes baudrate is injected into header as a binary extension. > > > (The payload part makes up majority of the binary, though. On Turris > > > Omnia the payload currently makes ~87%.) > > > > > > The series also contains various other fixes, refactors and improveme= nts > > > of the code, upon which the main change is done. > > > > > > Marek & Pali > > > > What tree/sha is this series based on. I've tried to apply them out of > > patchwork and it fails at "tools: kwbimage: Simplify iteration over > > version 1 optional headers" > > Applies to master and to u-boot-marvell, but you need the 6 > additional patches for kwbimage/kwboot that are on patchwork > but not yet applied to u-boot-marvell: > https://patchwork.ozlabs.org/project/uboot/list/?series=3D257577 > https://patchwork.ozlabs.org/project/uboot/patch/20210817050320.11983-1= -xypron.glpk@gmx.de/ > https://patchwork.ozlabs.org/project/uboot/patch/20210817051158.13283-1= -xypron.glpk@gmx.de/ > > Also some more fixes were yet needed, which I will sent in v2. > > To make it simpler for you I pushed v2 into > https://gitlab.nic.cz/turris/turris-omnia-uboot > branch > kwboot-baudrate-improvements > Thanks. I took it for a spin on the x530. In terms of regression testing the default behaviour is good. The higher speed settings weren't so good. I started with 3125000 and that doesn't get onto the 2nd part of the download, same for 1152000 and 4000000 (I stopped trying higher speeds at that point). Using 230400 and 460800 it does make it through the 2nd part of the download but when I go back on to the console it appears to be unresponsive. All of this could be down to the serial hardware in my system (the x530 uses a real RS232 interface not a TTL) and I have had problems with the MosChip USB-Serial adapter in my test PC in the past. I wouldn't reject this series based on me not being able to get it working, the important thing for me is the default behaviour at the standard baudrate which is good. One usability thing I'd like to see is retaining support for -t (I use that quite a lot when recovering a system). Ideally we'd still be able to drop into the console at 115200 once the download is complete. > Marek