From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Packham Date: Sun, 10 May 2015 21:28:29 +1200 Subject: [U-Boot] [RFC PATCH v1 0/1] Include timezone information in build In-Reply-To: <20150508210502.GU5267@bill-the-cat> References: <1430354303-30200-1-git-send-email-judge.packham@gmail.com> <20150508210502.GU5267@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, On Sat, May 9, 2015 at 9:05 AM, Tom Rini wrote: > On Thu, Apr 30, 2015 at 12:38:22PM +1200, Chris Packham wrote: >> Hi, >> >> >> Recently an eagle-eyed tester pointed out to me that the build time >> reported in my u-boot build did not match the file timestamp on the >> server it was stored on. This is because at $dayjob we have a build farm >> with times set to UTC while the storage server was displaying the local >> time. In reality the times were the same but the timezones were not and >> there is no indication in the u-boot version about how to interpret the >> time. >> >> This is my attempt to address the issue by defining U_BOOT_TZ along side >> U_BOOT_TIME and U_BOOT_DATE. I've kept the TZ portion separate because I >> thought there might some push pack on changing the version string. For >> my purposes I can display the TZ separately as long as it is defined by >> the build process. I've also elected to use %Z instead of %z as I feel >> that the timezone name is more friendly but that's just a personal >> preference so I wouldn't object to switching to the numeric >> representation if others feel strongly. > > Concept is fine, I'd actually prefer %z so that the size increase is > constant at least. Please do that in a non-RFC v2 and I'll pick it up, > thanks! v2 has been sent. After I sent it out of curiosity, I looked up the POSIX definition of date[1] and it looks as though '%z' is not part of the spec ('%Z' is). However '%z' is part of the POSIX definition of strfttime[2]. In practice I'm not sure how much it matters. I know the GNU date command supports it and it looks like the freebsd one also does. I'm not sure which other environments people are using to build u-boot, hopefully any other environments pass the format string to strftime(). Just thought I'd bring it up in case someone reports an issue down the line. Thanks, Chris -- [1] - http://pubs.opengroup.org/onlinepubs/9699919799/utilities/date.html [2] - http://pubs.opengroup.org/onlinepubs/9699919799/functions/strftime.html