From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Packham Date: Wed, 16 May 2018 20:23:13 +1200 Subject: [U-Boot] [PATCH 09/12] ARM: kirkwood: Add device-tree for nsa310s In-Reply-To: References: <20180508103421.8422-1-judge.packham@gmail.com> <20180508103421.8422-10-judge.packham@gmail.com> <575e1cd7-2af1-24d6-4dee-c5e6a1a82ef4@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de (adding back list and cc, my bad replied from a mobile device) On Wed, May 16, 2018 at 8:10 PM Stefan Roese wrote: > Hi Chris, > On 16.05.2018 09:58, Chris Packham wrote: > > Hi Stefan, > > > > On Wed, 16 May 2018, 12:09 AM Stefan Roese, > > wrote: > > > > Hi Chris, > > > > On 10.05.2018 02:51, Chris Packham wrote: > > > On Thu, May 10, 2018 at 6:27 AM bodhi bodhi > > wrote: > > > > > >> Hi Chris, > > > > > >> What we have in Linux mainline is Zyxel NSA310 (Marvell > > 88f6281). The > > > Zyxel NSA310S (Marvell 88f6702) is actually a different box, > > which has not > > > been mainlined yet. > > > > > >> By the way, there are 3 variations of the Zyxel NSA310 box. This > > box has > > > some combination of: red USB Led, lm85 sensor, adt7476 sensor > > that make > > > them slighly different. The mainlined NSA310 DTS is for the one with > > > adt7476 sensor. > > > > > > > > > Ah OK. I did see 2 boards in the kernel, this was one of the > > "educated > > > guesses" which turns out not to to be a good guess. For now I'll > > just drop > > > this conversion from the series. > > > > Yes, that makes sense. Please do so. We can always get the correct > > version back into mainline, once we have Kirkwood "enabled" in a > > modern way. > > > > What is your plan with this Kirkwood revival? Do you plan to send > > updates to enable DM for those boards and perhaps some drivers as > > well? How should I proceed with this DT patch-set? > > > > > > I was about to ask you. > > > > I was thinking about sending a v2 omitting nas310s, but if that's the > > only change you could just omit it at your end. > So for a start its good that I apply these patches, omitting the nas310s > one? Yes thanks. Aside from the commend from Bodhi I haven't seen any other feedback. Not sure if you wanted to wait a bit longer. > > Then I've got another set lined up for the boards using spi flash which > > lays the groundwork for Jagan's spi changes. I may as well switch over > > the i2c configs since the driver already supports DM. I'll probably send > > those later this week. > > > > If i get really enthusiastic i might give converting the mvgbe driver to > > DM a try but the hardware I have for testing is complicated. > Sounds like a plan. Thanks for working on this. No problem I'm keen to see Kirkwood hang around.