wrote: > > > On 08/01/2018 01:42 AM, gokul cg wrote: > >> Hi Thomas, >> >> In my hardware, there is i2c power control chip for PCI card, I just >> powered down using i2c command . >> > > Hi Gokul, > When you power off the card via the i2c, it forcefully power off the card > without notify the kernel? That is, during the card power off sequence it > manages to send a last AER isr to report the error and die? I am kind of > expect the pcie surprise removal or hot plug driver will handle it > correctly. > > Thanks, > Thomas > > >> Regards, >> Gokul >> > --0000000000000112c10572643167 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

HI Thomas ,=C2=A0

Yes , = its surprise removal .

But as far as I know , linu= x kernel will handle surprise removal of PCIe device without panic.

The=C2=A0driver will = suddenly start reading all 0xff and will then need to
abort= =C2=A0whatever=C2=A0it was doing<= span style=3D"font-family:"Helvetica Neue",Arial,sans-serif;text-= decoration-style:initial;text-decoration-color:initial;float:none;display:i= nline">. Usually=C2=A0all drivers handle this j= ust fine.

Nothing, the driver = individually=C2=A0needs to h= andle the fact that it might
at any time, s= tart=C2=A0getting invalid=C2=A0data. If it doesn't, = it needs to be
fixed. Whether AER=C2=A0 dri= ver that does not handle this properly?

Regards,

Gokul=C2=A0<= /div>

On Wed= , Aug 1, 2018 at 11:17 PM, Thomas Tai <thomas.tai@oracle.com> wrote:

On 08/01/2018 01:42 AM, gokul cg wrote:

Hi Thomas,

In my hardware, there is i2c power control chip for PCI card, I just powere= d down using i2c command .

Hi Gokul,
When you power off the card via the i2c, it forcefully power off the card w= ithout notify the kernel? That is, during the card power off sequence it ma= nages to send a last AER isr to report the error and die? I am kind of expe= ct the pcie surprise removal or hot plug driver will handle it correctly.
Thanks,
Thomas

Regards,
Gokul

--0000000000000112c10572643167--