Re: [PATCH 0/6] Minimal patches to let reftable pass the CI builds - Han-Wen Nienhuys

From: Han-Wen Nienhuys <hanwen@google.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git <git@vger.kernel.org>, Han-Wen Nienhuys <hanwenn@gmail.com>,
	Jeff King <peff@peff.net>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 0/6] Minimal patches to let reftable pass the CI builds
Date: Mon, 30 Nov 2020 15:26:16 +0100	[thread overview]
Message-ID: <CAFQ2z_M8N-9pCh=+rQvGoOJNYAxnMo1upJPEgsqMT9VxP5X=YA@mail.gmail.com> (raw)
In-Reply-To: <pull.801.git.1606545878.gitgitgadget@gmail.com>

On Sat, Nov 28, 2020 at 7:44 AM Johannes Schindelin via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> These patches fix the PR build failures at
> https://github.com/git/git/pull/847/checks?check_run_id=1460683728, and are
> designed to be squashed into the 16 patches of the libreftable v3 patch
> series as submitted at
> https://lore.kernel.org/git/pull.847.v3.git.git.1606419752.gitgitgadget@gmail.com/
> .
>
> A smaller form of the first patch was offered on the mailing list on May
> 4th:
> https://lore.kernel.org/git/ff60fde10919b6b8c54ecb8f38b710fac37624e3.1588599086.git.gitgitgadget@gmail.com/
> . The next three patches were presented to the mailing list on October 2nd:
> https://lore.kernel.org/git/nycvar.QRO.7.76.6.2010021555290.50@tvgsbejvaqbjf.bet/
> , and
> https://lore.kernel.org/git/nycvar.QRO.7.76.6.2010021557570.50@tvgsbejvaqbjf.bet/
> . Some of the patches required slight adjustments to accommodate for context
> changes.
>
> Going forward, I would like to avoid the impression that it is the
> responsibility of the Git for Windows maintainer to keep the CI build
> passing on Windows. I am happy to assist in case it is unclear how to fix
> certain issues. I am not happy having to implement and test those fixes
> myself. How can we ensure this doesn't happen in the future?

Thanks for the build system fix. I think it's OK to leave it to me to
solve the logic problems in the C code that you found.

Would you mind if I massaged these contributions directly back into
github.com/google/reftable? Google has a corporate CLA from Microsoft,
it's OK to accept this from you. For better or worse, this is still
where I'm developing reftable, until it has landed in git-core.

-- 
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--

Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado