All of lore.kernel.org
 help / color / mirror / Atom feed
From: Havard Skinnemoen <hskinnemoen@google.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Markus Armbruster" <armbru@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"CS20 KFTing" <kfting@nuvoton.com>,
	qemu-arm <qemu-arm@nongnu.org>, "Cédric Le Goater" <clg@kaod.org>,
	"IS20 Avi Fishman" <Avi.Fishman@nuvoton.com>
Subject: Re: [PATCH v3 00/12] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines
Date: Fri, 3 Jul 2020 14:15:37 -0700	[thread overview]
Message-ID: <CAFQmdRbOKFxxxgR0hqcnABxn+jSBr349159m45TJLawVmnhR3Q@mail.gmail.com> (raw)
In-Reply-To: <296f281f-e045-e794-1a1b-4e311b6408b2@redhat.com>

On Fri, Jul 3, 2020 at 6:35 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> On 7/3/20 2:27 PM, Peter Maydell wrote:
> > On Sat, 27 Jun 2020 at 00:55, Havard Skinnemoen <hskinnemoen@google.com> wrote:
> >>
> >> Time for another refresh of this patchset. Sorry it took so long -- I've been
> >> trying to figure out why the Winbond flash model isn't working with
> >> npcm750-evb, and I'm fairly convinced the number of dummy cycles in DIO mode
> >> should be 4, not 1. Unfortunately, I don't see any other machines using Winbond
> >> flash in DIO mode, so it's hard to prove that it's correct. I'm planning to
> >> post a libqos-based test suite separately.
> >>
> >> I'm also planning to add the vbootrom to qemu as a submodule, similar to the
> >> other roms, but not in this pathset (let me know if you do want me to include
> >> this in the series).
> >
> > Hi; it looks like codewise this patchset is ready to go in
> > and it's all been reviewed. I see however that all the
> > new files are GPL-v2-only. We usually prefer GPL-v2-or-later
> > for new code: is it possible to use that license instead ?
>
> This series has been posted before Markus qdev & error cleanups.
> Maybe some newer error patterns should be used now instead?

I'm not sure if I understand exactly what you're referring to, but
I'll do 'git log origin/master --author=armbru@redhat.com' to see if I
can apply any similar fixes or cleanups to this series.

Havard


  reply	other threads:[~2020-07-03 21:16 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 23:55 [PATCH v3 00/12] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 01/12] npcm7xx: Add config symbol Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 02/12] hw/misc: Add NPCM7xx System Global Control Registers device model Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 03/12] hw/misc: Add NPCM7xx Clock Controller " Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 04/12] hw/timer: Add NPCM7xx Timer " Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 05/12] hw/arm: Add NPCM730 and NPCM750 SoC models Havard Skinnemoen
2020-07-03 13:32   ` Philippe Mathieu-Daudé
2020-07-03 20:56     ` Havard Skinnemoen
2020-07-03 22:27       ` Philippe Mathieu-Daudé
2020-06-26 23:55 ` [PATCH v3 06/12] hw/arm: Add two NPCM7xx-based machines Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 07/12] hw/arm: Load -bios image as a boot ROM for npcm7xx Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 08/12] hw/nvram: NPCM7xx OTP device model Havard Skinnemoen
2020-07-03 13:46   ` Philippe Mathieu-Daudé
2020-07-03 21:07     ` Havard Skinnemoen
2020-07-03 21:19       ` Havard Skinnemoen
2020-07-03 21:34         ` Philippe Mathieu-Daudé
2020-07-03 22:24       ` Philippe Mathieu-Daudé
2020-07-04  0:50         ` Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 09/12] hw/mem: Stubbed out NPCM7xx Memory Controller model Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 10/12] hw/ssi: NPCM7xx Flash Interface Unit device model Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 11/12] hw/arm: Wire up BMC boot flash for npcm750-evb and quanta-gsj Havard Skinnemoen
2020-06-26 23:55 ` [PATCH v3 12/12] docs/system: Add Nuvoton machine documentation Havard Skinnemoen
2020-07-03 16:35   ` Philippe Mathieu-Daudé
2020-07-03 21:02     ` Havard Skinnemoen
2020-06-27  0:15 ` [PATCH v3 00/12] Add Nuvoton NPCM730/NPCM750 SoCs and two BMC machines no-reply
2020-07-03 12:27 ` Peter Maydell
2020-07-03 13:35   ` Philippe Mathieu-Daudé
2020-07-03 21:15     ` Havard Skinnemoen [this message]
2020-07-03 22:33       ` Philippe Mathieu-Daudé
2020-07-03 20:41   ` Havard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFQmdRbOKFxxxgR0hqcnABxn+jSBr349159m45TJLawVmnhR3Q@mail.gmail.com \
    --to=hskinnemoen@google.com \
    --cc=Avi.Fishman@nuvoton.com \
    --cc=armbru@redhat.com \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=kfting@nuvoton.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.