From: Maxim Sloyko <maxims@google.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/12] aspeed/ast2500: Helper function to get access to SCU
Date: Tue, 17 Jan 2017 14:27:03 -0800 [thread overview]
Message-ID: <CAFR_W8pruJj4iEcM1j5eMDwY7_W4Pk_CXxi4eRnmAkBMPkByWg@mail.gmail.com> (raw)
In-Reply-To: <CAPnjgZ2Cz1a6GTpm9x5G8SO+WNUhrqPiaLA-YMbX7eetDA5_hg@mail.gmail.com>
On Sat, Jan 14, 2017 at 9:14 AM, Simon Glass <sjg@chromium.org> wrote:
> Hi Maxim,
>
> On 4 January 2017 at 12:46, Maxim Sloyko <maxims@google.com> wrote:
> > Helper function to get access to SCU (System Control Unit) through Clock
> > driver. This is similar to rockchip_get_cru function, which was used as
> > an example.
> >
> > It will be used by other drivers to get access to SCU.
> >
> > Signed-off-by: Maxim Sloyko <maxims@google.com>
> > ---
> >
> > arch/arm/mach-aspeed/Kconfig | 2 ++
> > arch/arm/mach-aspeed/Makefile | 1 +
> > arch/arm/mach-aspeed/ast2500/Kconfig | 6 ++++++
> > arch/arm/mach-aspeed/ast2500/Makefile | 1 +
> > arch/arm/mach-aspeed/ast2500/clk_ast2500.c | 31
> ++++++++++++++++++++++++++++++
> > 5 files changed, 41 insertions(+)
> > create mode 100644 arch/arm/mach-aspeed/ast2500/Kconfig
> > create mode 100644 arch/arm/mach-aspeed/ast2500/Makefile
> > create mode 100644 arch/arm/mach-aspeed/ast2500/clk_ast2500.c
>
> The code seems fine.
>
> It seems odd that you have Kconfig changes here also. Why is that?
>
This was probably a mistake, looks like this does not apply to a series
with fewer patches.
>
> Regards,
> Simon
>
--
*M*axim *S*loyko
next prev parent reply other threads:[~2017-01-17 22:27 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 19:46 [U-Boot] [PATCH 00/12] arm: aspeed: Basic support for Aspeed AST2500 part and eval board Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 01/12] aspeed: Add mach-aspeed directory and basic Kconfig Maxim Sloyko
2017-01-04 19:58 ` Rick Altherr
2017-01-04 20:23 ` Tom Rini
2017-01-14 17:13 ` Simon Glass
2017-01-18 0:15 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 02/12] aspeed: Add support for Watchdot Timer Maxim Sloyko
2017-01-04 20:58 ` Tom Rini
2017-01-14 17:13 ` Simon Glass
2017-01-04 19:46 ` [U-Boot] [PATCH 03/12] aspeed: Add Timer Support Maxim Sloyko
2017-01-04 20:58 ` Tom Rini
2017-01-14 17:13 ` Simon Glass
2017-01-17 17:57 ` Maxim Sloyko
2017-01-17 21:37 ` Simon Glass
2017-01-17 23:59 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 04/12] aspeed: Add sysreset driver Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-04 19:46 ` [U-Boot] [PATCH 05/12] aspeed/ast2500: Device Tree and bindings for some of the clocks Maxim Sloyko
2017-01-04 20:58 ` Tom Rini
2017-01-05 1:18 ` Maxim Sloyko
2017-01-05 3:26 ` Tom Rini
2017-01-05 22:20 ` Maxim Sloyko
2017-01-14 17:13 ` Simon Glass
2017-01-17 23:27 ` Maxim Sloyko
2017-01-21 3:52 ` Simon Glass
2017-01-23 17:52 ` Maxim Sloyko
2017-01-23 19:51 ` Simon Glass
2017-01-04 19:46 ` [U-Boot] [PATCH 06/12] aspeed/ast2500: Add Clock Driver Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 23:18 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 07/12] aspeed/ast2500: Helper function to get access to SCU Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 22:27 ` Maxim Sloyko [this message]
2017-01-04 19:46 ` [U-Boot] [PATCH 08/12] aspeed/ast2500: Add SDRAM MC driver Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-18 20:16 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 09/12] aspeed/ast2500: Common board init functions for ast2500 based boards Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 20:17 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 10/12] aspeed: Common configuration parameters for aspeed boards Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 20:02 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 11/12] aspeed: Device Tree for ast2500 Eval Board Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 19:51 ` Maxim Sloyko
2017-01-04 19:46 ` [U-Boot] [PATCH 12/12] aspeed: Configuration for ast2500 eval board Maxim Sloyko
2017-01-14 17:14 ` Simon Glass
2017-01-17 19:46 ` Maxim Sloyko
2017-01-21 3:51 ` Simon Glass
2017-01-04 20:26 ` [U-Boot] [PATCH 00/12] arm: aspeed: Basic support for Aspeed AST2500 part and " Tom Rini
2017-01-04 22:47 ` Maxim Sloyko
2017-01-04 20:58 ` Tom Rini
2017-01-05 22:42 ` [U-Boot] [PATCH v1 0/4] " Maxim Sloyko
2017-01-05 22:42 ` [U-Boot] [PATCH v1 1/4] aspeed: Add drivers common to all Aspeed SoCs Maxim Sloyko
2017-01-05 22:42 ` [U-Boot] [PATCH v1 2/4] aspeed: Add basic ast2500 specific drivers and configuration Maxim Sloyko
2017-01-05 22:42 ` [U-Boot] [PATCH v1 3/4] aspeed: Board init functions and common configs for ast2500 based boards Maxim Sloyko
2017-01-05 22:42 ` [U-Boot] [PATCH v1 4/4] aspeed: Support for ast2500 Eval Board Maxim Sloyko
2017-01-10 1:50 ` [U-Boot] [PATCH v2 0/4] arm: aspeed: Basic support for Aspeed AST2500 part and eval board Maxim Sloyko
2017-01-10 1:50 ` [U-Boot] [PATCH v2 1/4] aspeed: Add drivers common to all Aspeed SoCs Maxim Sloyko
2017-01-11 3:20 ` Tom Rini
2017-01-10 1:50 ` [U-Boot] [PATCH v2 2/4] aspeed: Add basic ast2500 specific drivers and configuration Maxim Sloyko
2017-01-11 3:20 ` Tom Rini
2017-01-10 1:50 ` [U-Boot] [PATCH v2 3/4] aspeed: Board init functions and common configs for ast2500 based boards Maxim Sloyko
2017-01-11 3:20 ` Tom Rini
2017-01-11 23:40 ` Maxim Sloyko
2017-01-10 1:50 ` [U-Boot] [PATCH v2 4/4] aspeed: Support for ast2500 Eval Board Maxim Sloyko
2017-01-11 3:20 ` Tom Rini
2017-01-11 23:45 ` [U-Boot] [PATCH v3 0/4] arm: aspeed: Basic support for Aspeed AST2500 part and eval board Maxim Sloyko
2017-01-11 23:45 ` [U-Boot] [PATCH v3 1/4] aspeed: Add drivers common to all Aspeed SoCs Maxim Sloyko
2017-01-13 0:51 ` Tom Rini
2017-01-11 23:45 ` [U-Boot] [PATCH v3 2/4] aspeed: Add basic ast2500 specific drivers and configuration Maxim Sloyko
2017-01-11 23:45 ` [U-Boot] [PATCH v3 3/4] aspeed: Board init functions and common configs for ast2500 based boards Maxim Sloyko
2017-01-13 0:51 ` Tom Rini
2017-01-11 23:45 ` [U-Boot] [PATCH v3 4/4] aspeed: Support for ast2500 Eval Board Maxim Sloyko
2017-01-13 0:51 ` Tom Rini
2017-01-18 21:44 ` [U-Boot] [PATCH v4 0/4] arm: aspeed: Basic support for Aspeed AST2500 part and eval board Maxim Sloyko
2017-01-18 21:44 ` [U-Boot] [PATCH v4 1/4] aspeed: Add drivers common to all Aspeed SoCs Maxim Sloyko
2017-01-26 14:23 ` Simon Glass
2017-01-26 18:31 ` Maxim Sloyko
2017-01-28 22:44 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-01-18 21:44 ` [U-Boot] [PATCH v4 2/4] aspeed: Add basic ast2500-specific drivers and configuration Maxim Sloyko
2017-01-26 14:23 ` Simon Glass
2017-01-26 18:02 ` Maxim Sloyko
2017-01-28 22:44 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-01-18 21:44 ` [U-Boot] [PATCH v4 3/4] aspeed: Board init functions and common configs for ast2500 based boards Maxim Sloyko
2017-01-26 14:23 ` Simon Glass
2017-01-28 22:44 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-01-18 21:44 ` [U-Boot] [PATCH v4 4/4] aspeed: Support for ast2500 Eval Board Maxim Sloyko
2017-01-26 14:23 ` Simon Glass
2017-01-28 22:44 ` [U-Boot] [U-Boot, v4, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFR_W8pruJj4iEcM1j5eMDwY7_W4Pk_CXxi4eRnmAkBMPkByWg@mail.gmail.com \
--to=maxims@google.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.