All of lore.kernel.org
 help / color / mirror / Atom feed
* regulator: Question about hi655x ldo19 voltage table
@ 2021-06-12 15:52 Axel Lin
  0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2021-06-12 15:52 UTC (permalink / raw)
  To: Chen Feng, Fei Wang, Xinwei Kong, Hao Fang, Mark Brown, Liam Girdwood
  Cc: LKML

Hi,

Current code has below voltage table for ldo19:

static const unsigned int ldo19_voltages[] = {
        1800000, 1850000, 1900000, 1750000,
        2800000, 2850000, 2900000, 3000000,
};

The 1750000 looks unusual but I cannot find the datasheet to confirm it.
I found in the initial version of the patch submission, it has below
regulator-vset-table [1]

+               ldo19: regulator@a38 {
+                       compatible = "hisilicon,hi655x-regulator-pmic";
+                       regulator-name = "ldo19";
+                       regulator-min-microvolt = <1800000>;
+                       regulator-max-microvolt = <3000000>;
+                       regulator-initial-mode = <0x02>;
+                       regulator-off-on-delay = <360>;
+                       regulator-ctrl-regs = <0x02f 0x030 0x031>;
+                       regulator-ctrl-mask = <0x2>;
+                       regulator-vset-regs = <0x084>;
+                       regulator-vset-mask = <0x3>;
+                       regulator-n-vol = <8>;
+                       regulator-vset-table  = <1800000>,<1850000>,
+                                               <1900000>,<2750000>,
+                                               <2800000>,<2850000>,
+                                               <2900000>,<3000000>;

So I'm wondering if the 1750000 is a typo? (should be 2750000).
Can someone help to confirm this?

[1] https://lore.kernel.org/patchwork/patch/615156/

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-12 15:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 15:52 regulator: Question about hi655x ldo19 voltage table Axel Lin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.