All of lore.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Zhang <markz@nvidia.com>,
	Venkat Reddy Talla <vreddytalla@nvidia.com>,
	Laxman Dewangan <ldewangan@nvidia.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: max77620: Fix regulator info setting for max20024
Date: Thu, 21 Mar 2019 16:37:20 +0800	[thread overview]
Message-ID: <CAFRkauBdWeR8epskSrVNXG242LUu3PhHkidky61u31sPte-iMg@mail.gmail.com> (raw)
In-Reply-To: <20190224012654.17217-1-axel.lin@ingics.com>

Axel Lin <axel.lin@ingics.com> 於 2019年2月24日 週日 上午9:27寫道：
>
> Current code always set pmic->rinfo[id] = &max77620_regs_info[id];
> It should set to either max77620_regs_info or max20024_regs_info
> depends on the chip_id.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/regulator/max77620-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/max77620-regulator.c b/drivers/regulator/max77620-regulator.c
> index 1607ac673e44..0ad91a7f9cb9 100644
> --- a/drivers/regulator/max77620-regulator.c
> +++ b/drivers/regulator/max77620-regulator.c
> @@ -803,7 +803,7 @@ static int max77620_regulator_probe(struct platform_device *pdev)
>                         continue;
>
>                 rdesc = &rinfo[id].desc;
> -               pmic->rinfo[id] = &max77620_regs_info[id];
> +               pmic->rinfo[id] = &rinfo[id];

I'm wondering if anyone can help review this patch.
This looks like a bug fix to me because for max20024 MAX77620_REGULATOR_ID_SD4,
the pmic->rinfo[id] = &max77620_regs_info[id]; set pmic->rinfo[id] to
a zero-filled entry.
e.g. In max77620_regulator_set_power_mode, rinfo->cfg_addr is wrong
for MAX77620_REGULATOR_ID_SD4.

Thanks,
Axel

      reply	other threads:[~2019-03-21  8:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-24  1:26 [PATCH] regulator: max77620: Fix regulator info setting for max20024 Axel Lin
2019-03-21  8:37 ` Axel Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFRkauBdWeR8epskSrVNXG242LUu3PhHkidky61u31sPte-iMg@mail.gmail.com \
    --to=axel.lin@ingics.com \
    --cc=broonie@kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markz@nvidia.com \
    --cc=vreddytalla@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.