All of lore.kernel.org
 help / color / mirror / Atom feed
From: Axel Lin <axel.lin@ingics.com>
To: "cy_huang(黃啟原)" <cy_huang@richtek.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH] regulator: rt6160: Convert to use regulator_set_ramp_delay_regmap
Date: Thu, 3 Jun 2021 18:57:53 +0800	[thread overview]
Message-ID: <CAFRkauC2qugUBbHccf6jV=e_xRLAJP0JyPsFMzmTQO5KUaj=Qg@mail.gmail.com> (raw)
In-Reply-To: <1622716902.1034.15.camel@richtek.com>

cy_huang(黃啟原) <cy_huang@richtek.com> 於 2021年6月3日 週四 下午6:41寫道：
>
> > cy_huang(黃啟原) <cy_huang@richtek.com> 於 2021年6月3日 週四 下午6:20寫道：
> > >
> > >
> > > Hi, Axel:> Use regulator_set_ramp_delay_regmap instead of open-coded.
> > > >
> > > >
> > > There's some reason.
> > > You can refer to https://lkml.org/lkml/2021/6/1/1145.
> > >
> > > It's because our ramp value order is from small to large, not large to
> > > small.
> > > It conflicts with find_closest_bigger value chosen logic.
> > I have verified the rt6160_set_ramp_delay() behavior exactly the same as
> > regulator_set_ramp_delay_regmap. (both functions get the same selector
> > for a given delay)
> >
> > Could you check if this patch works?
> Sure.

The find_closest_bigger() does not rely on ascending or descending
table entries.
Regards,
Axel

  reply	other threads:[~2021-06-03 10:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  9:38 [PATCH] regulator: rt6160: Convert to use regulator_set_ramp_delay_regmap Axel Lin
2021-06-03 10:20 ` cy_huang(黃啟原)
2021-06-03 10:28   ` Axel Lin
2021-06-03 10:41     ` cy_huang(黃啟原)
2021-06-03 10:57       ` Axel Lin [this message]
2021-06-03 15:18       ` cy_huang(黃啟原)
2021-06-04  0:13         ` Axel Lin
     [not found]           ` <1622773474.9011.14.camel@richtek.com>
2021-06-04  3:30             ` Axel Lin
     [not found]               ` <1622785727.9011.17.camel@richtek.com>
2021-06-04  5:59                 ` Axel Lin
     [not found]                   ` <1622788151.9011.20.camel@richtek.com>
2021-06-09  3:32                     ` Axel Lin
2021-06-09  3:38                       ` cy_huang(黃啟原)
2021-06-14 19:53 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFRkauC2qugUBbHccf6jV=e_xRLAJP0JyPsFMzmTQO5KUaj=Qg@mail.gmail.com' \
    --to=axel.lin@ingics.com \
    --cc=broonie@kernel.org \
    --cc=cy_huang@richtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.