From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8419C433E9 for ; Thu, 25 Feb 2021 13:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 822E264EF5 for ; Thu, 25 Feb 2021 13:35:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232767AbhBYNey (ORCPT ); Thu, 25 Feb 2021 08:34:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232471AbhBYNe2 (ORCPT ); Thu, 25 Feb 2021 08:34:28 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AF0FC061574 for ; Thu, 25 Feb 2021 05:33:48 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id d9so5606615ote.12 for ; Thu, 25 Feb 2021 05:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8TXR6/lpKpH9aZdVQTsnycwvzWAzc2Rzb8JN7l6hUgY=; b=fncs1cyXv6HwjmG0fFpd82YainoJ4y6Rj4btE30n8Ox6dlprrgKjKd1yhu5dFm72Sv enuB5Mb4oCFsLJjIVLr75iXL4ozDKgNWX+ffwxuKh5QEYQRljds0K3SxWetZWuh4GOIk K0DO2D21mrXeBeBusGqAzQ5RA5qr2irP4OKHzCZE10248iHJd2CqIljPa/e00LP7t0UJ LpcWMTpeku+a7UZTia8xlLwsmmZzq6uAR5GHk9Fya87tbZxOMDHFnPbao3vXN8G7p1cI +Isr54QZ6DjxEhBP4qZ29XBN2A66VKFLf9oBc05reuVht7eA0pHdS9ZBYy7Axf4kE1zO qiIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8TXR6/lpKpH9aZdVQTsnycwvzWAzc2Rzb8JN7l6hUgY=; b=iMViZ9nHlRO5Q+QlfUeknUg/dW/c41/yn7ZlLDu/6lYg5XHdhSC6hjUmRfSla4iobu 0KpHWjo7anBGRdX0gvaRD3ZkcRHC5/pTEPuGAoEGQeVZye6hUZ/FGHA9FubHDQYQTEQ7 v2B7alqzk/KZl+cETOqyA3rB/ZvdnHlz0gaXxW3s5Xrt+0AUYjJNwdraUQHe0+KPc+vs wV4ItyeaT8Mui7nNi9cHBJjkJ7KOBNsYRb7IRcXXgXzRDeVYBULGE9tlVsWcKX8dOhOk 8OaDoR0ZpuEXnEI0P8rIWeT+1BHgIIB9LSNOVkvQHXqNKxdZuAz6yM2RlRaOYbZHdUGX RdSw== X-Gm-Message-State: AOAM533zmGRRTsAGnfpf63Q+3sX/3870DlFQjL8MEQLF4W/EtI4rk1we /tLVnXEMcZao6ku71sswTBZ3P6wki/HDUD2qtw== X-Google-Smtp-Source: ABdhPJxwGwzfdPpOaoBHPD8JMVluKVKrOY2vcrs3QVl9n4hF8abHIKEpDLtp/7W26gxScess3MdC1D4wkyAAmD84R6g= X-Received: by 2002:a9d:131:: with SMTP id 46mr2270096otu.287.1614260027358; Thu, 25 Feb 2021 05:33:47 -0800 (PST) MIME-Version: 1.0 References: <20210221213355.1241450-1-olteanv@gmail.com> <20210221213355.1241450-11-olteanv@gmail.com> In-Reply-To: From: George McCollister Date: Thu, 25 Feb 2021 07:33:35 -0600 Message-ID: Subject: Re: [RFC PATCH net-next 10/12] Documentation: networking: dsa: add paragraph for the HSR/PRP offload To: Andrew Lunn Cc: Vladimir Oltean , netdev@vger.kernel.org, Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , DENG Qingfang , Tobias Waldekranz , Horatiu Vultur , Kurt Kanzenbach Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 24, 2021 at 7:42 PM Andrew Lunn wrote: > > > +IEC 62439-3 (HSR/PRP) > > +--------------------- > > + > > +The Parallel Redundancy Protocol (PRP) is a network redundancy protocol which > > +works by duplicating and sequence numbering packets through two independent L2 > > +networks (which are unaware of the PRP tail tags carried in the packets), and > > +eliminating the duplicates at the receiver. The High-availability Seamless > > +Redundancy (HSR) protocol is similar in concept, except all nodes that carry > > +the redundant traffic are aware of the fact that it is HSR-tagged (because HSR > > +uses a header with an EtherType of 0x892f) and are physically connected in a > > +ring topology. Both HSR and PRP use supervision frames for monitoring the > > I don't know HSR/PRP terms. Should it be supervisory instead of > supervision? IEC 62439-3 refers to them primarily as supervision frames however supervisory frames also appears once in the document. > > > +health of the network and for discovering the other nodes. > > Either "discovering other nodes" or "discovery of other nodes". > > > + > > +In Linux, both HSR and PRP are implemented in the hsr driver, which > > +instantiates a virtual, stackable network interface with two member ports. > > +The driver only implements the basic roles of DANH (Doubly Attached Node > > +implementing HSR) and DANP (Doubly Attached Node implementing PRP); the roles > > +of RedBox and QuadBox aren't (therefore, bridging a hsr network interface with > > In colloquial English, you can get away with just 'aren't'. But in > Queens English, you should follow it with something, in this case > 'supported'. > > Andrew