From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Duskett Date: Fri, 6 Dec 2019 14:27:44 -0800 Subject: [Buildroot] [PATCH v4 1/1] package/grpc: bump to version 1.25.0 In-Reply-To: <20191206214820.1b68bf43@windsurf.home> References: <20191206182726.3645508-1-aduskett@gmail.com> <20191206214820.1b68bf43@windsurf.home> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Fri, Dec 6, 2019 at 12:48 PM Thomas Petazzoni wrote: > > On Fri, 6 Dec 2019 10:27:26 -0800 > aduskett at gmail.com wrote: > > > +# Toolchains older than gcc5 will fail to compile with -0s due to: > > +# error: failure memory model cannot be stronger than success memory model for > > +# '__atomic_compare_exchange' > > +ifneq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),y) > > That's not what I want. What I want is: > Then tell me! I'm not a mind reader! Submitting the same patch over and over again is frustrating when it's little changes that aren't covered in the initial review but could have been. > ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5):$(BR2_OPTIMIZE_S),:y) > GRPC_CFLAGS += -O0 > GRPC_CXXFLAGS += -O0 > endif > > i.e, override the flags only when -Os is used. > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Adam