All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Duskett <aduskett@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/grpc: bump to version 1.25.0
Date: Fri, 6 Dec 2019 09:46:04 -0800	[thread overview]
Message-ID: <CAFSsvmqfkP9jYEabkXcrR9SRnV0wZT+=YKoYF+TrTu7drkwyvQ@mail.gmail.com> (raw)
In-Reply-To: <20191205221807.3022cc5b@windsurf>

I'm not sure, but the same could be said to the above as well.

On Thu, Dec 5, 2019 at 1:18 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Thu,  5 Dec 2019 13:01:55 -0800
> aduskett at gmail.com wrote:
>
> > -GRPC_VERSION = 1.23.0
> > +GRPC_VERSION = 1.25.0
> >  GRPC_SITE = $(call github,grpc,grpc,v$(GRPC_VERSION))
> >  GRPC_LICENSE = Apache-2.0
> >  GRPC_LICENSE_FILES = LICENSE
> > @@ -48,6 +48,14 @@ GRPC_CFLAGS += -O0
> >  GRPC_CXXFLAGS += -O0
> >  endif
> >
> > +# Toolchains older than gcc5 will fail to compile with -0s due to:
> > +# error: failure memory model cannot be stronger than success memory model for
> > +# '__atomic_compare_exchange'
> > +ifneq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),y)
>
> Could also be:
>
> ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),)
>
> > +GRPC_CFLAGS += -O0
> > +GRPC_CXXFLAGS += -O0
>
> What happens when O2 or O3 are the default optimization flags? Does it
> build? If it does, what you're doing is a bit brutal, as you're forcing
> O0 even if O2 or O3 would work.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

  reply	other threads:[~2019-12-06 17:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-05 21:01 [Buildroot] [PATCH v3 1/1] package/grpc: bump to version 1.25.0 aduskett at gmail.com
2019-12-05 21:18 ` Thomas Petazzoni
2019-12-06 17:46   ` Adam Duskett [this message]
2019-12-06 18:28     ` Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFSsvmqfkP9jYEabkXcrR9SRnV0wZT+=YKoYF+TrTu7drkwyvQ@mail.gmail.com' \
    --to=aduskett@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.