Re: [Buildroot] [PATCH] package/sentry-cli: remove package

[Adam Duskett <aduskett@gmail.com>]

Thomas;

It seems like version 1.68.0 fixes the build failures. I have tested
two different
defconfigs that are on the failure list:
  - bf7361dc482d8f3f97d523b7d56eabe5bc515ae8
  - 97aa03f497536462abc85011ba1c94874d18f237

And the new version doesn't produce the failures that are plaguing the
autobuilders.

Instead of removing the package, I would suggest updating it to 1.68.0 instead.

Adam

On Wed, Aug 18, 2021 at 1:22 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> This package has had build failures for a very long time, and these
> issues have not been fixed, and it is now the number 1 build failure
> reason in our autobuilders. It is time to acknowledge that the package
> needs to be removed.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  DEVELOPERS                         |  1 -
>  package/Config.in.host             |  1 -
>  package/sentry-cli/Config.in.host  | 10 ----------
>  package/sentry-cli/sentry-cli.hash |  3 ---
>  package/sentry-cli/sentry-cli.mk   | 32 ------------------------------
>  5 files changed, 47 deletions(-)
>  delete mode 100644 package/sentry-cli/Config.in.host
>  delete mode 100644 package/sentry-cli/sentry-cli.hash
>  delete mode 100644 package/sentry-cli/sentry-cli.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index af97de02de..64cd29d7d1 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1441,7 +1441,6 @@ F:        package/python-schedule/
>  F:     package/python-sentry-sdk/
>  F:     package/python-websockets/
>  F:     package/python-xlib/
> -F:     package/sentry-cli/
>  F:     package/sentry-native/
>  F:     package/unclutter-xfixes/
>
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 8d443ea255..551352482e 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -79,7 +79,6 @@ menu "Host utilities"
>         source "package/s6-rc/Config.in.host"
>         source "package/sam-ba/Config.in.host"
>         source "package/sdbusplus/Config.in.host"
> -       source "package/sentry-cli/Config.in.host"
>         source "package/squashfs/Config.in.host"
>         source "package/sunxi-tools/Config.in.host"
>         source "package/swig/Config.in.host"
> diff --git a/package/sentry-cli/Config.in.host b/package/sentry-cli/Config.in.host
> deleted file mode 100644
> index 3124015367..0000000000
> --- a/package/sentry-cli/Config.in.host
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -config BR2_PACKAGE_HOST_SENTRY_CLI
> -       bool "host sentry-cli"
> -       depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
> -       select BR2_PACKAGE_HOST_RUSTC
> -       help
> -         Official Sentry command line interface
> -
> -         For managing debug information files and source maps.
> -
> -         https://docs.sentry.io/cli/
> diff --git a/package/sentry-cli/sentry-cli.hash b/package/sentry-cli/sentry-cli.hash
> deleted file mode 100644
> index 3b0733a276..0000000000
> --- a/package/sentry-cli/sentry-cli.hash
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# locally calculated
> -sha256  5d0f7acf6a139d1c1716b9a8ff76c8bfaab09104ba663c957bb9a5dba2ffbabd  sentry-cli-1.57.0.tar.gz
> -sha256  9503def7b54ceb6e3cd182fd59bc05d3a30d7eae481e65aaba4b495133c83c14  LICENSE
> diff --git a/package/sentry-cli/sentry-cli.mk b/package/sentry-cli/sentry-cli.mk
> deleted file mode 100644
> index 7e53f16026..0000000000
> --- a/package/sentry-cli/sentry-cli.mk
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -################################################################################
> -#
> -# sentry-cli
> -#
> -################################################################################
> -
> -SENTRY_CLI_VERSION = 1.57.0
> -SENTRY_CLI_SITE = $(call github,getsentry,sentry-cli,$(SENTRY_CLI_VERSION))
> -SENTRY_CLI_LICENSE = BSD-3-clause
> -SENTRY_CLI_LICENSE_FILES = LICENSE
> -
> -HOST_SENTRY_CLI_DEPENDENCIES = host-rustc host-zlib
> -
> -HOST_SENTRY_CLI_CARGO_ENV = \
> -       CARGO_HOME=$(HOST_DIR)/share/cargo \
> -       RUSTFLAGS="$(addprefix -C link-args=,$(HOST_LDFLAGS))"
> -
> -HOST_SENTRY_CLI_CARGO_OPTS = \
> -       --release \
> -       --manifest-path=$(@D)/Cargo.toml
> -
> -define HOST_SENTRY_CLI_BUILD_CMDS
> -       $(HOST_MAKE_ENV) $(HOST_SENTRY_CLI_CARGO_ENV) \
> -               cargo build $(HOST_SENTRY_CLI_CARGO_OPTS)
> -endef
> -
> -define HOST_SENTRY_CLI_INSTALL_CMDS
> -       $(INSTALL) -D -m 0755 $(@D)/target/release/sentry-cli \
> -               $(HOST_DIR)/bin/sentry-cli
> -endef
> -
> -$(eval $(host-generic-package))
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot