All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: "the arch/x86 maintainers" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86/dumpstack: make stack name tags more comprehensible
Date: Sat, 19 Nov 2016 16:49:46 +0100	[thread overview]
Message-ID: <CAFTL4hwet4+rm+y=EX=K1G+x7G+qk0+un8X4K2dJ3QBTeNbttw@mail.gmail.com> (raw)
In-Reply-To: <180196e3754572540b595bc56b947d43658979a7.1479491159.git.jpoimboe@redhat.com>

2016-11-18 18:46 GMT+01:00 Josh Poimboeuf <jpoimboe@redhat.com>:
> NMI stack dumps are bracked by the following tags:
>
>   <NMI>
>   ...
>   <EOE>
>
> The ending tag is kind of confusing if you don't already know what "EOE"
> means (end of exception).  The same ending tag is also used to mark the
> end of all other exceptions' stacks.  For example:
>
>   <#DF>
>   ...
>   <EOE>
>
> And similarly, "EOI" is used as the ending tag for interrupts:
>
>   <IRQ>
>   ...
>   <EOI>
>
> Change the tags to be more comprehensible by making them symmetrical and
> more XML-esque:
>
>   <NMI>
>   ...
>   </NMI>
>
>   <#DF>
>   ...
>   </#DF>
>
>   <IRQ>
>   ...
>   </IRQ>
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>

I like that! I hope not too many tools rely on the old namings.
But dmesg isn't supposed to be a stable ABI anyway.

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>

  parent reply	other threads:[~2016-11-19 15:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 17:46 [PATCH] x86/dumpstack: make stack name tags more comprehensible Josh Poimboeuf
2016-11-18 18:54 ` Peter Zijlstra
2016-11-19 15:49 ` Frederic Weisbecker [this message]
2016-11-19 20:25 ` Josh Poimboeuf
2016-11-21 10:38 ` [tip:x86/asm] x86/dumpstack: Make " tip-bot for Josh Poimboeuf
2016-11-21 12:07 ` tip-bot for Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFTL4hwet4+rm+y=EX=K1G+x7G+qk0+un8X4K2dJ3QBTeNbttw@mail.gmail.com' \
    --to=fweisbec@gmail.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.