Re: [PATCH] perf/hwbp: Fix cleanup in case of kzalloc failure

From: Frederic Weisbecker <fweisbec@gmail.com>
To: Daniel Baluta <dbaluta@ixiacom.com>, Ingo Molnar <mingo@kernel.org>
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
	acme@ghostprotocols.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/hwbp: Fix cleanup in case of kzalloc failure
Date: Wed, 6 Feb 2013 23:58:46 +0100	[thread overview]
Message-ID: <CAFTL4hy=hv_ey-_2gMKtW=pd7r+X6PP5cQ6_sHzsLUYqeFV5Tg@mail.gmail.com> (raw)
In-Reply-To: <1360186160-7566-1-git-send-email-dbaluta@ixiacom.com>

2013/2/6 Daniel Baluta <dbaluta@ixiacom.com>:
> Obviously this is a typo and could result in memory leaks
> if kzalloc fails on a given cpu.
>
> Signed-off-by: Daniel Baluta <dbaluta@ixiacom.com>

Good catch!

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>

> ---
>  kernel/events/hw_breakpoint.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
> index fe8a916..a64f8ae 100644
> --- a/kernel/events/hw_breakpoint.c
> +++ b/kernel/events/hw_breakpoint.c
> @@ -676,7 +676,7 @@ int __init init_hw_breakpoint(void)
>   err_alloc:
>         for_each_possible_cpu(err_cpu) {
>                 for (i = 0; i < TYPE_MAX; i++)
> -                       kfree(per_cpu(nr_task_bp_pinned[i], cpu));
> +                       kfree(per_cpu(nr_task_bp_pinned[i], err_cpu));
>                 if (err_cpu == cpu)
>                         break;
>         }
> --
> 1.7.5.4
>