From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE10C282E1 for ; Tue, 23 Apr 2019 16:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28F6420811 for ; Tue, 23 Apr 2019 16:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=posk.io header.i=@posk.io header.b="AXmNb13Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728535AbfDWQJt (ORCPT ); Tue, 23 Apr 2019 12:09:49 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33701 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727666AbfDWQJt (ORCPT ); Tue, 23 Apr 2019 12:09:49 -0400 Received: by mail-ed1-f67.google.com with SMTP id d55so13153307ede.0 for ; Tue, 23 Apr 2019 09:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=posk.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l9OgPB7GfvTURwsZvHFK2TBjlK0Wpy0TgDJFUhVI3nw=; b=AXmNb13YMmTFqzZRFco06EB7460X2BgezkmrPqnLE1AWaV8wYTSCf0eiBZgTMJ91bV DJytUJF2VNqYxT+SilsojFUjBkG5oUpFMxYdr7mGz+JXenAqKmOCFplje8xLpCBl8iXA Qci4HVPJDtlyvhmWy+SlY9gLzhP/3rrx7wv9bFc9S+UxmtmLrJztlC6OzATruXOGikj0 l20K3ipiWZa8Q8DY+Wx/JMGou7Nzn3Uy/qX5goaodCYIx7VhC8MhtJQ11Lozm43JVPgJ G7opOhvQPjePjFy2qefcH4zbIVx+BgDB5EDHAO7dei1Jv+ZK3EsvXgdbFSiwiT2f4Qgr XsFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l9OgPB7GfvTURwsZvHFK2TBjlK0Wpy0TgDJFUhVI3nw=; b=szV3Y5c8DvVC078KkyR1NHx/MTwVcuJLtzq30WYVTqVYDdrBs4QYOdgXAt2fREXcgD GwmkCLRKDi7DAMbmsVVbV473gsrwujm6ySuqfXovMpCP5l0FmXp/TwiWlQear5NRUSq4 Vpkw7VA86jlRQ6kis3qmICf2L0yCxHU0R8DJHKbxtIjWqIb0txRCna3ryMWuR6YI44vN bZTxpdiCTOGoywWZAu19cfjT7l2FZBxBNVIMjXYknEeFOhJR7X3DRPjAfqxG/0+O6uke LHv92RWpxDmOqSlBpc09r6MiEvGSwAp8LHVR9vUfxG0uBpa6lzOc2vIM0xhVkQ7C/lvk CoBQ== X-Gm-Message-State: APjAAAVNSDGtOx46tXWxfgraywgcG43igJQX8H1B1NAA4DhwivjugU1X VVb7v1axeC5Gs+c0EkINJlD3wrfFkR9gEhIjdXbb3Q== X-Google-Smtp-Source: APXvYqwLj3idfGCWn+e23+1mqBxjniBjAPqZjrpP54jk/SYi3oI+th/kPFB0xFyF4IDXq5EK6q63ub55enCIF9h98eI= X-Received: by 2002:a50:f613:: with SMTP id c19mr8713081edn.193.1556035787391; Tue, 23 Apr 2019 09:09:47 -0700 (PDT) MIME-Version: 1.0 References: <20190422222930.195053-1-posk@google.com> <20190422222930.195053-3-posk@google.com> In-Reply-To: From: Peter Oskolkov Date: Tue, 23 Apr 2019 09:09:36 -0700 Message-ID: Subject: Re: [PATCH 4.14 stable 2/5] net: IP defrag: encapsulate rbtree defrag code into callable functions To: Lars Persson Cc: Peter Oskolkov , Greg Kroah-Hartman , stable@vger.kernel.org, linux-netdev , David Miller , Eric Dumazet , Sasha Levin , Captain Wiggum , Florian Westphal , Tom Herbert Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 23, 2019 at 5:07 AM Lars Persson wrote: > > On Tue, Apr 23, 2019 at 12:29 AM Peter Oskolkov wrote: > > > > [ Upstream commit c23f35d19db3b36ffb9e04b08f1d91565d15f84f ] > > > > This is a refactoring patch: without changing runtime behavior, > > it moves rbtree-related code from IPv4-specific files/functions > > into .h/.c defrag files shared with IPv6 defragmentation code. > > > > Signed-off-by: Peter Oskolkov > > Cc: Eric Dumazet > > Cc: Florian Westphal > > Cc: Tom Herbert > > Signed-off-by: David S. Miller > > --- > > include/net/inet_frag.h | 16 ++- > > net/ipv4/inet_fragment.c | 293 +++++++++++++++++++++++++++++++++++++++ > > net/ipv4/ip_fragment.c | 290 ++++---------------------------------- > > 3 files changed, 335 insertions(+), 264 deletions(-) > > > Hi > > We get a compile error with gcc 8.2 after applying this patch: > net/ipv4/ip_fragment.c: In function 'ip_frag_queue': > net/ipv4/ip_fragment.c:390:1: error: label 'discard_qp' defined but > not used [-Werror=unused-label] > discard_qp: Thanks for the report: I'll send a v2.