From: Noah Goldstein <goldstein.w.n@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: tglx@linutronix.de, mingo@redhat.com,
Borislav Petkov <bp@alien8.de>,
dave.hansen@linux.intel.com, X86 ML <x86@kernel.org>,
hpa@zytor.com, peterz@infradead.org, alexanderduyck@fb.com,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] x86/lib: Optimize 8x loop and memory clobbers in csum_partial.c
Date: Fri, 26 Nov 2021 18:39:52 -0600 [thread overview]
Message-ID: <CAFUsyfLV2Jws3QywyPsePuHSRb2sMiR99z1ohJqVVjs91C0VcQ@mail.gmail.com> (raw)
In-Reply-To: <CANn89iJb_2666U4qgrqsjqEyT9_rA9SKRThbdy_--4_X8rFMYg@mail.gmail.com>
On Fri, Nov 26, 2021 at 6:15 PM Eric Dumazet <edumazet@google.com> wrote:
>
> On Fri, Nov 26, 2021 at 12:33 PM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> >
> > On Fri, Nov 26, 2021 at 2:07 PM Eric Dumazet <edumazet@google.com> wrote:
> > >
> > > On Fri, Nov 26, 2021 at 11:50 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote:
> > > >
> > > > Bright :) but it will need a BMI support check.
> > >
> > > Yes, probably not worth the pain.
> >
> > Making a V2 for my patch with your optimization for the loop case. Do you think
> > 1 or 2 accum for the 32 byte case?
> >
>
> I would vote for something simpler, thus one accum, since this 32byte
> block is only run one time ?
If the one at a time performance is whats the most important wouldn't that
argue in favor of 2x accum because it lead to decreased latency? Or are you
saying it's not that important so simpler codes is the priority?
>
> Thanks !
next prev parent reply other threads:[~2021-11-27 0:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 19:38 [PATCH v1] x86/lib: Optimize 8x loop and memory clobbers in csum_partial.c Noah Goldstein
2021-11-26 1:50 ` Eric Dumazet
2021-11-26 2:15 ` Noah Goldstein
2021-11-26 2:18 ` Noah Goldstein
2021-11-26 2:38 ` Noah Goldstein
2021-11-28 19:47 ` David Laight
2021-11-28 20:59 ` Noah Goldstein
2021-11-28 22:41 ` David Laight
2021-12-02 14:24 ` David Laight
2021-12-02 15:01 ` Eric Dumazet
2021-12-02 20:19 ` Noah Goldstein
2021-12-02 21:11 ` David Laight
2021-11-26 16:08 ` Eric Dumazet
2021-11-26 18:17 ` Noah Goldstein
2021-11-26 18:27 ` Eric Dumazet
2021-11-26 18:50 ` Noah Goldstein
2021-11-26 19:14 ` Noah Goldstein
2021-11-26 19:21 ` Eric Dumazet
2021-11-26 19:50 ` Noah Goldstein
2021-11-26 20:07 ` Eric Dumazet
2021-11-26 20:33 ` Noah Goldstein
2021-11-27 0:15 ` Eric Dumazet
2021-11-27 0:39 ` Noah Goldstein [this message]
2021-11-26 18:17 ` Eric Dumazet
2021-11-27 4:25 ` [PATCH v2] " Noah Goldstein
2021-11-27 6:03 ` Eric Dumazet
2021-11-27 6:38 ` Noah Goldstein
2021-11-27 6:39 ` [PATCH v3] " Noah Goldstein
2021-11-27 6:51 ` Eric Dumazet
2021-11-27 7:18 ` Noah Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFUsyfLV2Jws3QywyPsePuHSRb2sMiR99z1ohJqVVjs91C0VcQ@mail.gmail.com \
--to=goldstein.w.n@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=edumazet@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.