From: Lars Hjemli <hjemli@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] all: new command used for multi-repo operations
Date: Wed, 23 Jan 2013 19:29:08 +0100 [thread overview]
Message-ID: <CAFXTnz7r79JYXQBBcpiOPtUzeafuN3fa82F5rGXd-Hr7tSAEOw@mail.gmail.com> (raw)
In-Reply-To: <7vwqv3hlu7.fsf@alter.siamese.dyndns.org>
On Wed, Jan 23, 2013 at 6:04 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> But I still do not think this loop is correct. In a repository that
>> has a working tree, you would learn that directory $D has $D/.git in
>> it, feed $D to handle_repo(), and then descend into $D/.git/objects/,
>> $D/.git/refs, and other random directories to see if you can find
>> other repositories....
>
> Ahh, no, you don't.
>
> I still think calling is_git_directory() on $D + "/.git" would be a
> better implementation, though.
Except for the .gitfile case, which is_git_directory() doesn't seem to
handle. I guess I can invoke read_gitfile() when i see that .git is a
file.
--
larsh
next prev parent reply other threads:[~2013-01-23 18:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 8:12 [PATCH v2] all: new command used for multi-repo operations Lars Hjemli
2013-01-23 8:55 ` Duy Nguyen
2013-01-23 9:24 ` Lars Hjemli
2013-01-23 10:15 ` Duy Nguyen
2013-01-23 20:17 ` Jens Lehmann
2013-01-23 16:52 ` Junio C Hamano
2013-01-23 17:04 ` Junio C Hamano
2013-01-23 18:29 ` Lars Hjemli [this message]
2013-01-23 18:19 ` Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFXTnz7r79JYXQBBcpiOPtUzeafuN3fa82F5rGXd-Hr7tSAEOw@mail.gmail.com \
--to=hjemli@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.