From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C431C433DF for ; Sun, 16 Aug 2020 20:18:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFDAB2078D for ; Sun, 16 Aug 2020 20:18:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hw1Tumy/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729858AbgHPUSG (ORCPT ); Sun, 16 Aug 2020 16:18:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728758AbgHPUSG (ORCPT ); Sun, 16 Aug 2020 16:18:06 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87101C061786 for ; Sun, 16 Aug 2020 13:18:05 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id d2so7334046lfj.1 for ; Sun, 16 Aug 2020 13:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tgQ/GmB3zrnGwyYvWKuLlUsZewAGc12JmhUW7ePwuRk=; b=hw1Tumy/txCSrpbVbJ+RnSqI+LqEWaEjQV1vJyZIAYMgQhaRzJNhItyhNG+eirkCxm gJ+qHxsQ8PSIiLPCmsIzOjPluEbI/q4PUGn4OxMacIoEkSScBIaZuDl2PhyWDA7EsoLv FSkMBF6pB2zwrJLE4SCbZbk3rZeyJ5zH/6e3cBadP90yT7pdwwgYvV/tZNavEAouEmxy p0t1PZflk1tcFwQjZUl0LzwCjxvBQoiKEOooEKTyFPjF9cSVTu0JcieViyrWZ8jeqhjS p662CxMsuU0ZfdOdocfSvsKHnkauIvoT3Rb5854NVxK6LyWsWFQjagGOmYxUKRr+k7jd poVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tgQ/GmB3zrnGwyYvWKuLlUsZewAGc12JmhUW7ePwuRk=; b=UsphfHHEn+sA1vxp+IisT6LXtxcBcllSMUd+zhd5+T6a1fQM4Mv/TUFjGfyOGl8Yfk lMV35qM6paNbm9o/zpRhxRMHqmTA6VjuCOqiniPBE7EeDt3Wg55SH80Q1dhhNxTqPz5z 3hf/ZumVwxxL1oH3bK5oBp5LQkD0wiBVTwY/+xZ7Xndi1ayJ9iyezxZf8iKErPpYwWsW +K9su2v2w+0Yn7EGRHG2eeRsmQEsugmyekXbNVoGz1UKYiustNJLQG/GhU/jmrqGicpl m2fPhc2rSh1SLvv8FK/1DuFk0J+6D7Dfe78As0MkCYRM8/1yVD+INgJr1+JnfVnLDQ9C EUZw== X-Gm-Message-State: AOAM533NnohOTO7yH+tod8DVlcVSKdebY5remyuXBI7LZ2QvVRDB4hGZ KnhyvyijfDgS5m9SjNHilYJS9A5Dp/eXIwPMcDxbwNux X-Google-Smtp-Source: ABdhPJxlhL0kDiwJgSAmI5UmETaeP7MeovvmgIftZdNoIZbK9vPvafAo7q2vk+PENEIke3rFuu+sbQ3rKrP/28r5Q80= X-Received: by 2002:a19:bcc:: with SMTP id 195mr5916583lfl.160.1597609083812; Sun, 16 Aug 2020 13:18:03 -0700 (PDT) MIME-Version: 1.0 References: <20200816194316.2291489-1-andrew@lunn.ch> In-Reply-To: <20200816194316.2291489-1-andrew@lunn.ch> From: Chris Healy Date: Sun, 16 Aug 2020 13:17:52 -0700 Message-ID: Subject: Re: [PATCH net-next 0/7] net: dsa: mv88e6xxx: Add devlink regions support To: Andrew Lunn Cc: David Miller , netdev , Vivien Didelot Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I tested this on the Rev C Zii Vybrid Dev Board which has two Marvell 88E6390X switches. Both switches worth of port, global, and atu data show up when running the devlink show command and for each of the regions, I can dump the contents. I also tested on a different platform with a single 88E6352. Full series is: Tested-by: Chris Healy On Sun, Aug 16, 2020 at 12:44 PM Andrew Lunn wrote: > > Make use of devlink regions to allow read access to some of the > internal of the switches. The switch itself will never trigger a > region snapshot, it is assumed it is performed from user space as > needed. > > Andrew Lunn (7): > net: dsa: Add helper to convert from devlink to ds > net: dsa: Add devlink regions support to DSA > net: dsa: mv88e6xxx: Move devlink code into its own file > net: dsa: mv88e6xxx: Create helper for FIDs in use > net: dsa: mv88e6xxx: Add devlink regions > net: dsa: wire up devlink info get > net: dsa: mv88e6xxx: Implement devlink info get callback > > drivers/net/dsa/mv88e6xxx/Makefile | 1 + > drivers/net/dsa/mv88e6xxx/chip.c | 290 ++---------- > drivers/net/dsa/mv88e6xxx/chip.h | 14 + > drivers/net/dsa/mv88e6xxx/devlink.c | 690 ++++++++++++++++++++++++++++ > drivers/net/dsa/mv88e6xxx/devlink.h | 21 + > include/net/dsa.h | 13 +- > net/dsa/dsa.c | 36 +- > net/dsa/dsa2.c | 21 +- > 8 files changed, 813 insertions(+), 273 deletions(-) > create mode 100644 drivers/net/dsa/mv88e6xxx/devlink.c > create mode 100644 drivers/net/dsa/mv88e6xxx/devlink.h > > -- > 2.28.0 >