From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ravi Kerur Subject: Re: [PATCH 4/7] Move EAL common functions Date: Mon, 5 Jan 2015 08:21:49 -0800 Message-ID: References: <1419521597-31978-1-git-send-email-rkerur@gmail.com> <1419521597-31978-5-git-send-email-rkerur@gmail.com> <20293089.lIc3yRvdMZ@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: "dev-VfR2kkLFssw@public.gmane.org" To: Thomas Monjalon Return-path: In-Reply-To: <20293089.lIc3yRvdMZ@xps13> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Thanks Thomas for the reviews, do you want me to send "v4" version of this patch series or start a different patch series? Thanks, Ravi On Mon, Jan 5, 2015 at 7:59 AM, Thomas Monjalon wrote: > 2014-12-25 10:33, Ravi Kerur: > > Move common functions in eal.c to librte_eal/common directory. > [...] > > lib/librte_eal/common/eal_common.c | 328 > ++++++++++++++++++++++++++++++++++ > > lib/librte_eal/common/eal_externs.h | 42 +++++ > > I don't agree with these new files. > We must try to keep a semantic organization. The file eal_common_options.c > would be better for option-related functions. > Maybe that the split between system config, runtime config and internal > config > must be reworked. > > By the way, it would be nice to avoid extern variables. > > -- > Thomas >