All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Thomas Monjalon
	<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH v5 2/8] Move common functions in eal.c
Date: Thu, 16 Apr 2015 15:22:34 -0700	[thread overview]
Message-ID: <CAFb4SLD_fkJh8FMAdzxRL=CETy-uDHpqB133WFjd_Urr20=x=A@mail.gmail.com> (raw)
In-Reply-To: <CAFb4SLCt6HAnL7tb7HJB2HBvHPoMghkv-e-pCiK_EyjYB_p9ew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Thomas, Thanks for the review so far, I will make necessary changes and
send out v6.

Thanks, Ravi

On Thu, Apr 16, 2015 at 3:08 PM, Ravi Kerur <rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

>
>
> On Thu, Apr 16, 2015 at 1:24 AM, Thomas Monjalon <
> thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> wrote:
>
>> Hi Ravi,
>>
>> I think this patch is too complex and move too many different things:
>> - sysfs
>> - mem_cfg
>> - proc_type
>> - application_usage
>> Please split them up.
>>
>> I'm not sure the classification in eal_common_runtime.c and
>> eal_common_system.c
>> new file is clear.
>>
>
> I chose most system related functions (hugepages, lcore sockets, sysfs)
> into eal_common_system.c file. Rest I moved them to eal_common_runtime.c
> file for lack of better name. You want more fine grained control and divide
> them into 4 files??
>
>>
>> 2015-04-09 12:40, Ravi Kerur:
>> > +     mem_config = (struct rte_mem_config *) mmap(NULL,
>> sizeof(*mem_config),
>>
>> Why this cast is needed?
>>
>
> Linux has it, BSD doesn't. I just chose Linux version.
>
>

  parent reply	other threads:[~2015-04-16 22:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 19:38 [PATCH v5 0/8] Move common functions in EAL Ravi Kerur
     [not found] ` <1428608301-31033-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-09 19:40   ` Ravi Kerur
     [not found]     ` <1428608412-31191-1-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-09 19:40       ` [PATCH v5 1/8] Move common functions in eal_thread.c Ravi Kerur
     [not found]         ` <1428608412-31191-2-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-14 13:59           ` Thomas Monjalon
2015-04-14 21:35             ` Ravi Kerur
     [not found]               ` <CAFb4SLBUrSviEu3+f-vv3j4OktjodM5Dy0AUbxrpa2QtxpAVWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-16 22:19                 ` Ravi Kerur
2015-04-09 19:40       ` [PATCH v5 2/8] Move common functions in eal.c Ravi Kerur
     [not found]         ` <1428608412-31191-3-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-16  8:24           ` Thomas Monjalon
2015-04-16 22:08             ` Ravi Kerur
     [not found]               ` <CAFb4SLCt6HAnL7tb7HJB2HBvHPoMghkv-e-pCiK_EyjYB_p9ew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-16 22:22                 ` Ravi Kerur [this message]
2015-04-09 19:40       ` [PATCH v5 3/8] Move common functions in eal_lcore.c Ravi Kerur
     [not found]         ` <1428608412-31191-4-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-16  8:39           ` Thomas Monjalon
2015-04-16 22:10             ` Ravi Kerur
2015-04-09 19:40       ` [PATCH v5 4/8] Move common functions in eal_timer.c Ravi Kerur
     [not found]         ` <1428608412-31191-5-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-16  8:46           ` Thomas Monjalon
2015-04-16 22:11             ` Ravi Kerur
2015-04-09 19:40       ` [PATCH v5 5/8] Move common functions in eal_memory.c Ravi Kerur
     [not found]         ` <1428608412-31191-6-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-16  8:52           ` Thomas Monjalon
2015-04-16 22:11             ` Ravi Kerur
2015-04-09 19:40       ` [PATCH v5 6/8] Move common functions in eal_pci.c Ravi Kerur
     [not found]         ` <1428608412-31191-7-git-send-email-rkerur-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-16  9:02           ` Thomas Monjalon
2015-04-16 22:12             ` Ravi Kerur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFb4SLD_fkJh8FMAdzxRL=CETy-uDHpqB133WFjd_Urr20=x=A@mail.gmail.com' \
    --to=rkerur-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.