From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 284BBC433EF for ; Tue, 4 Jan 2022 07:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232140AbiADH4j (ORCPT ); Tue, 4 Jan 2022 02:56:39 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:34397 "EHLO mail-pf1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232016AbiADH4j (ORCPT ); Tue, 4 Jan 2022 02:56:39 -0500 Received: by mail-pf1-f174.google.com with SMTP id c2so31543020pfc.1 for ; Mon, 03 Jan 2022 23:56:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k5yr3AtuD8K4pTVC0bU9zhjFIm+jZFJwQDj+V0I/7XU=; b=YvbZaGmZCoMoFaq0PMnpZvzP3rhdD5wLTYg5E7TXril+v4OYVRr+sYBRIa8Ky5Vu/j lA2537nlyj6NftVsJI4RzpGxSAOHM81EGshkRZ4db7dYWarHW1JbBxoUMucRdxMM5GIk ylKNF+t8sNynkXLcKbHDyUPxCDEigifhkZLVjFPv3GRH0mp1UywRZugmOniH0jmDIz6x WlRpL2Q6RFbBfuXzXupK2VjQ/vCc4TBkCEvYG5QFeltR++aLKCnrRyrQ1h3kIkVPrBFg FbydqBFckr228vW5vCj5sdFKhIilw+9Wa7JgyeHQdqbMInnwz7bhQL7pr+NKEtWJSB+G 8Uog== X-Gm-Message-State: AOAM533rMbHNAIwpx0nded6/YGgLJigjkRc0N7Vj822k2URvbLbkqLPi dwNWOH4GbNreRy5p2TiH7nfDYP8FJWiXxxtvduqUUPIT8Hc= X-Google-Smtp-Source: ABdhPJzliGwRtRWEHZo1cYG12T+zI+2TUN07TYx0MRPmu3TxQE6EYTrioYv1dPdatOcrYUXYWNz8AHNz6s8o3zJHIG0= X-Received: by 2002:a63:5f84:: with SMTP id t126mr42933525pgb.553.1641282998891; Mon, 03 Jan 2022 23:56:38 -0800 (PST) MIME-Version: 1.0 References: <20211216071513.6d1e0f55@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: From: Harini Katakam Date: Tue, 4 Jan 2022 13:26:28 +0530 Message-ID: Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs To: "Russell King (Oracle)" Cc: Jakub Kicinski , Michal Simek , Radhey Shyam Pandey , Sean Anderson , "David S. Miller" , netdev , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam wrote: > > Hi Russell, > > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle) > wrote: > > > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > > Convert axienet to use the phylink_pcs layer, resulting in it no longer > > > > being a legacy driver. > > > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether > > > > we support switching between SGMII and 1000baseX. However, when clear, > > > > this also blocks updating the 1000baseX advertisement, which it > > > > probably should not be doing. Nevertheless, this behaviour is preserved > > > > but a comment is added. > > > > > > > > Signed-off-by: Russell King (Oracle) > > > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local' > > > > Fixed that and the sha1 issue you raised in patch 2. Since both are > > "documentation" issues, I won't send out replacement patches until > > I've heard they've been tested on hardware though. > > Thanks for the patches. > Series looks good and we're testing at our end; will get back to you > early next week. Thanks Russell. I've tested AXI Ethernet and it works fine. Regards, Harini From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78222C433F5 for ; Tue, 4 Jan 2022 07:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/GLg3ichh5KQt4Zl/a9+YlPFPnX3HnBBXpa6Lhgj4TQ=; b=N/0mlpDWYkssBr 57+55kb5sq8W0WxeJY9rJdeulzmsk59+SgwhJ0L2Tw+G8/Eg53m3i/2P49IWDk1bJewUf+6bCJDTI JylASyI/5L4M4p++KGu/fP+o5Z2GWN92CJVzHX6BBdSgOeHErekWjfhGgxWANxQJT8EacqNk2FgY/ o1Wi/kic/gb62j6woB6Q59lFCelmkPB8tilrt+1yk35qNuHVVy8ngDHAkxuflCj2/b9Ski7XvNm2u Jgdq7Cg0P3L0doo568cGogK0KZpUGhNq7YitX/yAEo9JhTAPihlBjUlY2I5d+601QifmE8eOHHwz8 wYEXoSEE6Scm+HElNaHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4egW-00AZjK-0m; Tue, 04 Jan 2022 07:56:44 +0000 Received: from mail-pf1-f182.google.com ([209.85.210.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4egS-00AZiY-9o for linux-arm-kernel@lists.infradead.org; Tue, 04 Jan 2022 07:56:41 +0000 Received: by mail-pf1-f182.google.com with SMTP id b22so31528837pfb.5 for ; Mon, 03 Jan 2022 23:56:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k5yr3AtuD8K4pTVC0bU9zhjFIm+jZFJwQDj+V0I/7XU=; b=c9aPPArRgviFQxPhFnu/ZvhTjRTMAi/S3aPUQPUofTs443jeJa42pQ1GSPGJ0KGcRa wznNP0M7YTInwrP25zj7SUZajPeiyeWuySzEGSr7psVp0+IlCHJHBpjMfmRVbhEmyKYb eqP3cQMsnlCkdEkKy/j3zJzqIM35VxLTGisHb1hryWNAesbkjbiAP/ddlDGQWcZHBw4K 1noZbUq1b/CFdTIyZO8UJsODbyRjXE71qHdSLjPzNPamA8QFNUYTlxPYHyt4eAS2q/ok 5vkZzDAl7PIRBoPTvtEhBlRs4L5TgSVqTbBtAeSRLFHLp/Czuww/VLiAPMogghAI9N/d b/Aw== X-Gm-Message-State: AOAM530xUtWKC4sfccZMd14LW+zzA0HZSQS73oqmeFgfyJBx1YfAjC4L daRVynsh3pfFot19eR3jYhYQ5xop1W5G+JGV8Mo= X-Google-Smtp-Source: ABdhPJzliGwRtRWEHZo1cYG12T+zI+2TUN07TYx0MRPmu3TxQE6EYTrioYv1dPdatOcrYUXYWNz8AHNz6s8o3zJHIG0= X-Received: by 2002:a63:5f84:: with SMTP id t126mr42933525pgb.553.1641282998891; Mon, 03 Jan 2022 23:56:38 -0800 (PST) MIME-Version: 1.0 References: <20211216071513.6d1e0f55@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: From: Harini Katakam Date: Tue, 4 Jan 2022 13:26:28 +0530 Message-ID: Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs To: "Russell King (Oracle)" Cc: Jakub Kicinski , Michal Simek , Radhey Shyam Pandey , Sean Anderson , "David S. Miller" , netdev , linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220103_235640_364847_5E590FE0 X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam wrote: > > Hi Russell, > > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle) > wrote: > > > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote: > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote: > > > > Convert axienet to use the phylink_pcs layer, resulting in it no longer > > > > being a legacy driver. > > > > > > > > One oddity in this driver is that lp->switch_x_sgmii controls whether > > > > we support switching between SGMII and 1000baseX. However, when clear, > > > > this also blocks updating the 1000baseX advertisement, which it > > > > probably should not be doing. Nevertheless, this behaviour is preserved > > > > but a comment is added. > > > > > > > > Signed-off-by: Russell King (Oracle) > > > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function parameter or member 'pcs' not described in 'axienet_local' > > > > Fixed that and the sha1 issue you raised in patch 2. Since both are > > "documentation" issues, I won't send out replacement patches until > > I've heard they've been tested on hardware though. > > Thanks for the patches. > Series looks good and we're testing at our end; will get back to you > early next week. Thanks Russell. I've tested AXI Ethernet and it works fine. Regards, Harini _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel