From: Nayan Deshmukh <nayan26deshmukh@gmail.com>
To: yamada.masahiro@socionext.com
Cc: airlied@linux.ie, "Alex Deucher" <alexander.deucher@amd.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag
Date: Mon, 30 Jul 2018 18:19:36 +0530 [thread overview]
Message-ID: <CAFd4ddxsBsg0gKwW3iCidFRSC+p0VaQFQb=GyAZrgoVVGnDscg@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNAS_XrYKuv7OgTEt9RSGLbCe-XumV4QNKUtS2YT9HWMk3Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1389 bytes --]
On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada <
yamada.masahiro@socionext.com> wrote:
> Hi.
>
> 2018-07-06 14:12 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com
> >:
> > I refactored the include directives under include/drm/ some time ago.
> > This flag is unneeded.
> >
>
A minor nit-pick in the commit message, something like "With the refactored
include directives under include/drm, this flag is uneeded." might be
better.
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
With or without that the patch is Acked-by: Nayan Deshmukh <
nayan26deshmukh@gmail.com>
Regards,
Nayan Deshmukh
>
> Ping?
>
>
> > ---
> >
> > drivers/gpu/drm/scheduler/Makefile | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/scheduler/Makefile
> b/drivers/gpu/drm/scheduler/Makefile
> > index bd0377c..7665883 100644
> > --- a/drivers/gpu/drm/scheduler/Makefile
> > +++ b/drivers/gpu/drm/scheduler/Makefile
> > @@ -20,7 +20,6 @@
> > # OTHER DEALINGS IN THE SOFTWARE.
> > #
> > #
> > -ccflags-y := -Iinclude/drm
> > gpu-sched-y := gpu_scheduler.o sched_fence.o
> >
> > obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> > --
> > 2.7.4
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
[-- Attachment #1.2: Type: text/html, Size: 2542 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-30 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 5:12 [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag Masahiro Yamada
2018-07-28 2:43 ` Masahiro Yamada
2018-07-30 12:49 ` Nayan Deshmukh [this message]
2018-07-30 13:09 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFd4ddxsBsg0gKwW3iCidFRSC+p0VaQFQb=GyAZrgoVVGnDscg@mail.gmail.com' \
--to=nayan26deshmukh@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.