From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Higgins Subject: Re: [PATCH v2 07/17] kunit: test: add initial tests Date: Thu, 2 May 2019 22:18:22 -0700 Message-ID: References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: shuah Cc: Petr Mladek , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Amir Goldstein , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frank Rowand , Rob Herring , linux-nvdimm , Kevin Hilman , Knut Omang , Kieran Bingham , wfg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Bird, Timothy" , linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Steven Rostedt , Julia Lawall , skhan@linuxfo List-Id: linux-nvdimm@lists.01.org On Thu, May 2, 2019 at 6:27 PM shuah wrote: > > On 5/1/19 5:01 PM, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > Please add a bit more information on what this config option > does. Why should user care to enable it? > > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > + > > Same here. Sounds reasonable. Will fix in the next revision. < snip > Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25527C43219 for ; Fri, 3 May 2019 05:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E19702087F for ; Fri, 3 May 2019 05:18:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vMgoD4BZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726466AbfECFSg (ORCPT ); Fri, 3 May 2019 01:18:36 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:45774 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726387AbfECFSf (ORCPT ); Fri, 3 May 2019 01:18:35 -0400 Received: by mail-ot1-f67.google.com with SMTP id a10so4233719otl.12 for ; Thu, 02 May 2019 22:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TcYMhvle0qn3Vbr1jw5wZlfwobq39YCNyqpLb7cb7Ao=; b=vMgoD4BZW5GJfaQp5wHB4n5Uh0dHYfDvtMT6no12+p0edzsKljaBNtH2QSDc0E6VzT LcuVJrv7cdGqX7U8FfKi5bagOC/nhHdsiKYsGPft1mReUq108TVFisXe9TJrijP3ncN9 v39q83CXeT5lkt4WLd/fwqU8g5riscYutv4Dl0z3LH4QLnkrqcMdMPzrzbEAqplHU0Uu m3PA8EGRjwXV1jBeELzeCCKDGehqdroKwQf1lX98y7iQ89oh7pPsirzbD3JpTdCcD6Pl 9jznQM6AV2RqS1bTQE7nMwTk67da6P41iEI1afzG3TYud6oBdVc8/EIcpi2ctCF9A2Zz QXpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TcYMhvle0qn3Vbr1jw5wZlfwobq39YCNyqpLb7cb7Ao=; b=D7uMTk3soht4NpfXgOCXrkP1ZdsQDNDkydGQwIvirSjevE/DZx46gWseax2m9g4C1y kj7RBZhZWnDuluQLTi+SuQ3I9lVmXs2aTKHgyv2RgXRqbh/zaTKs/Jh4AJfQLwiABXqd ptmUiK3QeQ9YabAPNQ+yFv/q7hsRngSlgXU7RZBukCW3L3Adn8E2QdVnjg4BiZxt+uct q2tfZ3XiEa94VZidLsb0mqTdDsmroTs6Zra9g/bDVQAEjXWvJfscex/BQrslu+ZSljJ+ XKTHvhvjqVdYScXgAQjmEKyh1FvvnNDIeZsPPKS+ielibq3wG1w0FfPJNv91946ATbwU iquA== X-Gm-Message-State: APjAAAVsrCnHIPSsXWsCmkXXWA7Eg/DnVHI8GkfyLaffLUkdd1gHx9XR oIjwO5XarDthyF6YrPvgglxc+d8H1HM7VPSBQetsrw== X-Google-Smtp-Source: APXvYqyA2rSR/zhocpuvfAEjnR+/hEY11wb5Z34WyJg2tb2IGWD/sjsI629/w4anWfW9OX32ft4Cf8TKrI7DL3H8Uik= X-Received: by 2002:a05:6830:204a:: with SMTP id f10mr4960513otp.83.1556860714114; Thu, 02 May 2019 22:18:34 -0700 (PDT) MIME-Version: 1.0 References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> In-Reply-To: From: Brendan Higgins Date: Thu, 2 May 2019 22:18:22 -0700 Message-ID: Subject: Re: [PATCH v2 07/17] kunit: test: add initial tests To: shuah Cc: Frank Rowand , Greg KH , Kees Cook , Kieran Bingham , Luis Chamberlain , Rob Herring , Stephen Boyd , devicetree , dri-devel , kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Dan Williams , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 2, 2019 at 6:27 PM shuah wrote: > > On 5/1/19 5:01 PM, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > Please add a bit more information on what this config option > does. Why should user care to enable it? > > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > + > > Same here. Sounds reasonable. Will fix in the next revision. < snip > Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: brendanhiggins at google.com (Brendan Higgins) Date: Thu, 2 May 2019 22:18:22 -0700 Subject: [PATCH v2 07/17] kunit: test: add initial tests In-Reply-To: References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> Message-ID: On Thu, May 2, 2019 at 6:27 PM shuah wrote: > > On 5/1/19 5:01 PM, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > Please add a bit more information on what this config option > does. Why should user care to enable it? > > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > + > > Same here. Sounds reasonable. Will fix in the next revision. < snip > Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 From: brendanhiggins@google.com (Brendan Higgins) Date: Thu, 2 May 2019 22:18:22 -0700 Subject: [PATCH v2 07/17] kunit: test: add initial tests In-Reply-To: References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190503051822.5pNfHRPM8HFmbWD1ZP72sSNKrL6wV9BW5DCd-kTeNdY@z> On Thu, May 2, 2019@6:27 PM shuah wrote: > > On 5/1/19 5:01 PM, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > Please add a bit more information on what this config option > does. Why should user care to enable it? > > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > + > > Same here. Sounds reasonable. Will fix in the next revision. < snip > Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMQah-0005jR-QY for linux-um@lists.infradead.org; Fri, 03 May 2019 05:18:37 +0000 Received: by mail-ot1-x342.google.com with SMTP id e108so4244427ote.10 for ; Thu, 02 May 2019 22:18:35 -0700 (PDT) MIME-Version: 1.0 References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> In-Reply-To: From: Brendan Higgins Date: Thu, 2 May 2019 22:18:22 -0700 Message-ID: Subject: Re: [PATCH v2 07/17] kunit: test: add initial tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: shuah Cc: Petr Mladek , linux-doc@vger.kernel.org, Amir Goldstein , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest@vger.kernel.org, Frank Rowand , Rob Herring , linux-nvdimm , Kevin Hilman , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild@vger.kernel.org, "Bird, Timothy , linux-um@lists.infradead.org, Steven Rostedt" , Julia Lawall , skhan@linuxfoundation.org, Dan Williams , kunit-dev@googlegroups.com, Richard Weinberger , Stephen Boyd , Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org, Logan Gunthorpe On Thu, May 2, 2019 at 6:27 PM shuah wrote: > > On 5/1/19 5:01 PM, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > Please add a bit more information on what this config option > does. Why should user care to enable it? > > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > + > > Same here. Sounds reasonable. Will fix in the next revision. < snip > Thanks! _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um