From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 072F1211CBCE9 for ; Fri, 8 Feb 2019 16:56:46 -0800 (PST) Received: by mail-ot1-x344.google.com with SMTP id z19so4945899otm.2 for ; Fri, 08 Feb 2019 16:56:46 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-15-brendanhiggins@google.com> <20181130034525.GP18410@garbanzo.do-not-panic.com> <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> In-Reply-To: <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> From: Brendan Higgins Date: Fri, 8 Feb 2019 16:56:34 -0800 Message-ID: Subject: Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Kieran Bingham Cc: brakmo@fb.com, dri-devel@lists.freedesktop.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , Frank Rowand , linux-nvdimm@lists.01.org, richard@nod.at, Knut Omang , Felix Guo , Joel Stanley , jdike@addtoit.com, Tim.Bird@sony.com, Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , kunit-dev@googlegroups.com, Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , mpe@ellerman.id.au, joe@perches.com, khilman@baylibre.com List-ID: On Thu, Dec 6, 2018 at 4:16 AM Kieran Bingham wrote: > > Hi Brendan, > > On 03/12/2018 23:53, Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 7:45 PM Luis Chamberlain wrote: > >> > >> On Thu, Nov 29, 2018 at 01:56:37PM +0000, Kieran Bingham wrote: > >>> Hi Brendan, > >>> > >>> Please excuse the top posting, but I'm replying here as I'm following > >>> the section "Creating a kunitconfig" in Documentation/kunit/start.rst. > >>> > >>> Could the three line kunitconfig file live under say > >>> arch/um/configs/kunit_defconfig? > > > Further consideration to this topic - I mentioned putting it in > arch/um/configs > > - but I think this is wrong. > > We now have a location for config-fragments, which is essentially what > this is, under kernel/configs > > So perhaps an addition as : > > kernel/configs/kunit.config > > Would be more appropriate - and less (UM) architecture specific. Sorry for the long radio silence. I just got around to doing this and I found that there are some configs that are desirable to have when running KUnit under x86 in a VM, but not UML. So should we have one that goes in with config-fragments and others that go into architectures? Another idea, it would be nice to have a KUnit config that runs all known tests (this probably won't work in practice once we start testing mutually exclusive things or things with lots of ifdeffery, but it probably something we should try to maintain as best as we can?); this probably shouldn't go in with the fragments, right? I will be sending another revision out soon, but I figured I might be able to catch you before I did so. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E4DBC169C4 for ; Sat, 9 Feb 2019 00:56:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C602520855 for ; Sat, 9 Feb 2019 00:56:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sRYdcdA8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726791AbfBIA4r (ORCPT ); Fri, 8 Feb 2019 19:56:47 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:44205 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbfBIA4r (ORCPT ); Fri, 8 Feb 2019 19:56:47 -0500 Received: by mail-ot1-f67.google.com with SMTP id e24so8912225otp.11 for ; Fri, 08 Feb 2019 16:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yp7edThPT1PyrBkFC38ySq+JVx70JcEvihKyDRoM37Q=; b=sRYdcdA8OhrfMS/N6X63JZP6zOjqS3E3XLAAOSDezNKjC5uNOTsJu1iAUIycOw8QWn K7pSO3vA5MMWzpCsJYB+KYv7HCM2iiTdU/Sd5IdIUIaDrD+ehH1ANCcmT3Z7EWn88J1c apLKEbM/Rvat/f6aqZWsto+oucmfmMwNjDvZaP+Wa0WnG6yFn6pEnkfXmdIqhfh3+3aj WMdE6jlFa+VqbLKpPqYPCN/+vUKQpvg/sNnUT64kexpLsJtGkiVvrT3H/SQ2fbsBZvgj xYFsgsOjQ9FL4nWTKdu7F+mnfmNruUzGfGNXX2SrnAzclWa8WoS89FYou5jxZbOwWv6a gHeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yp7edThPT1PyrBkFC38ySq+JVx70JcEvihKyDRoM37Q=; b=BmBs5dZb4UwL/K8zVazfdBJUwGWT1KTMwePpTZ27EkGimzX06zGtgVuFlfKdMuRy2Z hZbKL4ziyKf0TsfDCwrQWLNX/S82OO180jak7W1jaVz03rDqSId3AgdOIWcSLEDEnKTd 3EuztzNv7SLerKzCsEN5I1jHRO5ZEUPd+ENCJ0IYqwtQx4j80xdlb3utshVfhzd9830T acZjDfjlXuR/6SU4Oggo7DqYnwXFqgVi7SrQ8LdS3296dsbuFdWo4X5oKgPWv3naTlaK iziKTVbhxvNGxXkKIQMbBoI8yQ8xeXBhBs1NjP4Y1cwEunAudIgEKvKAFCA2pLQcWpdO grBA== X-Gm-Message-State: AHQUAuZj5uBUVSOSioyPEcN7KCpNNhWcKTkCsZJWpfJ7t5G9cXl8iPaW mTfGCpLMPrALSmabGnGOhW5a3c8WoewdHtnZXp+JDA== X-Google-Smtp-Source: AHgI3IaZv6BiTnKhgi/TvLOxXsUYoA8irM4f1hTtn3rPa3uO8HK9R4qf4/idQZSOFJmSsS0zRDYdUE0DHryQTpqx7K4= X-Received: by 2002:a9d:7285:: with SMTP id t5mr16514861otj.228.1549673805806; Fri, 08 Feb 2019 16:56:45 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-15-brendanhiggins@google.com> <20181130034525.GP18410@garbanzo.do-not-panic.com> <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> In-Reply-To: <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> From: Brendan Higgins Date: Fri, 8 Feb 2019 16:56:34 -0800 Message-ID: Subject: Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit To: Kieran Bingham Cc: Luis Chamberlain , Greg KH , Kees Cook , shuah@kernel.org, Joel Stanley , mpe@ellerman.id.au, joe@perches.com, brakmo@fb.com, Steven Rostedt , Tim.Bird@sony.com, khilman@baylibre.com, Julia Lawall , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Linux Kernel Mailing List , jdike@addtoit.com, richard@nod.at, linux-um@lists.infradead.org, Daniel Vetter , dri-devel@lists.freedesktop.org, Rob Herring , dan.j.williams@intel.com, linux-nvdimm@lists.01.org, Frank Rowand , Knut Omang , Felix Guo Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 6, 2018 at 4:16 AM Kieran Bingham wrote: > > Hi Brendan, > > On 03/12/2018 23:53, Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 7:45 PM Luis Chamberlain wrote: > >> > >> On Thu, Nov 29, 2018 at 01:56:37PM +0000, Kieran Bingham wrote: > >>> Hi Brendan, > >>> > >>> Please excuse the top posting, but I'm replying here as I'm following > >>> the section "Creating a kunitconfig" in Documentation/kunit/start.rst. > >>> > >>> Could the three line kunitconfig file live under say > >>> arch/um/configs/kunit_defconfig? > > > Further consideration to this topic - I mentioned putting it in > arch/um/configs > > - but I think this is wrong. > > We now have a location for config-fragments, which is essentially what > this is, under kernel/configs > > So perhaps an addition as : > > kernel/configs/kunit.config > > Would be more appropriate - and less (UM) architecture specific. Sorry for the long radio silence. I just got around to doing this and I found that there are some configs that are desirable to have when running KUnit under x86 in a VM, but not UML. So should we have one that goes in with config-fragments and others that go into architectures? Another idea, it would be nice to have a KUnit config that runs all known tests (this probably won't work in practice once we start testing mutually exclusive things or things with lots of ifdeffery, but it probably something we should try to maintain as best as we can?); this probably shouldn't go in with the fragments, right? I will be sending another revision out soon, but I figured I might be able to catch you before I did so. From mboxrd@z Thu Jan 1 00:00:00 1970 From: brendanhiggins at google.com (Brendan Higgins) Date: Fri, 8 Feb 2019 16:56:34 -0800 Subject: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit In-Reply-To: <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-15-brendanhiggins@google.com> <20181130034525.GP18410@garbanzo.do-not-panic.com> <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> Message-ID: On Thu, Dec 6, 2018 at 4:16 AM Kieran Bingham wrote: > > Hi Brendan, > > On 03/12/2018 23:53, Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 7:45 PM Luis Chamberlain wrote: > >> > >> On Thu, Nov 29, 2018 at 01:56:37PM +0000, Kieran Bingham wrote: > >>> Hi Brendan, > >>> > >>> Please excuse the top posting, but I'm replying here as I'm following > >>> the section "Creating a kunitconfig" in Documentation/kunit/start.rst. > >>> > >>> Could the three line kunitconfig file live under say > >>> arch/um/configs/kunit_defconfig? > > > Further consideration to this topic - I mentioned putting it in > arch/um/configs > > - but I think this is wrong. > > We now have a location for config-fragments, which is essentially what > this is, under kernel/configs > > So perhaps an addition as : > > kernel/configs/kunit.config > > Would be more appropriate - and less (UM) architecture specific. Sorry for the long radio silence. I just got around to doing this and I found that there are some configs that are desirable to have when running KUnit under x86 in a VM, but not UML. So should we have one that goes in with config-fragments and others that go into architectures? Another idea, it would be nice to have a KUnit config that runs all known tests (this probably won't work in practice once we start testing mutually exclusive things or things with lots of ifdeffery, but it probably something we should try to maintain as best as we can?); this probably shouldn't go in with the fragments, right? I will be sending another revision out soon, but I figured I might be able to catch you before I did so. From mboxrd@z Thu Jan 1 00:00:00 1970 From: brendanhiggins@google.com (Brendan Higgins) Date: Fri, 8 Feb 2019 16:56:34 -0800 Subject: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit In-Reply-To: <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-15-brendanhiggins@google.com> <20181130034525.GP18410@garbanzo.do-not-panic.com> <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190209005634.Eldo9rRR56TVpqEmFZnHbgTy1jcOEBFc8CZgpGl3GRM@z> On Thu, Dec 6, 2018 at 4:16 AM Kieran Bingham wrote: > > Hi Brendan, > > On 03/12/2018 23:53, Brendan Higgins wrote: > > On Thu, Nov 29, 2018@7:45 PM Luis Chamberlain wrote: > >> > >> On Thu, Nov 29, 2018@01:56:37PM +0000, Kieran Bingham wrote: > >>> Hi Brendan, > >>> > >>> Please excuse the top posting, but I'm replying here as I'm following > >>> the section "Creating a kunitconfig" in Documentation/kunit/start.rst. > >>> > >>> Could the three line kunitconfig file live under say > >>> arch/um/configs/kunit_defconfig? > > > Further consideration to this topic - I mentioned putting it in > arch/um/configs > > - but I think this is wrong. > > We now have a location for config-fragments, which is essentially what > this is, under kernel/configs > > So perhaps an addition as : > > kernel/configs/kunit.config > > Would be more appropriate - and less (UM) architecture specific. Sorry for the long radio silence. I just got around to doing this and I found that there are some configs that are desirable to have when running KUnit under x86 in a VM, but not UML. So should we have one that goes in with config-fragments and others that go into architectures? Another idea, it would be nice to have a KUnit config that runs all known tests (this probably won't work in practice once we start testing mutually exclusive things or things with lots of ifdeffery, but it probably something we should try to maintain as best as we can?); this probably shouldn't go in with the fragments, right? I will be sending another revision out soon, but I figured I might be able to catch you before I did so. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Higgins Subject: Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit Date: Fri, 8 Feb 2019 16:56:34 -0800 Message-ID: References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-15-brendanhiggins@google.com> <20181130034525.GP18410@garbanzo.do-not-panic.com> <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <0927c42a-8e65-f410-e6ed-27576572577f-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Kieran Bingham Cc: brakmo-b10kYP2dOMg@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Rob Herring , Frank Rowand , linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, richard-/L3Ra7n9ekc@public.gmane.org, Knut Omang , Felix Guo , Joel Stanley , jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org, Tim.Bird-7U/KSKJipcs@public.gmane.org, Kees Cook , linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Steven Rostedt , Julia Lawall , kunit-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org List-Id: dri-devel@lists.freedesktop.org On Thu, Dec 6, 2018 at 4:16 AM Kieran Bingham wrote: > > Hi Brendan, > > On 03/12/2018 23:53, Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 7:45 PM Luis Chamberlain wrote: > >> > >> On Thu, Nov 29, 2018 at 01:56:37PM +0000, Kieran Bingham wrote: > >>> Hi Brendan, > >>> > >>> Please excuse the top posting, but I'm replying here as I'm following > >>> the section "Creating a kunitconfig" in Documentation/kunit/start.rst. > >>> > >>> Could the three line kunitconfig file live under say > >>> arch/um/configs/kunit_defconfig? > > > Further consideration to this topic - I mentioned putting it in > arch/um/configs > > - but I think this is wrong. > > We now have a location for config-fragments, which is essentially what > this is, under kernel/configs > > So perhaps an addition as : > > kernel/configs/kunit.config > > Would be more appropriate - and less (UM) architecture specific. Sorry for the long radio silence. I just got around to doing this and I found that there are some configs that are desirable to have when running KUnit under x86 in a VM, but not UML. So should we have one that goes in with config-fragments and others that go into architectures? Another idea, it would be nice to have a KUnit config that runs all known tests (this probably won't work in practice once we start testing mutually exclusive things or things with lots of ifdeffery, but it probably something we should try to maintain as best as we can?); this probably shouldn't go in with the fragments, right? I will be sending another revision out soon, but I figured I might be able to catch you before I did so. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gsGwp-0000uP-9h for linux-um@lists.infradead.org; Sat, 09 Feb 2019 00:56:48 +0000 Received: by mail-ot1-x343.google.com with SMTP id i20so9050605otl.0 for ; Fri, 08 Feb 2019 16:56:46 -0800 (PST) MIME-Version: 1.0 References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-15-brendanhiggins@google.com> <20181130034525.GP18410@garbanzo.do-not-panic.com> <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> In-Reply-To: <0927c42a-8e65-f410-e6ed-27576572577f@ideasonboard.com> From: Brendan Higgins Date: Fri, 8 Feb 2019 16:56:34 -0800 Message-ID: Subject: Re: [RFC v3 14/19] Documentation: kunit: add documentation for KUnit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Kieran Bingham Cc: brakmo@fb.com, dri-devel@lists.freedesktop.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , Frank Rowand , linux-nvdimm@lists.01.org, richard@nod.at, Knut Omang , Felix Guo , Joel Stanley , jdike@addtoit.com, Tim.Bird@sony.com, Kees Cook , linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , dan.j.williams@intel.com, kunit-dev@googlegroups.com, Greg KH , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , mpe@ellerman.id.au, joe@perches.com, khilman@baylibre.com On Thu, Dec 6, 2018 at 4:16 AM Kieran Bingham wrote: > > Hi Brendan, > > On 03/12/2018 23:53, Brendan Higgins wrote: > > On Thu, Nov 29, 2018 at 7:45 PM Luis Chamberlain wrote: > >> > >> On Thu, Nov 29, 2018 at 01:56:37PM +0000, Kieran Bingham wrote: > >>> Hi Brendan, > >>> > >>> Please excuse the top posting, but I'm replying here as I'm following > >>> the section "Creating a kunitconfig" in Documentation/kunit/start.rst. > >>> > >>> Could the three line kunitconfig file live under say > >>> arch/um/configs/kunit_defconfig? > > > Further consideration to this topic - I mentioned putting it in > arch/um/configs > > - but I think this is wrong. > > We now have a location for config-fragments, which is essentially what > this is, under kernel/configs > > So perhaps an addition as : > > kernel/configs/kunit.config > > Would be more appropriate - and less (UM) architecture specific. Sorry for the long radio silence. I just got around to doing this and I found that there are some configs that are desirable to have when running KUnit under x86 in a VM, but not UML. So should we have one that goes in with config-fragments and others that go into architectures? Another idea, it would be nice to have a KUnit config that runs all known tests (this probably won't work in practice once we start testing mutually exclusive things or things with lots of ifdeffery, but it probably something we should try to maintain as best as we can?); this probably shouldn't go in with the fragments, right? I will be sending another revision out soon, but I figured I might be able to catch you before I did so. _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um