From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8565FC33CAA for ; Thu, 23 Jan 2020 22:15:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 439FE22522 for ; Thu, 23 Jan 2020 22:15:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sjK3dNrI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728057AbgAWWPZ (ORCPT ); Thu, 23 Jan 2020 17:15:25 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38366 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbgAWWPZ (ORCPT ); Thu, 23 Jan 2020 17:15:25 -0500 Received: by mail-pg1-f195.google.com with SMTP id a33so2091159pgm.5 for ; Thu, 23 Jan 2020 14:15:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tXBwxhPJLlGlsNaOTHSkvCkjScA/qmIHT8AzKeFydO8=; b=sjK3dNrIhnT59AxIccgYBllx19BQGy09eIHs6Xza5RECBLrH81Q0N6IZNxqQsOUm4e 2CeGJhJR5oByJjb7DAdHCzom/7osgyWHaVehLZF59dO05VIChggrcIa4b7UubLHPGtm9 /p0hwCYEeFFyi7UWUv+6ahVXnReFYX1HDhjzYmMvx+lNRdPlRhAnRsWBTaUKS+MFk8in Z5cK+NAmrcy4thsvsX2HYP5yYWOHV7mKgi7M4eSRABul9JHpWWJx0F7zaYaMHmNxh6hn YokQmcOPSvM3I9n31XimMGfbUaLXzKaQIeaMVdmTJdA6EiMkxuhgrWhJN9LQm8oV2/iP 2tHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tXBwxhPJLlGlsNaOTHSkvCkjScA/qmIHT8AzKeFydO8=; b=igpuBRQ+2z4X4ZOqeJaXggOJaxVaeTBIOKVISpQQGdgP4LR7tc4hn6NbdcSF15z9iP GwSHBtWoZb6Do9p3owrRmvhaYAyx8RvzKf+tpDC/doMHTrgM5A/vrUk6PiU8iMvEHoJM W8cm7a67UhIHCat6HrZ3u0rnbmp4UphogGruwknfYiISbGpSjtzX6K3KNu+8Xm5sbjuF Pu4kIPzIjVd+z5vVfAIIWiqRUPCT/5TIeuAurKlMTrOt3FK03+SHaOL6egHeeIM2zeEQ mFTBvt9HVte8Ih7yCKnwtr5QT7vv/OnBqloGzMYRCh6++BvkYncyP6pL0kAS7tkCOw3W ckHw== X-Gm-Message-State: APjAAAWWSzWnFC8wER5cGgRTdo0zhafmAXhC9ijO3482RKuBV3zZNwWA 0P5Y8IGrQa7eywgV506b/vaxEkSLmSqBf3SrbA6dCg== X-Google-Smtp-Source: APXvYqziuRWMnPljfz/bZp0L+T5uoyDPGMPlFhp5B6LWngEd1YcbHv5Z4Ye1FJte7JIRLPmklQwFeQrvOC+e+F9qqQM= X-Received: by 2002:a63:597:: with SMTP id 145mr550696pgf.384.1579817724899; Thu, 23 Jan 2020 14:15:24 -0800 (PST) MIME-Version: 1.0 References: <20191211192742.95699-1-brendanhiggins@google.com> <20191211192742.95699-2-brendanhiggins@google.com> In-Reply-To: From: Brendan Higgins Date: Thu, 23 Jan 2020 14:15:13 -0800 Message-ID: Subject: Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency To: Linus Walleij Cc: Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um , "linux-kernel@vger.kernel.org" , David Gow , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Sorry for not getting to this before I went on vacation. On Mon, Dec 16, 2019 at 2:39 AM Linus Walleij wrote: > > On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins > wrote: > > > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe': > > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource' > > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency. > > > > Reported-by: Brendan Higgins > > Signed-off-by: Brendan Higgins > > Patch applied but I augmented it with the recently added > OF dependency so it now says: > depends on OF && HAS_IOMEM Probably too late now to be helpful, but I can confirm that OF does NOT depend on HAS_IOMEM, so this patch was still needed. Thanks regardless! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iukl6-0005Kl-HD for linux-um@lists.infradead.org; Thu, 23 Jan 2020 22:15:29 +0000 Received: by mail-pg1-x544.google.com with SMTP id l24so2096366pgk.2 for ; Thu, 23 Jan 2020 14:15:25 -0800 (PST) MIME-Version: 1.0 References: <20191211192742.95699-1-brendanhiggins@google.com> <20191211192742.95699-2-brendanhiggins@google.com> In-Reply-To: From: Brendan Higgins Date: Thu, 23 Jan 2020 14:15:13 -0800 Message-ID: Subject: Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Linus Walleij Cc: Richard Weinberger , Jeff Dike , linux-um , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , David Gow , Anton Ivanov Sorry for not getting to this before I went on vacation. On Mon, Dec 16, 2019 at 2:39 AM Linus Walleij wrote: > > On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins > wrote: > > > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe': > > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource' > > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency. > > > > Reported-by: Brendan Higgins > > Signed-off-by: Brendan Higgins > > Patch applied but I augmented it with the recently added > OF dependency so it now says: > depends on OF && HAS_IOMEM Probably too late now to be helpful, but I can confirm that OF does NOT depend on HAS_IOMEM, so this patch was still needed. Thanks regardless! _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um