From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Higgins Subject: Re: [PATCH v2 07/17] kunit: test: add initial tests Date: Thu, 2 May 2019 13:30:12 -0700 Message-ID: References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> <20190502105849.GB12416@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190502105849.GB12416@kroah.com> Sender: linux-kernel-owner@vger.kernel.org To: Greg KH Cc: Frank Rowand , Kees Cook , Kieran Bingham , Luis Chamberlain , Rob Herring , Stephen Boyd , shuah@kernel.org, devicetree , dri-devel , kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter List-Id: linux-nvdimm@lists.01.org On Thu, May 2, 2019 at 3:58 AM Greg KH wrote: > > On Wed, May 01, 2019 at 04:01:16PM -0700, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > Can't these tests be module? At this time, no. KUnit doesn't support loading tests as kernel modules; it is something we could add in in the future, but I would rather not open that can of worms right now. There are some other things I would like to do that would probably be easier to do before adding support for tests as loadable modules. > > Or am I mis-reading the previous logic? > > Anyway, just a question, nothing objecting to this as-is for now. Cool Cheers! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_MED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19B3C43219 for ; Thu, 2 May 2019 20:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B365020B7C for ; Thu, 2 May 2019 20:30:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gITVrJC9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726376AbfEBUaY (ORCPT ); Thu, 2 May 2019 16:30:24 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:36623 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726297AbfEBUaY (ORCPT ); Thu, 2 May 2019 16:30:24 -0400 Received: by mail-ot1-f65.google.com with SMTP id b18so3361047otq.3 for ; Thu, 02 May 2019 13:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EDdiyphkogtVcXTbSVRyR+FjzQZde+G185126UMJh7I=; b=gITVrJC9deQ8wHwXinOhDV5dI98+XHC/WuqFuL8GH7a8CRP7Weez43rOFpDLFNlC0p SurYDhddnsqnL5Ihvys33lK/4j+PLxs8IphZcAQuHXXE7X5COStC3ZBhj/5h/Hdg9FPW sQYG3mb/RBDu620PDIXl0abFAqievobMhbfvYW6GdeEoPEN8iXGYFBkxbfpJn8Y1y4f8 F6SjQjXGRwZVR+lGXlZDhrUGxSdzCSH/YiD/bsD5q2GkFQLqoLWuw3S9nlwb/QcTf+/G D2dqk3uPHxSxGLiPz52WCid9DnN+TbYr8zJiLQQDEG4D0HgQVfXL2NqaKqq1E/1r4TBH gHpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EDdiyphkogtVcXTbSVRyR+FjzQZde+G185126UMJh7I=; b=LMHbZFmDcbtUU5CY/jSRWOIT/XjrpaahRSojX5qhDnW+iAgWKAe+adTYHelLIyOuc/ 4gU1FxmDFOnn0JxGEPIh7jvp3WzzwXQ1/tW1acSvNPmdWQiTTCD04C4vKftEuqcFlHS0 IdCqg8Us8HOPyk/pVPq8zC0cYfpWGZiODmJK3pXjKiAipd1uGcwK6tTdghmNjCwzPBRd T/C0rt6XVl/V84HCfWHoD+8c5lUfDzsNn5LW0j2cERtPQkcVPIi/kkOCcbiBw5cjnQRx EQ2+Q4Z0j19Kb4/Lctg3sIu9Gqd7rXhtP9xkl6sHE+ExYTPCaJclrnuYLAB+trgvE7la 9b/A== X-Gm-Message-State: APjAAAXal4UqoHHOifQwUuAKMsa7I0tt/nqJqgu79KXBltX0ZC5LItqV xnMiLKlvcb35BONxVJkpduV5aZqEF3WrjqJVyBxRug== X-Google-Smtp-Source: APXvYqz43GD9Ydk/3iHIuvGx3dSX5DTZZLzaJSUOTfbGyq2mCG6ID5DjuBQ5u6fo5kf0q+kWNBtbkFi3ckrHB0dUqUs= X-Received: by 2002:a9d:7f19:: with SMTP id j25mr3854222otq.25.1556829023216; Thu, 02 May 2019 13:30:23 -0700 (PDT) MIME-Version: 1.0 References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> <20190502105849.GB12416@kroah.com> In-Reply-To: <20190502105849.GB12416@kroah.com> From: Brendan Higgins Date: Thu, 2 May 2019 13:30:12 -0700 Message-ID: Subject: Re: [PATCH v2 07/17] kunit: test: add initial tests To: Greg KH Cc: Frank Rowand , Kees Cook , Kieran Bingham , Luis Chamberlain , Rob Herring , Stephen Boyd , shuah@kernel.org, devicetree , dri-devel , kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, Linux Kernel Mailing List , linux-kselftest@vger.kernel.org, linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Dan Williams , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 2, 2019 at 3:58 AM Greg KH wrote: > > On Wed, May 01, 2019 at 04:01:16PM -0700, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > Can't these tests be module? At this time, no. KUnit doesn't support loading tests as kernel modules; it is something we could add in in the future, but I would rather not open that can of worms right now. There are some other things I would like to do that would probably be easier to do before adding support for tests as loadable modules. > > Or am I mis-reading the previous logic? > > Anyway, just a question, nothing objecting to this as-is for now. Cool Cheers! From mboxrd@z Thu Jan 1 00:00:00 1970 From: brendanhiggins at google.com (Brendan Higgins) Date: Thu, 2 May 2019 13:30:12 -0700 Subject: [PATCH v2 07/17] kunit: test: add initial tests In-Reply-To: <20190502105849.GB12416@kroah.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> <20190502105849.GB12416@kroah.com> Message-ID: On Thu, May 2, 2019 at 3:58 AM Greg KH wrote: > > On Wed, May 01, 2019 at 04:01:16PM -0700, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > Can't these tests be module? At this time, no. KUnit doesn't support loading tests as kernel modules; it is something we could add in in the future, but I would rather not open that can of worms right now. There are some other things I would like to do that would probably be easier to do before adding support for tests as loadable modules. > > Or am I mis-reading the previous logic? > > Anyway, just a question, nothing objecting to this as-is for now. Cool Cheers! From mboxrd@z Thu Jan 1 00:00:00 1970 From: brendanhiggins@google.com (Brendan Higgins) Date: Thu, 2 May 2019 13:30:12 -0700 Subject: [PATCH v2 07/17] kunit: test: add initial tests In-Reply-To: <20190502105849.GB12416@kroah.com> References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> <20190502105849.GB12416@kroah.com> Message-ID: Content-Type: text/plain; charset="UTF-8" Message-ID: <20190502203012.78P_u0KL-90RsmF3CumDM_hZYhAcE_1fmzhfw4hHh6E@z> On Thu, May 2, 2019@3:58 AM Greg KH wrote: > > On Wed, May 01, 2019@04:01:16PM -0700, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > Can't these tests be module? At this time, no. KUnit doesn't support loading tests as kernel modules; it is something we could add in in the future, but I would rather not open that can of worms right now. There are some other things I would like to do that would probably be easier to do before adding support for tests as loadable modules. > > Or am I mis-reading the previous logic? > > Anyway, just a question, nothing objecting to this as-is for now. Cool Cheers! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMILY-0007R4-Fd for linux-um@lists.infradead.org; Thu, 02 May 2019 20:30:25 +0000 Received: by mail-ot1-x344.google.com with SMTP id g24so3367637otq.2 for ; Thu, 02 May 2019 13:30:24 -0700 (PDT) MIME-Version: 1.0 References: <20190501230126.229218-1-brendanhiggins@google.com> <20190501230126.229218-8-brendanhiggins@google.com> <20190502105849.GB12416@kroah.com> In-Reply-To: <20190502105849.GB12416@kroah.com> From: Brendan Higgins Date: Thu, 2 May 2019 13:30:12 -0700 Message-ID: Subject: Re: [PATCH v2 07/17] kunit: test: add initial tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Greg KH Cc: Petr Mladek , linux-doc@vger.kernel.org, Amir Goldstein , dri-devel , Sasha Levin , Michael Ellerman , linux-kselftest@vger.kernel.org, shuah@kernel.org, Rob Herring , linux-nvdimm , Frank Rowand , Knut Omang , Kieran Bingham , wfg@linux.intel.com, Joel Stanley , David Rientjes , Jeff Dike , Dan Carpenter , devicetree , linux-kbuild@vger.kernel.org, "Bird, Timothy , linux-um@lists.infradead.org, Steven Rostedt" , Julia Lawall , Dan Williams , kunit-dev@googlegroups.com, Richard Weinberger , Stephen Boyd , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel@vger.kernel.org, Logan Gunthorpe , Kevin Hilman On Thu, May 2, 2019 at 3:58 AM Greg KH wrote: > > On Wed, May 01, 2019 at 04:01:16PM -0700, Brendan Higgins wrote: > > Add a test for string stream along with a simpler example. > > > > Signed-off-by: Brendan Higgins > > --- > > kunit/Kconfig | 12 ++++++ > > kunit/Makefile | 4 ++ > > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ > > kunit/string-stream-test.c | 61 ++++++++++++++++++++++++++ > > 4 files changed, 165 insertions(+) > > create mode 100644 kunit/example-test.c > > create mode 100644 kunit/string-stream-test.c > > > > diff --git a/kunit/Kconfig b/kunit/Kconfig > > index 64480092b2c24..5cb500355c873 100644 > > --- a/kunit/Kconfig > > +++ b/kunit/Kconfig > > @@ -13,4 +13,16 @@ config KUNIT > > special hardware. For more information, please see > > Documentation/kunit/ > > > > +config KUNIT_TEST > > + bool "KUnit test for KUnit" > > + depends on KUNIT > > + help > > + Enables KUnit test to test KUnit. > > + > > +config KUNIT_EXAMPLE_TEST > > + bool "Example test for KUnit" > > + depends on KUNIT > > + help > > + Enables example KUnit test to demo features of KUnit. > > Can't these tests be module? At this time, no. KUnit doesn't support loading tests as kernel modules; it is something we could add in in the future, but I would rather not open that can of worms right now. There are some other things I would like to do that would probably be easier to do before adding support for tests as loadable modules. > > Or am I mis-reading the previous logic? > > Anyway, just a question, nothing objecting to this as-is for now. Cool Cheers! _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um