From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DC8DC433F5 for ; Fri, 17 Sep 2021 05:40:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 630FD61130 for ; Fri, 17 Sep 2021 05:40:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234048AbhIQFlW (ORCPT ); Fri, 17 Sep 2021 01:41:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237123AbhIQFlV (ORCPT ); Fri, 17 Sep 2021 01:41:21 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4E62C061574 for ; Thu, 16 Sep 2021 22:39:59 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id p12-20020a17090adf8c00b0019c959bc795so933102pjv.1 for ; Thu, 16 Sep 2021 22:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tDmd8ycUb5A33cqxczJ56wHGFGeWT2rzATobJNiElZc=; b=mjKLzQ4indMMpCe2+SSAdTsz4b8weE1gFwDDjCVqrp9B3pKj/bdL1dSfl3/8kMyDCa OwNV8mBPxU0bohv0fNfCJuap5gQU8HNWcHGvgWIX9Lhe7vGcS0pmJGS5ohNAPqSW6y2b HqPHz2ZXAbYY+37RrveljTcqnLFKRWJM074UPOg0nvYDWFIceiA6ATCiTK4fbdFOd+Vo dqzJiLqCMHcx+FD5eJ2pRWB6exkXZDw4haYWbQNDsI6lawjDscBFXvjHFo6B0WPx7Aoy 3w8qeKXz5bhoAg7yncGtqLrlHT7BrfpztPQ9n7irXnqvU4hMwQ7+uzq+gLEMQP63o4JJ +kHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tDmd8ycUb5A33cqxczJ56wHGFGeWT2rzATobJNiElZc=; b=VDBRT3C7QDSaYdPcs96kFaOzX1ZkoqSa44AVoodG3/8W7hT91TGqKJr0INKNsKlP5x R81GJ6xcdeOTWLpPxwMn7lVnty3ybalo0FsTuUhyPqtkw4DIZmN1epRjfdoabAEfAjdD c3OJwKzLJkPme7XkuC0NbiQRTDvDO6iPJ/ubk4m05x1wcASraTE0daWe1kZiBCQz31X7 b8Br7u5KJq7dVcGjSqu5HNTWOBZLOWmpIvCdAODmYpA6q/cBgYYp4tbNsOtWhuoLvbKz ObodKMRpZNoH7DEI2DwfuRCzXCV9XpAKLSrQkofr9jKTfbrHnaHBISAD3fKYS5SSEXVQ 9eIw== X-Gm-Message-State: AOAM532W0XYIrGTFQD/uvSyCS0svk8ajsGoPCP3O1nYV/0na5UwMNVyB B3TSx0kPBkS39O+QwW8rmfn7u9S8f5pn6+wbhy0Dvw== X-Google-Smtp-Source: ABdhPJzZMkaEHIdpYul5buHW1Dv1P4OGtrg3QMqu5AMf+ifi+Fe4a5b98Wn+iDry0ryDPZOE6JwsAGuPU3s4o9OB4gc= X-Received: by 2002:a17:902:6f17:b0:139:eec4:867e with SMTP id w23-20020a1709026f1700b00139eec4867emr8140416plk.77.1631857198933; Thu, 16 Sep 2021 22:39:58 -0700 (PDT) MIME-Version: 1.0 References: <36aa5cb7-e3d6-33cb-9ac6-c9ff1169d711@linuxfoundation.org> <120389b9-f90b-0fa3-21d5-1f789b4c984d@linuxfoundation.org> <3bad5d2f-8ce7-d0b9-19ad-def68d4193dd@linuxfoundation.org> In-Reply-To: From: Brendan Higgins Date: Thu, 16 Sep 2021 22:39:47 -0700 Message-ID: Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] To: Arnd Bergmann Cc: Shuah Khan , Linus Torvalds , Naresh Kamboju , Mathias Nyman , Johannes Berg , Jakub Kicinski , Ariel Elior , GR-everest-linux-l2@marvell.com, Wei Liu , Linux ARM , open list , Netdev , lkft-triage@lists.linaro.org, "David S. Miller" , Greg Kroah-Hartman , Nick Desaulniers , Nathan Chancellor , Daniel Borkmann , Alexei Starovoitov , Eric Dumazet , KUnit Development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 14, 2021 at 3:04 PM Arnd Bergmann wrote: > > On Tue, Sep 14, 2021 at 10:48 PM Brendan Higgins > wrote: > > > > On Mon, Sep 13, 2021 at 1:55 PM Shuah Khan wrote: > > > > > > On 9/8/21 3:24 PM, Brendan Higgins wrote: > > > Brendan, > > > > > > Would you like to send me the fix with Suggested-by for Arnd or Kees? > > > > So it looks like Arnd's fix was accepted (whether by him or someone > > else) for property-entry-test and Linus already fixed thunderbolt, so > > the only remaining of Arnd's patches is for the bitfield test, so I'll > > resend that one in a bit. > > > > Also, I haven't actually tried Linus' suggestion yet, but the logic is > > sound and the change *should* be fairly unintrusive - I am going to > > give that a try and report back (but I will get the bitfield > > structleak disable patch out first since I already got that applying). > > Looking at my randconfig tree, I find these six instances: > > $ git grep -w DISABLE_STRUCTLEAK_PLUGIN > drivers/base/test/Makefile:CFLAGS_property-entry-test.o += > $(DISABLE_STRUCTLEAK_PLUGIN) > drivers/iio/test/Makefile:CFLAGS_iio-test-format.o += > $(DISABLE_STRUCTLEAK_PLUGIN) > drivers/mmc/host/Makefile:CFLAGS_sdhci-of-aspeed.o += > $(DISABLE_STRUCTLEAK_PLUGIN) > drivers/thunderbolt/Makefile:CFLAGS_test.o += $(DISABLE_STRUCTLEAK_PLUGIN) > lib/Makefile:CFLAGS_test_scanf.o += $(DISABLE_STRUCTLEAK_PLUGIN) > lib/Makefile:CFLAGS_bitfield_kunit.o += $(DISABLE_STRUCTLEAK_PLUGIN) > scripts/Makefile.gcc-plugins: DISABLE_STRUCTLEAK_PLUGIN += > -fplugin-arg-structleak_plugin-disable > scripts/Makefile.gcc-plugins:export DISABLE_STRUCTLEAK_PLUGIN Alright, I incorporated all the above into a patchset that I think is ready to send out, but I had a couple of issues with the above suggestions: - I could not find a config which causes a stacksize warning for sdhci-of-aspeed. - test_scanf is not a KUnit test. - Linus already fixed the thunderbolt test by breaking up the test cases. I am going to send out patches for the thunderbolt test and for the sdhci-of-aspeed test for the sake of completeness, but I am not sure if we should merge those two. I'll let y'all decide on the patch review. I only based the thunderbolt and bitfield test fixes on actual patches from Arnd, but I think Arnd pretty much did all the work here so I am crediting him with a Co-developed-by on all the other patches, so Arnd: please follow up on the other patches with a signed-off-by, unless you would rather me credit you in some other way. > Sorry for failing to submit these as a proper patch. If you send a new version, > I think you need to make sure you cover all of the above, using whichever > change you like best. I am still going to try to get Linus' suggestion working since it actually solves the problem, but I would rather get the above suggested fix out there since it is quick and I know it works. Cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB731C433F5 for ; Fri, 17 Sep 2021 05:42:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B92261019 for ; Fri, 17 Sep 2021 05:42:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B92261019 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mFmtWBcbYYxw/MXK8wDeYaIqEDVTx39jrfp6QpReKfY=; b=MQ+MrOIkHn57Wq Uc37MWTCVClIQrC9qj2XtGa9fwvzDzl2+eT9FYOECXU7BsmScNz2C8EUcwSKkI2PHhLe8wlEb7+Vk Y9mMq6q/I+pYXb3TnN1JViUnE1hEQ1RwbYk1HXcODpaP+EQgVAHXuK/CisO95RL7yX8MlIIkbLI34 omv7XBX1Sbpr2rzG4ASvQy3CBPOyK33wiWY+t0im/9lJY6EHKcbodvTMyHxuACdqb9wHfDHe2TKFH +b+821aLkbl0+SyxubCtPHsqPPuaFiS4n20H4MLAOeA0DpbJIbseDsVtgQ7nXjDCETucqK09EUnw1 tLwfGMGtumIxH2AVzgkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mR6bX-00DEyI-Lb; Fri, 17 Sep 2021 05:40:07 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mR6bT-00DEwl-6R for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 05:40:04 +0000 Received: by mail-pl1-x629.google.com with SMTP id bb10so5452514plb.2 for ; Thu, 16 Sep 2021 22:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tDmd8ycUb5A33cqxczJ56wHGFGeWT2rzATobJNiElZc=; b=mjKLzQ4indMMpCe2+SSAdTsz4b8weE1gFwDDjCVqrp9B3pKj/bdL1dSfl3/8kMyDCa OwNV8mBPxU0bohv0fNfCJuap5gQU8HNWcHGvgWIX9Lhe7vGcS0pmJGS5ohNAPqSW6y2b HqPHz2ZXAbYY+37RrveljTcqnLFKRWJM074UPOg0nvYDWFIceiA6ATCiTK4fbdFOd+Vo dqzJiLqCMHcx+FD5eJ2pRWB6exkXZDw4haYWbQNDsI6lawjDscBFXvjHFo6B0WPx7Aoy 3w8qeKXz5bhoAg7yncGtqLrlHT7BrfpztPQ9n7irXnqvU4hMwQ7+uzq+gLEMQP63o4JJ +kHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tDmd8ycUb5A33cqxczJ56wHGFGeWT2rzATobJNiElZc=; b=DlgOERW6rAQFJc+L7HV6H44aOawD/dLH9LVzerv2fazSHMaQhp5yA5rCWdyf9rCJwW sKVdvUb88QM+vMMptZwZYojARr92NspUNwI3a1o97a83v8PZqe9C2YQ7Ctt9tAgy9ll1 n/1ieXFB+oMXtMH1XsKoqzJGGxd2CbL++vI19OH6IqXL8Ee4ISlzeIuTkAf9Hx1J7Z8Z dWI/+V6SrMU5XhD0YkxrtPxgFxgPPmbxug//JsPx31KukYxTTLvr+hylqTGKLv38uuKy x3JC1bj18COZfBZSiumNNEnHVg107n6eqRBKMZ8RHDTnfXLcivk4jtatLlCByar+/8eV k74g== X-Gm-Message-State: AOAM5310kSLTv/z9ZKG6dtyKaLUb6cX9PAY28E/kVm4FCY5kpCbSX4bN /mrrTVLAbc2PScsSeMno318UPt/buMhznFP//Bktdw== X-Google-Smtp-Source: ABdhPJzZMkaEHIdpYul5buHW1Dv1P4OGtrg3QMqu5AMf+ifi+Fe4a5b98Wn+iDry0ryDPZOE6JwsAGuPU3s4o9OB4gc= X-Received: by 2002:a17:902:6f17:b0:139:eec4:867e with SMTP id w23-20020a1709026f1700b00139eec4867emr8140416plk.77.1631857198933; Thu, 16 Sep 2021 22:39:58 -0700 (PDT) MIME-Version: 1.0 References: <36aa5cb7-e3d6-33cb-9ac6-c9ff1169d711@linuxfoundation.org> <120389b9-f90b-0fa3-21d5-1f789b4c984d@linuxfoundation.org> <3bad5d2f-8ce7-d0b9-19ad-def68d4193dd@linuxfoundation.org> In-Reply-To: From: Brendan Higgins Date: Thu, 16 Sep 2021 22:39:47 -0700 Message-ID: Subject: Re: ipv4/tcp.c:4234:1: error: the frame size of 1152 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] To: Arnd Bergmann Cc: Shuah Khan , Linus Torvalds , Naresh Kamboju , Mathias Nyman , Johannes Berg , Jakub Kicinski , Ariel Elior , GR-everest-linux-l2@marvell.com, Wei Liu , Linux ARM , open list , Netdev , lkft-triage@lists.linaro.org, "David S. Miller" , Greg Kroah-Hartman , Nick Desaulniers , Nathan Chancellor , Daniel Borkmann , Alexei Starovoitov , Eric Dumazet , KUnit Development X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_224003_308250_448E7979 X-CRM114-Status: GOOD ( 30.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 3:04 PM Arnd Bergmann wrote: > > On Tue, Sep 14, 2021 at 10:48 PM Brendan Higgins > wrote: > > > > On Mon, Sep 13, 2021 at 1:55 PM Shuah Khan wrote: > > > > > > On 9/8/21 3:24 PM, Brendan Higgins wrote: > > > Brendan, > > > > > > Would you like to send me the fix with Suggested-by for Arnd or Kees? > > > > So it looks like Arnd's fix was accepted (whether by him or someone > > else) for property-entry-test and Linus already fixed thunderbolt, so > > the only remaining of Arnd's patches is for the bitfield test, so I'll > > resend that one in a bit. > > > > Also, I haven't actually tried Linus' suggestion yet, but the logic is > > sound and the change *should* be fairly unintrusive - I am going to > > give that a try and report back (but I will get the bitfield > > structleak disable patch out first since I already got that applying). > > Looking at my randconfig tree, I find these six instances: > > $ git grep -w DISABLE_STRUCTLEAK_PLUGIN > drivers/base/test/Makefile:CFLAGS_property-entry-test.o += > $(DISABLE_STRUCTLEAK_PLUGIN) > drivers/iio/test/Makefile:CFLAGS_iio-test-format.o += > $(DISABLE_STRUCTLEAK_PLUGIN) > drivers/mmc/host/Makefile:CFLAGS_sdhci-of-aspeed.o += > $(DISABLE_STRUCTLEAK_PLUGIN) > drivers/thunderbolt/Makefile:CFLAGS_test.o += $(DISABLE_STRUCTLEAK_PLUGIN) > lib/Makefile:CFLAGS_test_scanf.o += $(DISABLE_STRUCTLEAK_PLUGIN) > lib/Makefile:CFLAGS_bitfield_kunit.o += $(DISABLE_STRUCTLEAK_PLUGIN) > scripts/Makefile.gcc-plugins: DISABLE_STRUCTLEAK_PLUGIN += > -fplugin-arg-structleak_plugin-disable > scripts/Makefile.gcc-plugins:export DISABLE_STRUCTLEAK_PLUGIN Alright, I incorporated all the above into a patchset that I think is ready to send out, but I had a couple of issues with the above suggestions: - I could not find a config which causes a stacksize warning for sdhci-of-aspeed. - test_scanf is not a KUnit test. - Linus already fixed the thunderbolt test by breaking up the test cases. I am going to send out patches for the thunderbolt test and for the sdhci-of-aspeed test for the sake of completeness, but I am not sure if we should merge those two. I'll let y'all decide on the patch review. I only based the thunderbolt and bitfield test fixes on actual patches from Arnd, but I think Arnd pretty much did all the work here so I am crediting him with a Co-developed-by on all the other patches, so Arnd: please follow up on the other patches with a signed-off-by, unless you would rather me credit you in some other way. > Sorry for failing to submit these as a proper patch. If you send a new version, > I think you need to make sure you cover all of the above, using whichever > change you like best. I am still going to try to get Linus' suggestion working since it actually solves the problem, but I would rather get the above suggested fix out there since it is quick and I know it works. Cheers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel